[jonahgabriel]

Summary

• Create scripts/check_ts_stubs.sh -- grep-based TS/JS stub detector
• Add 12-case test suite (tests/test_check_ts_stubs.sh)
• Export as check-ts-stubs pre-commit hook in .pre-commit-hooks.yaml

Context

Part of epic OMN-5597 (Stub Remediation and CI Prevention). This script detects forbidden // stub: markers in TypeScript/JavaScript files while allowing // stub-ok: <reason> and // intentional-skip: <reason> escape hatches. Downstream repos (omnidash) will consume this hook.

Test plan

• All 12 test cases pass (forbidden stubs, case variations, allowed markers, node_modules skip, non-TS ignore)
• Pre-commit hooks pass

Summary by CodeRabbit

• New Features

  • Added automatic pre-commit validation to detect and prevent accidental commits of unallowed stub markers in TypeScript/JavaScript files.

• Tests

  • Added test suite for stub detection validation.

[coderabbitai]

Caution

Review failed

Pull request was closed or merged during review

📝 Walkthrough

Walkthrough

A new pre-commit hook and accompanying Bash script have been added to detect forbidden stub markers in TypeScript and JavaScript files. The implementation includes a bash script that filters files by extension, searches for // stub: patterns (case-insensitive) while allowing stub-ok: and intentional-skip: markers, and a comprehensive test suite validating the detection logic across various scenarios.

Changes

Cohort / File(s)	Summary
Pre-commit Configuration .pre-commit-hooks.yaml	Added check-ts-stubs hook that executes the stub-checking script on TypeScript/JavaScript files, excluding node_modules/, dist/, and .next/ directories.
Stub Detection Implementation scripts/check_ts_stubs.sh	New bash script that identifies forbidden stub markers (// stub:) in TS/JS files while permitting allowed variants (stub-ok:, intentional-skip:), with filtering for file extensions and common generated directories.
Test Suite tests/test_check_ts_stubs.sh	Comprehensive test runner validating stub detection across multiple scenarios including forbidden markers in various cases, allowed markers, non-TS files, excluded directories, and edge cases with whitespace variations.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A bash script hops to check your files,
Seeking stubs in sneaky styles,
Pre-commit hooks stand guard with care,
No hidden markers escape the snare! 🎯

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding a TypeScript stub detector script and pre-commit hook. It is specific, concise, and clearly summarizes the primary changes in the changeset.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonahgabriel/omn-5598-ts-stub-detector

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}