Skip to content

docs(OMN-8762): add PR watch OCC evidence - #715

Merged
jonahgabriel merged 5 commits into
mainfrom
jonah/omn-8762-occ-evidence
May 6, 2026
Merged

jonahgabriel merged 5 commits into
mainfrom
jonah/omn-8762-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run validate-yaml contracts/OMN-8762.yaml
  • uv run python -m omnibase_core.validation.receipt_gate_cli --pr-body '' --pr-title 'OMN-8762: declare PR watch stub routing' --contracts-dir contracts --receipts-dir drift/dod_receipts --current-repo omnimarket --current-pr-number 525 --evidence-ticket OMN-8762 --branch-name jonah/omn-8762-node-pr-watch-orchestrator
  • uv run python scripts/check_dod_evidence_present.py contracts/OMN-8762.yaml

Summary by CodeRabbit

  • Chores
    • Added a new contract and associated verification receipts defining required evidence and gating rules for a new node component; emergency bypass disabled.
  • Tests
    • Recorded passing verification results for linting, unit tests, node discovery, and an additional CI validation step.

@coderabbitai

coderabbitai Bot commented May 5, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 299038de-daa9-4939-9095-7e6edb329ee9

📥 Commits

Reviewing files that changed from the base of the PR and between 318f6f4 and 88f9ccb.

📒 Files selected for processing (2)
  • contracts/OMN-8762.yaml
  • drift/dod_receipts/OMN-8762/dod-occ-validation/command.yaml
✅ Files skipped from review due to trivial changes (1)
  • drift/dod_receipts/OMN-8762/dod-occ-validation/command.yaml

📝 Walkthrough

Walkthrough

Defines contract OMN-8762 to create node node_pr_watch_orchestrator, plus four evidence receipt records showing lint, tests, node discovery, and receipt-gate validation completed with PASS (and associated PR numbers).

Changes

Node PR Watch Orchestrator Contract & Evidence

Layer / File(s) Summary
Contract Specification
contracts/OMN-8762.yaml
Adds contract for OMN-8762: metadata, evidence_requirements (tests: dod-stub-tests, ci: dod-lint, manual: dod-node-discovery, additional ci: dod-occ-validation), dod_evidence checks requiring status: PASS and specific pr_number values, and emergency_bypass: enabled: false.
Evidence Receipts — Test & Lint
drift/dod_receipts/OMN-8762/dod-stub-tests/command.yaml,
drift/dod_receipts/OMN-8762/dod-lint/command.yaml
Adds receipts recording pytest and ruff runs: status: PASS, exit_code: 0, probe_stdout showing test/lint success, run timestamps, commit SHAs, verifier/runner metadata, and pr_number: 525.
Evidence Receipts — Discovery
drift/dod_receipts/OMN-8762/dod-node-discovery/command.yaml
Adds receipt capturing onex discover output that finds node_pr_watch_orchestrator, includes probe_stdout, actual_output, exit_code: 0, and pr_number: 525.
Evidence Receipts — OCC/Receipt Gate Validation
drift/dod_receipts/OMN-8762/dod-occ-validation/command.yaml
Adds receipt for receipt-gate validation: multi-step probe_command that validates the contract, runs receipt_gate_cli and evidence checks, captures probe_stdout with RECEIPT GATE PASSED notice, and records exit_code and pr_number: 715.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through YAML fields tonight,
Adding proof the node is right,
Lint and tests gave cheerful beeps,
Discovery found the secret keeps,
OMN-8762—hop!—takes flight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'docs(OMN-8762): add PR watch OCC evidence' accurately describes the main change: adding OCC (Onex Change Control) evidence documentation for ticket OMN-8762, which involves creating a contract file and receipt evidence records.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-8762-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-8762/dod-stub-tests/command.yaml`:
- Line 9: Update the commit_sha in the dod-occ-validation/command.yaml receipt
to match the PR head SHA used by the other receipts: replace the current SHA
318f6f428a3892ce018077ae2c75d7084e653340 with
2f68e00f81a6db50bcf7646254b0f80a958ad2ad so the dod-occ-validation receipt
references the correct OmniMarket PR `#525` head commit.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: fd839a48-8815-44a4-865d-252e21c1be57

📥 Commits

Reviewing files that changed from the base of the PR and between ff92cbb and 318f6f4.

📒 Files selected for processing (4)
  • contracts/OMN-8762.yaml
  • drift/dod_receipts/OMN-8762/dod-lint/command.yaml
  • drift/dod_receipts/OMN-8762/dod-node-discovery/command.yaml
  • drift/dod_receipts/OMN-8762/dod-stub-tests/command.yaml

Comment thread drift/dod_receipts/OMN-8762/dod-stub-tests/command.yaml
@github-actions
github-actions Bot enabled auto-merge May 5, 2026 14:00
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 6, 2026
Merged via the queue into main with commit 442a2e0 May 6, 2026
26 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-8762-occ-evidence branch May 6, 2026 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant