Skip to content

docs(OMN-7980): bind omnimarket 715 receipt evidence - #1204

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-7980-omnimarket-715-occ-evidence
May 20, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-7980-omnimarket-715-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Changed files

  • drift/dod_receipts/OMN-7980/dod-wave-local-evidence/command.yaml

Validation

  • uv run validate-yaml contracts/OMN-7980.yaml
  • uv run python - <<'PY' ... ModelDodReceipt.model_validate(...) ... PY
  • uv run python -m omnibase_core.validation.receipt_gate_cli ... -> RECEIPT GATE PASSED: 1 check(s) across 1 ticket(s) all have PASS receipts.
  • uv run python -m omnibase_core.validation.validator_occ_merge_eligibility ... -> eligible=true, reason=eligible, receipt_ids=[OMN-7980:dod-wave-local-evidence:command]
  • git diff --check

Summary by CodeRabbit

  • Tests

    • Added evidence validation requirements for ticket OMN-7980, including status verification checks
    • Created new verification record with command-based checks
  • Chores

    • Updated receipt metadata and verification records to reflect current state

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 20, 2026 •

Copy link
Copy Markdown

Caution

Review failed

Pull request was closed or merged during review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3dc37917-287d-4124-89d2-9b92fb8e5aa0

📥 Commits

Reviewing files that changed from the base of the PR and between 9813b3d and 055aed6.

📒 Files selected for processing (3)
  • contracts/OMN-7980.yaml
  • drift/dod_receipts/OMN-7980/dod-occ-pr-1204/command.yaml
  • drift/dod_receipts/OMN-7980/dod-wave-local-evidence/command.yaml

📝 Walkthrough

Walkthrough

This PR extends evidence requirements for ticket OMN-7980 by adding a self-gate validation for OCC PR 1204, creating the corresponding command evidence record, and refreshing local evidence metadata. The changes establish a new proof checkpoint and update binding context for existing validation.

Changes

OMN-7980 Evidence Validation

Layer / File(s) Summary
PR 1204 self-gate validation setup
contracts/OMN-7980.yaml, drift/dod_receipts/OMN-7980/dod-occ-pr-1204/command.yaml
Contract adds a test requirement that validates OCC PR 1204 self-gate receipt by checking status: PASS and pr_number: 1204. A new dod_evidence record dod-occ-pr-1204 with the same command-based checks is added to the contract. The corresponding command evidence file records the gh pr view 1204 probe, captured PR state (OPEN, title), and execution metadata (timestamp, commit SHA, runner, exit code 0, branch, working directory).
Local evidence metadata refresh
drift/dod_receipts/OMN-7980/dod-wave-local-evidence/command.yaml
Evidence record metadata is updated with a new PR check command, probe output containing updated branch references, execution details (timestamp, commit SHA, runner), and binding context (branch, working_dir, pr_number).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#760: Adds similar OCC PR self-gate evidence validation records with PASS status and pr_number assertions in drift/dod_receipts/**/dod-occ-pr-*/command.yaml for OMN-7980.

Poem

🐰 A rabbit hops through drifting proof,
With PR 1204 to validate the roof,
Self-gates now verified with ev'ry bound,
Local evidence refreshed, truth uncrowned! ✓

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: binding omnimarket 715 receipt evidence to ticket OMN-7980, which is exactly what the changeset implements.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-7980-omnimarket-715-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-7980-omnimarket-715-occ-evidence branch from cd20b01 to 276c2a2 Compare May 20, 2026 05:38
@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 20, 2026 05:38
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-7980-omnimarket-715-occ-evidence branch from 276c2a2 to 055aed6 Compare May 20, 2026 05:40
@jonahgabriel
jonahgabriel merged commit a6c8a24 into main May 20, 2026
33 of 34 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-7980-omnimarket-715-occ-evidence branch May 20, 2026 05:43
jonahgabriel added a commit to OmniNode-ai/omniclaude that referenced this pull request May 22, 2026
…deploy-gate

Adds contracts/OMN-7980.yaml to satisfy the deploy-gate, validate-pr-contracts,
and DoD Evidence Check CI gates that block PR #1629.

The contract includes a deploy-evidence dod_evidence item referencing
docker exec omninode-runtime to verify the delegation orchestrator node
is live, per OMN-8912/OMN-9685 requirements.

OCC evidence: OmniNode-ai/onex_change_control#1204 (merged 2026-05-20,
SHA: a6c8a240c00003de36f584ee8e93b3e480a90d5d).
jonahgabriel added a commit that referenced this pull request Jun 12, 2026
…cher fix

Pairs omnimarket PR #1204 (branch jonah/omn-13104-fix-delegate-skill-runtime-profile,
head 03ef1b1b7c05310ce6ef90d5dcd76504cce118cf) which removes the stray top-level
runtime_profiles: [main] from node_delegate_skill_orchestrator/contract.yaml — the
root cause of the DEL-01..07 dispatcher DLQ regression.

Evidence-Ticket: OMN-13104
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant