Skip to content

chore(OMN-10486): add receipt dependency evidence - #657

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10486-occ-evidence
May 2, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-10486-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 2, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • add central OMN-10486 ticket contract for PR lifecycle OCC dependency classification
  • add PASS receipts for focused PR lifecycle tests, metadata dependency scope, and node drift
  • bind receipts to omnimarket#513 head 7c07e99d22ebfda5c5cbb6318727bf18096c4768

Verification

  • uv run validate-yaml contracts/OMN-10486.yaml
  • uv run python -c "from pathlib import Path; from omnibase_core.validation.receipt_gate import validate_pr_receipts; result=validate_pr_receipts(pr_body='Closes OMN-10486', contracts_dir=Path('contracts'), receipts_dir=Path('drift/dod_receipts')); print(result.message); raise SystemExit(0 if result.passed else 1)"

Closes OMN-10486

Summary by CodeRabbit

  • Chores
    • Added contract definitions and validation evidence records for ticket OMN-10486 to establish completion criteria for dependency classification improvements. Includes verification records documenting test execution results, dependency validation, and system state confirmation through automated validation procedures. No end-user functionality changes.

@coderabbitai

coderabbitai Bot commented May 2, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 10ace810-d357-4bc4-85f3-8eabc3c576b6

📥 Commits

Reviewing files that changed from the base of the PR and between 4f797e2 and 3d76a59.

📒 Files selected for processing (4)
  • contracts/OMN-10486.yaml
  • drift/dod_receipts/OMN-10486/dod-001/command.yaml
  • drift/dod_receipts/OMN-10486/dod-002/command.yaml
  • drift/dod_receipts/OMN-10486/dod-003/command.yaml

📝 Walkthrough

Walkthrough

This PR introduces a new contract definition for ticket OMN-10486 ("Classify receipt-only failures as OCC dependencies") that designates it as an interface change affecting events and public_api, along with three supporting receipt/evidence files documenting the fulfillment of its Definition of Done requirements through test execution, metadata validation, and drift checks.

Changes

Contract and Evidence Records

Layer / File(s) Summary
Contract Definition
contracts/OMN-10486.yaml
New contract specifies OMN-10486 as a seam/interface-change ticket, lists events and public_api interfaces, disables emergency bypass, and defines three DOD evidence items (dod-001, dod-002, dod-003) that require corresponding receipt files.
Evidence Records
drift/dod_receipts/OMN-10486/dod-00{1,2,3}/command.yaml
Three receipt files document proof of DOD fulfillment: dod-001 records 52 passed lifecycle tests, dod-002 records successful node metadata dependency validation, and dod-003 records drift validation in strict mode with 3 nodes checked and PASS status. All receipts include run metadata, probe commands, stdout output, and exit codes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

Poem

🐰 A contract drafted, three receipts in place,
Receipt-only failures now have their case!
The evidence gleams with test counts so bright,
Drift checks and dependencies—everything right! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding receipt dependency evidence for ticket OMN-10486, which aligns with the changeset that adds a contract file and three receipt files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-10486-occ-evidence

Review rate limit: 0/5 reviews remaining, refill in 54 minutes and 15 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge May 2, 2026 02:39
@jonahgabriel
jonahgabriel added this pull request to the merge queue May 2, 2026
Merged via the queue into main with commit 034aef7 May 2, 2026
29 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-10486-occ-evidence branch May 2, 2026 02:45
jonahgabriel added a commit that referenced this pull request May 16, 2026
… (#1044)

* evidence(OMN-11061): OCC contract and receipts for topic wiring PR #657

Adds ModelTicketContract + two dod receipts (sweep-clean, deploy) for
OMN-11061 — wire 49 undeclared topics into node_emit_daemon contract,
fix bifrost_delegation.yaml annotations, add handler block to
node_monitor_alert_responder. UNDECLARED_TOPIC reduced from 75 to 0.

* fix(OMN-11061): add self-binding receipt for OCC PR #1044

Adds self-binding receipt with pr_number: 1044 to clear OCC eligibility
pr_ticket_mismatch failure.
jonahgabriel added a commit that referenced this pull request May 21, 2026
Extends OCC bundle to cover all 7 wave 2 release PRs. Adds 4 new
dod_evidence items:
- dod-release-oii-v0.24.0 (omniintelligence PR #657 @ 63ca7019)
- dod-release-omem-v0.16.0 (omnimemory PR #324 @ 5da2e419)
- dod-release-omninode-infra-v0.2.0 (omninode_infra PR #442 @ 25609ed0)
- dod-release-omnidash-v1.0.0 (omnidash PR #102 @ 8508bd80)

Updates self-receipt probe_command to verify all 7 release receipts
exist. Updates contract title + summary to reflect full coverage.

Evidence-Ticket: OMN-11348
jonahgabriel added a commit that referenced this pull request May 21, 2026
* chore(OMN-11348): bind 2026-05-21 wave 2 batch release evidence

Wave 2 OCC contract + receipts for the 2026-05-21 full org-wide
release pipeline. Builds on OMN-11346 (wave 1 covered omnibase_infra
v0.36.1, omnimarket v0.3.1, omniclaude v0.24.0).

Tier 1 / Tier 2 receipts bundled in this PR:
- dod-release-spi-v0.21.1 (omnibase_spi PR #211 @ e29bf28)
- dod-release-compat-v0.4.1 (omnibase_compat PR #95 @ 9554d99)
- dod-release-core-v0.42.0 (omnibase_core PR #1120 @ 1834272)
- dod-occ-pr-self (self-binding)

Tier 3 / Tier 4 dod_evidence items (oii, omem, infra, dash) will be
appended in follow-up commits as those release PRs reach observable
head SHAs, mirroring the OMN-11346 incremental pattern.

Evidence-Ticket: OMN-11348

* fix(OMN-11348): set self-binding receipt pr_number to actual OCC PR

dod-occ-pr-self had pr_number: 0 which fails ModelDodReceipt validation
(>=1). Use real OCC PR number 1250 so receipt-gate accepts the receipt.

Evidence-Ticket: OMN-11348

* fix(OMN-11348): rebind spi receipt to v0.21.0 PR #212

Team-lead switched from Option 2 (skip v0.21.0 → release v0.21.1) to
Option 1 (delete orphan v0.21.0 tag → release fresh v0.21.0).

Changes:
- Renamed receipt dir dod-release-spi-v0.21.1 → dod-release-spi-v0.21.0
- Receipt YAML rebound to PR #212 @ 11a5721 (was PR #211 @ e29bf28)
- Contract YAML evidence_item id + check_value updated
- Self-receipt probe_command updated to reference new path
- Title + summary updated

Orphan remote v0.21.0 tag was deleted via:
  git push origin :refs/tags/v0.21.0
  git tag -d v0.21.0
No GH Release existed for the orphan tag; PyPI omnibase-spi stops at
0.20.6, so no consumer was depending on it.

Old PR #211 closed; new PR #212 cuts fresh v0.21.0 from current main.

Evidence-Ticket: OMN-11348

* chore(OMN-11348): append Tier 3/4 release evidence to wave 2 bundle

Extends OCC bundle to cover all 7 wave 2 release PRs. Adds 4 new
dod_evidence items:
- dod-release-oii-v0.24.0 (omniintelligence PR #657 @ 63ca7019)
- dod-release-omem-v0.16.0 (omnimemory PR #324 @ 5da2e419)
- dod-release-omninode-infra-v0.2.0 (omninode_infra PR #442 @ 25609ed0)
- dod-release-omnidash-v1.0.0 (omnidash PR #102 @ 8508bd80)

Updates self-receipt probe_command to verify all 7 release receipts
exist. Updates contract title + summary to reflect full coverage.

Evidence-Ticket: OMN-11348
jonahgabriel added a commit that referenced this pull request May 21, 2026
…#1251)

* fix(OMN-11348): refresh SHA pins for compat/core/oii/omem release PRs

After OCC #1250 merged, the original release PR head SHAs needed
PR_EVENT_BODY refresh (empty commit push) to clear stale webhook
payload cache that caused "PR title/body does not cite an OMN ticket"
failures even though the body contained OMN-11348.

Refreshed SHAs in contract + receipts:
- compat PR #95: 9554d993 -> c8c41c8c
- core PR #1120: 1834272d -> 3159cb9d
- oii PR #657: 63ca7019 -> dffac2f3
- omem PR #324: 5da2e419 -> cbcdd75d

Tier 1 (spi #212) and Tier 4 (omninode_infra #442, omnidash #102) PRs
already merged before OCC #1250 landed; their SHAs were correct in the
merged OCC contract.

Evidence-Ticket: OMN-11348

* fix(OMN-11348): rebind self-receipt to OCC PR #1251 for SHA refresh

receipt-gate failed on PR #1251 with reason: pr_ticket_mismatch
because the merged dod-occ-pr-self receipt has pr_number: 1250 (the
original OCC PR). Since #1251 is a follow-up that updates the same
contract for the same ticket, rebind the self-receipt to #1251 so
receipt-gate finds the binding PR_NUMBER.

Evidence-Ticket: OMN-11348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant