Skip to content

fix(OMN-9893): set pr_number=948 in OMN-9892 receipts (int, not "TBD") - #442

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-9893-pr-number-int
Apr 27, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-9893-pr-number-int

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 27, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Follow-up to OCC#440. Set pr_number: 948 (int) in both OMN-9892 command receipts. The post-OMN-9788 ModelDodReceipt schema requires pr_number: int; the merged pr_number: TBD (string) fails validation.

Why

omnibase_core#948 receipt-gate run 24988740665 (after OCC#440 merge):

RECEIPT GATE FAILED. Missing or non-PASS receipts:
  - OMN-9892 / dod-001 / command: invalid receipt schema
    pr_number
      Input should be a valid integer, unable to parse string as an integer
      [type=int_parsing, input_value='TBD', input_type=str]
  - OMN-9892 / dod-002 / command: invalid receipt schema (same)

The "TBD" string was inherited from the original file_exists.yaml receipts (OCC#438) — pre-OMN-9788 the int parser was permissive on this field. The hardened schema rejects it.

Fix

Set pr_number: 948 on both drift/dod_receipts/OMN-9892/dod-{001,002}/command.yaml. Matches the canonical OMN-9891 pattern (OCC#436), e.g. drift/dod_receipts/OMN-9761/dod-001/command.yaml uses pr_number: 920 — the int ID of the consumer PR each receipt unblocks.

Validation

  • pre-commit run --all-files → all hooks pass.
  • Local validate-yaml of the ticket-contract via the existing OMN-9892.yaml continues to pass.

Refs

[skip-receipt-gate: receipts-migration fixup — same rationale as OCC#440 (this PR rewrites the receipts the gate reads)]

Summary by CodeRabbit

  • Chores
    • Updated receipt metadata with PR reference information.

OCC#440 merged the file_exists->command migration but left
pr_number: TBD (string), which fails ModelDodReceipt validation
post-OMN-9788:

  Input should be a valid integer, unable to parse string as an integer
  [type=int_parsing, input_value='TBD', input_type=str]

Receipt-gate run on omnibase_core#948 (the consumer that drove this
work) confirmed the failure mode after #440 merged.

Set pr_number to 948 in both receipts to match the canonical pattern
from OMN-9891 / OCC#436 (e.g. drift/dod_receipts/OMN-9761/dod-001/command.yaml
uses pr_number: 920 -- the integer ID of the PR the receipt unblocks).

Refs: OMN-9876 (parent epic), OMN-9788 (receipt-gate hardening),
omnibase_core#948 (blocked consumer).
@coderabbitai

coderabbitai Bot commented Apr 27, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 177111af-5b61-48b3-8627-7c7b0123542e

📥 Commits

Reviewing files that changed from the base of the PR and between c42791c and 41456be.

📒 Files selected for processing (2)
  • drift/dod_receipts/OMN-9892/dod-001/command.yaml
  • drift/dod_receipts/OMN-9892/dod-002/command.yaml

📝 Walkthrough

Walkthrough

Two receipt metadata files in the drift/dod_receipts/OMN-9892/ directory are updated to assign concrete pull request numbers. The pr_number field is changed from the placeholder value TBD to 948 in both dod-001/command.yaml and dod-002/command.yaml.

Changes

Cohort / File(s) Summary
Receipt Metadata Updates
drift/dod_receipts/OMN-9892/dod-001/command.yaml, drift/dod_receipts/OMN-9892/dod-002/command.yaml
Updated pr_number field from placeholder TBD to concrete value 948 in both receipt configuration files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 Two YAML files hop in line,
With PR numbers now divine,
No more TBD's to confuse,
Just 948, a perfect muse! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: updating pr_number from 'TBD' to 948 in OMN-9892 receipts, with clear indication of the type change (int, not string).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9893-pr-number-int

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge April 27, 2026 11:05
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 27, 2026
Merged via the queue into main with commit aa92c53 Apr 27, 2026
27 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9893-pr-number-int branch April 27, 2026 11:17
jonahgabriel added a commit that referenced this pull request May 21, 2026
Extends OCC bundle to cover all 7 wave 2 release PRs. Adds 4 new
dod_evidence items:
- dod-release-oii-v0.24.0 (omniintelligence PR #657 @ 63ca7019)
- dod-release-omem-v0.16.0 (omnimemory PR #324 @ 5da2e419)
- dod-release-omninode-infra-v0.2.0 (omninode_infra PR #442 @ 25609ed0)
- dod-release-omnidash-v1.0.0 (omnidash PR #102 @ 8508bd80)

Updates self-receipt probe_command to verify all 7 release receipts
exist. Updates contract title + summary to reflect full coverage.

Evidence-Ticket: OMN-11348
jonahgabriel added a commit that referenced this pull request May 21, 2026
* chore(OMN-11348): bind 2026-05-21 wave 2 batch release evidence

Wave 2 OCC contract + receipts for the 2026-05-21 full org-wide
release pipeline. Builds on OMN-11346 (wave 1 covered omnibase_infra
v0.36.1, omnimarket v0.3.1, omniclaude v0.24.0).

Tier 1 / Tier 2 receipts bundled in this PR:
- dod-release-spi-v0.21.1 (omnibase_spi PR #211 @ e29bf28)
- dod-release-compat-v0.4.1 (omnibase_compat PR #95 @ 9554d99)
- dod-release-core-v0.42.0 (omnibase_core PR #1120 @ 1834272)
- dod-occ-pr-self (self-binding)

Tier 3 / Tier 4 dod_evidence items (oii, omem, infra, dash) will be
appended in follow-up commits as those release PRs reach observable
head SHAs, mirroring the OMN-11346 incremental pattern.

Evidence-Ticket: OMN-11348

* fix(OMN-11348): set self-binding receipt pr_number to actual OCC PR

dod-occ-pr-self had pr_number: 0 which fails ModelDodReceipt validation
(>=1). Use real OCC PR number 1250 so receipt-gate accepts the receipt.

Evidence-Ticket: OMN-11348

* fix(OMN-11348): rebind spi receipt to v0.21.0 PR #212

Team-lead switched from Option 2 (skip v0.21.0 → release v0.21.1) to
Option 1 (delete orphan v0.21.0 tag → release fresh v0.21.0).

Changes:
- Renamed receipt dir dod-release-spi-v0.21.1 → dod-release-spi-v0.21.0
- Receipt YAML rebound to PR #212 @ 11a5721 (was PR #211 @ e29bf28)
- Contract YAML evidence_item id + check_value updated
- Self-receipt probe_command updated to reference new path
- Title + summary updated

Orphan remote v0.21.0 tag was deleted via:
  git push origin :refs/tags/v0.21.0
  git tag -d v0.21.0
No GH Release existed for the orphan tag; PyPI omnibase-spi stops at
0.20.6, so no consumer was depending on it.

Old PR #211 closed; new PR #212 cuts fresh v0.21.0 from current main.

Evidence-Ticket: OMN-11348

* chore(OMN-11348): append Tier 3/4 release evidence to wave 2 bundle

Extends OCC bundle to cover all 7 wave 2 release PRs. Adds 4 new
dod_evidence items:
- dod-release-oii-v0.24.0 (omniintelligence PR #657 @ 63ca7019)
- dod-release-omem-v0.16.0 (omnimemory PR #324 @ 5da2e419)
- dod-release-omninode-infra-v0.2.0 (omninode_infra PR #442 @ 25609ed0)
- dod-release-omnidash-v1.0.0 (omnidash PR #102 @ 8508bd80)

Updates self-receipt probe_command to verify all 7 release receipts
exist. Updates contract title + summary to reflect full coverage.

Evidence-Ticket: OMN-11348
jonahgabriel added a commit that referenced this pull request May 21, 2026
…#1251)

* fix(OMN-11348): refresh SHA pins for compat/core/oii/omem release PRs

After OCC #1250 merged, the original release PR head SHAs needed
PR_EVENT_BODY refresh (empty commit push) to clear stale webhook
payload cache that caused "PR title/body does not cite an OMN ticket"
failures even though the body contained OMN-11348.

Refreshed SHAs in contract + receipts:
- compat PR #95: 9554d993 -> c8c41c8c
- core PR #1120: 1834272d -> 3159cb9d
- oii PR #657: 63ca7019 -> dffac2f3
- omem PR #324: 5da2e419 -> cbcdd75d

Tier 1 (spi #212) and Tier 4 (omninode_infra #442, omnidash #102) PRs
already merged before OCC #1250 landed; their SHAs were correct in the
merged OCC contract.

Evidence-Ticket: OMN-11348

* fix(OMN-11348): rebind self-receipt to OCC PR #1251 for SHA refresh

receipt-gate failed on PR #1251 with reason: pr_ticket_mismatch
because the merged dod-occ-pr-self receipt has pr_number: 1250 (the
original OCC PR). Since #1251 is a follow-up that updates the same
contract for the same ticket, rebind the self-receipt to #1251 so
receipt-gate finds the binding PR_NUMBER.

Evidence-Ticket: OMN-11348
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant