Repository navigation
fix(OMN-9893): set pr_number=948 in OMN-9892 receipts (int, not "TBD") - #442
Merged
Merged
Conversation
OCC#440 merged the file_exists->command migration but left pr_number: TBD (string), which fails ModelDodReceipt validation post-OMN-9788: Input should be a valid integer, unable to parse string as an integer [type=int_parsing, input_value='TBD', input_type=str] Receipt-gate run on omnibase_core#948 (the consumer that drove this work) confirmed the failure mode after #440 merged. Set pr_number to 948 in both receipts to match the canonical pattern from OMN-9891 / OCC#436 (e.g. drift/dod_receipts/OMN-9761/dod-001/command.yaml uses pr_number: 920 -- the integer ID of the PR the receipt unblocks). Refs: OMN-9876 (parent epic), OMN-9788 (receipt-gate hardening), omnibase_core#948 (blocked consumer).
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo receipt metadata files in the Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
enabled auto-merge
April 27, 2026 11:05
jonahgabriel
added this pull request to the merge queue
Apr 27, 2026
jonahgabriel
added a commit
that referenced
this pull request
May 21, 2026
Extends OCC bundle to cover all 7 wave 2 release PRs. Adds 4 new dod_evidence items: - dod-release-oii-v0.24.0 (omniintelligence PR #657 @ 63ca7019) - dod-release-omem-v0.16.0 (omnimemory PR #324 @ 5da2e419) - dod-release-omninode-infra-v0.2.0 (omninode_infra PR #442 @ 25609ed0) - dod-release-omnidash-v1.0.0 (omnidash PR #102 @ 8508bd80) Updates self-receipt probe_command to verify all 7 release receipts exist. Updates contract title + summary to reflect full coverage. Evidence-Ticket: OMN-11348
jonahgabriel
added a commit
that referenced
this pull request
May 21, 2026
* chore(OMN-11348): bind 2026-05-21 wave 2 batch release evidence Wave 2 OCC contract + receipts for the 2026-05-21 full org-wide release pipeline. Builds on OMN-11346 (wave 1 covered omnibase_infra v0.36.1, omnimarket v0.3.1, omniclaude v0.24.0). Tier 1 / Tier 2 receipts bundled in this PR: - dod-release-spi-v0.21.1 (omnibase_spi PR #211 @ e29bf28) - dod-release-compat-v0.4.1 (omnibase_compat PR #95 @ 9554d99) - dod-release-core-v0.42.0 (omnibase_core PR #1120 @ 1834272) - dod-occ-pr-self (self-binding) Tier 3 / Tier 4 dod_evidence items (oii, omem, infra, dash) will be appended in follow-up commits as those release PRs reach observable head SHAs, mirroring the OMN-11346 incremental pattern. Evidence-Ticket: OMN-11348 * fix(OMN-11348): set self-binding receipt pr_number to actual OCC PR dod-occ-pr-self had pr_number: 0 which fails ModelDodReceipt validation (>=1). Use real OCC PR number 1250 so receipt-gate accepts the receipt. Evidence-Ticket: OMN-11348 * fix(OMN-11348): rebind spi receipt to v0.21.0 PR #212 Team-lead switched from Option 2 (skip v0.21.0 → release v0.21.1) to Option 1 (delete orphan v0.21.0 tag → release fresh v0.21.0). Changes: - Renamed receipt dir dod-release-spi-v0.21.1 → dod-release-spi-v0.21.0 - Receipt YAML rebound to PR #212 @ 11a5721 (was PR #211 @ e29bf28) - Contract YAML evidence_item id + check_value updated - Self-receipt probe_command updated to reference new path - Title + summary updated Orphan remote v0.21.0 tag was deleted via: git push origin :refs/tags/v0.21.0 git tag -d v0.21.0 No GH Release existed for the orphan tag; PyPI omnibase-spi stops at 0.20.6, so no consumer was depending on it. Old PR #211 closed; new PR #212 cuts fresh v0.21.0 from current main. Evidence-Ticket: OMN-11348 * chore(OMN-11348): append Tier 3/4 release evidence to wave 2 bundle Extends OCC bundle to cover all 7 wave 2 release PRs. Adds 4 new dod_evidence items: - dod-release-oii-v0.24.0 (omniintelligence PR #657 @ 63ca7019) - dod-release-omem-v0.16.0 (omnimemory PR #324 @ 5da2e419) - dod-release-omninode-infra-v0.2.0 (omninode_infra PR #442 @ 25609ed0) - dod-release-omnidash-v1.0.0 (omnidash PR #102 @ 8508bd80) Updates self-receipt probe_command to verify all 7 release receipts exist. Updates contract title + summary to reflect full coverage. Evidence-Ticket: OMN-11348
jonahgabriel
added a commit
that referenced
this pull request
May 21, 2026
…#1251) * fix(OMN-11348): refresh SHA pins for compat/core/oii/omem release PRs After OCC #1250 merged, the original release PR head SHAs needed PR_EVENT_BODY refresh (empty commit push) to clear stale webhook payload cache that caused "PR title/body does not cite an OMN ticket" failures even though the body contained OMN-11348. Refreshed SHAs in contract + receipts: - compat PR #95: 9554d993 -> c8c41c8c - core PR #1120: 1834272d -> 3159cb9d - oii PR #657: 63ca7019 -> dffac2f3 - omem PR #324: 5da2e419 -> cbcdd75d Tier 1 (spi #212) and Tier 4 (omninode_infra #442, omnidash #102) PRs already merged before OCC #1250 landed; their SHAs were correct in the merged OCC contract. Evidence-Ticket: OMN-11348 * fix(OMN-11348): rebind self-receipt to OCC PR #1251 for SHA refresh receipt-gate failed on PR #1251 with reason: pr_ticket_mismatch because the merged dod-occ-pr-self receipt has pr_number: 1250 (the original OCC PR). Since #1251 is a follow-up that updates the same contract for the same ticket, rebind the self-receipt to #1251 so receipt-gate finds the binding PR_NUMBER. Evidence-Ticket: OMN-11348
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to OCC#440. Set
pr_number: 948(int) in both OMN-9892 command receipts. The post-OMN-9788ModelDodReceiptschema requirespr_number: int; the mergedpr_number: TBD(string) fails validation.Why
omnibase_core#948 receipt-gate run 24988740665 (after OCC#440 merge):
The "TBD" string was inherited from the original
file_exists.yamlreceipts (OCC#438) — pre-OMN-9788 the int parser was permissive on this field. The hardened schema rejects it.Fix
Set
pr_number: 948on bothdrift/dod_receipts/OMN-9892/dod-{001,002}/command.yaml. Matches the canonical OMN-9891 pattern (OCC#436), e.g.drift/dod_receipts/OMN-9761/dod-001/command.yamlusespr_number: 920— the int ID of the consumer PR each receipt unblocks.Validation
pre-commit run --all-files→ all hooks pass.validate-yamlof the ticket-contract via the existingOMN-9892.yamlcontinues to pass.Refs
[skip-receipt-gate: receipts-migration fixup — same rationale as OCC#440 (this PR rewrites the receipts the gate reads)]
Summary by CodeRabbit