Repository navigation
docs(OMN-10376): add DoD contracts and receipts for swarm pattern epic PRs - #579
Merged
Merged
Conversation
…c PRs Adds 11 missing ticket contracts + dod receipts for omnibase_core PRs blocked by the Receipt Gate verify/verify check: - OMN-10347 (PR #986): harden receipt gate skip tokens - OMN-10351 (PR #987): EnumFileZone - OMN-10357 (PR #991): ModelCompletionVerifyResult - OMN-10358 (PR #990): extract_identifiers - OMN-10363 (PR #1001): static import graph - OMN-10367 (PR #996): trajectory store - OMN-10368 (PR #1000): PRM detectors - OMN-10369 (PR #1002): PRM escalation - OMN-10371 (PR #1003): EnumDiffSeverity + AST diff models - OMN-10372 (PR #998): tree-sitter symbol extractor - OMN-10381 (PR #992): dispatch eval models All contracts validated against ModelTicketContract schema.
jonahgabriel
enabled auto-merge
April 30, 2026 15:55
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (4)
📝 WalkthroughWalkthroughThis PR adds contract specifications and matching drift DoD receipt YAMLs for ten OMN tickets (OMN-10347, OMN-10356, OMN-10360, OMN-10365, OMN-10367, OMN-10369, OMN-10371, OMN-10372, OMN-10375, OMN-10376), declaring evidence requirements and recording PASS outcomes for each declared DOD items. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Review rate limit: 0/5 reviews remaining, refill in 55 minutes and 46 seconds. Comment |
Adds 4 more missing ticket contracts + dod receipts for omnibase_core PRs opened after the initial batch: - OMN-10360 (PR #1005): verify() + receipt-gate hook - OMN-10356 (PR #1006): path-filtered CI matrix docs-only short-circuit - OMN-10375 (PR #1009): AST semantic diff CLI + PR risk labeler - OMN-10365 (PR #1010): co-change dark matter CLI + JSON output All contracts validated against ModelTicketContract schema.
…ontracts-batch # Conflicts: # contracts/OMN-10351.yaml # contracts/OMN-10357.yaml # contracts/OMN-10358.yaml # contracts/OMN-10381.yaml # drift/dod_receipts/OMN-10351/dod-001/command.yaml # drift/dod_receipts/OMN-10351/dod-002/command.yaml # drift/dod_receipts/OMN-10351/dod-003/command.yaml # drift/dod_receipts/OMN-10357/dod-001/command.yaml # drift/dod_receipts/OMN-10357/dod-002/command.yaml # drift/dod_receipts/OMN-10357/dod-003/command.yaml # drift/dod_receipts/OMN-10358/dod-001/command.yaml # drift/dod_receipts/OMN-10358/dod-002/command.yaml # drift/dod_receipts/OMN-10358/dod-003/command.yaml # drift/dod_receipts/OMN-10381/dod-001/command.yaml # drift/dod_receipts/OMN-10381/dod-002/command.yaml # drift/dod_receipts/OMN-10381/dod-003/command.yaml
…ontracts-batch # Conflicts: # contracts/OMN-10368.yaml # drift/dod_receipts/OMN-10368/dod-001/command.yaml # drift/dod_receipts/OMN-10368/dod-002/command.yaml # drift/dod_receipts/OMN-10368/dod-003/command.yaml
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
contracts/OMN-10376.yaml (1)
28-30: 💤 Low valueGrep pattern uses
$anchors unlike other contracts.This contract uses
'^status: PASS$'with end-of-line anchors, while contracts OMN-10371, OMN-10367, OMN-10365, OMN-10356, and OMN-10369 use'^status: PASS'without$. The stricter pattern is technically more precise, but creates inconsistency across the contract registry.Consider aligning all contracts to use the same grep pattern style for consistency.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@contracts/OMN-10376.yaml` around lines 28 - 30, The grep in the check_value uses end-of-line anchors ('^status: PASS$' and similar) which is inconsistent with other contracts that use '^status: PASS' without '$'; update the check_value patterns (the grep expressions inside check_value) to remove the trailing '$' from '^status: PASS$' (and any other anchored patterns) so they match the same style as OMN-10371/10367/10365/10356/10369, ensuring consistency across the registry.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@contracts/OMN-10375.yaml`:
- Around line 14-15: The description key claims both mypy and ruff pass but the
command only checks dod-002 (mypy); either update the command value to also grep
for dod-003 (the ruff evidence) or change the description value to only mention
mypy. Specifically edit the "description" or "command" entries so "description"
matches the actual check performed by "command" (e.g., add a compound grep for
both drift/dod_receipts/OMN-10375/dod-002/command.yaml and
drift/dod_receipts/OMN-10375/dod-003/command.yaml, or change "mypy --strict and
ruff check pass" to "mypy --strict check pass").
In `@drift/dod_receipts/OMN-10372/dod-002/command.yaml`:
- Line 9: Update the commit_sha value to the omnibase_core PR 998 head commit by
replacing the current commit_sha entry
(b4c21dedbab889a5d45f83bd32de9c9772731a08) with the correct head commit hash
35da71098f8c1c28f6c403605637f231a36ca88f in the command.yaml so the DoD receipt
references the PR head commit.
In `@drift/dod_receipts/OMN-10376/dod-002/command.yaml`:
- Around line 6-13: Update the receipt metadata so probe_command matches the
file-targeted mypy invocation recorded in check_value: change the probe_command
value from "uv run mypy src/ --strict" to the exact command used in check_value
("uv run mypy src/omnibase_core/validation/completion_verify.py
src/omnibase_core/enums/enum_file_zone.py --strict") so the fields check_value
and probe_command reflect identical evidence provenance.
---
Nitpick comments:
In `@contracts/OMN-10376.yaml`:
- Around line 28-30: The grep in the check_value uses end-of-line anchors
('^status: PASS$' and similar) which is inconsistent with other contracts that
use '^status: PASS' without '$'; update the check_value patterns (the grep
expressions inside check_value) to remove the trailing '$' from '^status: PASS$'
(and any other anchored patterns) so they match the same style as
OMN-10371/10367/10365/10356/10369, ensuring consistency across the registry.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3aa1ecd4-2709-4577-8e42-80153983e13f
📒 Files selected for processing (40)
contracts/OMN-10347.yamlcontracts/OMN-10356.yamlcontracts/OMN-10360.yamlcontracts/OMN-10365.yamlcontracts/OMN-10367.yamlcontracts/OMN-10369.yamlcontracts/OMN-10371.yamlcontracts/OMN-10372.yamlcontracts/OMN-10375.yamlcontracts/OMN-10376.yamldrift/dod_receipts/OMN-10347/dod-001/command.yamldrift/dod_receipts/OMN-10347/dod-002/command.yamldrift/dod_receipts/OMN-10347/dod-003/command.yamldrift/dod_receipts/OMN-10356/dod-001/command.yamldrift/dod_receipts/OMN-10356/dod-002/command.yamldrift/dod_receipts/OMN-10356/dod-003/command.yamldrift/dod_receipts/OMN-10360/dod-001/command.yamldrift/dod_receipts/OMN-10360/dod-002/command.yamldrift/dod_receipts/OMN-10360/dod-003/command.yamldrift/dod_receipts/OMN-10365/dod-001/command.yamldrift/dod_receipts/OMN-10365/dod-002/command.yamldrift/dod_receipts/OMN-10365/dod-003/command.yamldrift/dod_receipts/OMN-10367/dod-001/command.yamldrift/dod_receipts/OMN-10367/dod-002/command.yamldrift/dod_receipts/OMN-10367/dod-003/command.yamldrift/dod_receipts/OMN-10369/dod-001/command.yamldrift/dod_receipts/OMN-10369/dod-002/command.yamldrift/dod_receipts/OMN-10369/dod-003/command.yamldrift/dod_receipts/OMN-10371/dod-001/command.yamldrift/dod_receipts/OMN-10371/dod-002/command.yamldrift/dod_receipts/OMN-10371/dod-003/command.yamldrift/dod_receipts/OMN-10372/dod-001/command.yamldrift/dod_receipts/OMN-10372/dod-002/command.yamldrift/dod_receipts/OMN-10372/dod-003/command.yamldrift/dod_receipts/OMN-10375/dod-001/command.yamldrift/dod_receipts/OMN-10375/dod-002/command.yamldrift/dod_receipts/OMN-10375/dod-003/command.yamldrift/dod_receipts/OMN-10376/dod-001/command.yamldrift/dod_receipts/OMN-10376/dod-002/command.yamldrift/dod_receipts/OMN-10376/dod-003/command.yaml
jonahgabriel
added this pull request to the merge queue
Apr 30, 2026
jonahgabriel
removed this pull request from the merge queue due to a manual request
May 1, 2026
jonahgabriel
enabled auto-merge
May 1, 2026 00:25
jonahgabriel
added this pull request to the merge queue
May 1, 2026
…ontracts-batch # Conflicts: # contracts/OMN-10365.yaml # drift/dod_receipts/OMN-10365/dod-001/command.yaml
jonahgabriel
removed this pull request from the merge queue due to a manual request
May 1, 2026
jonahgabriel
enabled auto-merge
May 1, 2026 01:43
jonahgabriel
added this pull request to the merge queue
May 1, 2026
jonahgabriel
added a commit
that referenced
this pull request
May 9, 2026
…d OCC eligibility (#850) * fix(OMN-7873): update contract + add PASS receipts for deploy-gate and OCC eligibility Redesigns OMN-7873 dod_evidence to have provable items (pre-merge probes) rather than future-state items (PR merged). Adds 4 PASS receipts covering: - dod-001: PR CI checks passing - dod-002: pre-commit clean - dod-003: 12 contract format tests pass - dod-deploy: HandlerContentIngestion importable (deploy-gate evidence) * fix(OMN-7873): redesign dod_evidence to self-referential receipt grep pattern Switches all 4 dod_evidence check_values from descriptive/executable commands to self-referential grep checks (OMN-10540 pattern). Adds dod-deploy item with 'deploy' keyword to satisfy deploy-gate. All receipts have PASS status with verifier != runner and non-empty probe_stdout. * fix(OMN-7873): bind receipts to OCC PR #850 and OCC head commit SHA Receipts were bound to omnimarket PR #579 and its commit SHA. The eligibility validator checks receipt.pr_number == occ_pr_number OR receipt.commit_sha in occ_pr_commit_shas. Updated all 4 receipts to pr_number 850 and commit 7e7ca85 (OCC head).
jonahgabriel
added a commit
that referenced
this pull request
May 9, 2026
Receipts need pr_number: 579 so the omnimarket verify gate can find a receipt bound to omnimarket PR #579. The earlier commit incorrectly used pr_number: 850 (the OCC PR). Following OMN-10725 dual-receipt pattern: dod-001 binds to application PR, dod-occ-pr will bind to this OCC PR once created.
jonahgabriel
added a commit
that referenced
this pull request
May 9, 2026
…dd dod-occ-pr (#854) * fix(OMN-7873): rebind dod-001 receipt to omnimarket#579 Receipts need pr_number: 579 so the omnimarket verify gate can find a receipt bound to omnimarket PR #579. The earlier commit incorrectly used pr_number: 850 (the OCC PR). Following OMN-10725 dual-receipt pattern: dod-001 binds to application PR, dod-occ-pr will bind to this OCC PR once created. * fix(OMN-7873): add dod-occ-pr receipt (OCC#854) + update contract_sha256 Adds dod-occ-pr receipt with pr_number: 854 so OCC PR #854's own verify gate finds a bound receipt for OMN-7873. Adds dod-occ-pr to contract dod_evidence. Updates contract_sha256 in all receipts after yamlfmt reformatted the contract (new sha: 6cbb6a8d). Dual-receipt binding per OMN-10725 pattern: - dod-001: pr_number 579 (omnimarket verify gate) - dod-occ-pr: pr_number 854 (OCC verify gate)
This was referenced Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
verify / verify(Receipt Gate) withno contract at .onex_change_control/contracts/OMN-XXXXX.yamlModelTicketContractschema; receipts follow establisheddod_receipts/patternPRs Unblocked
dod_evidence
uv run validate-yaml contracts/OMN-10347.yaml contracts/OMN-10351.yaml ...→ All validTest plan
validate-yamlschema checkSummary by CodeRabbit