Repository navigation
fix(OMN-10970): wire skip-token rejection CI gate - #1006
jonahgabriel merged 7 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds a repository workflow that invokes a hosted reusable workflow to reject skip-gate bypass tokens, and records three new OMN-10970 drift receipt files plus a contract update that lists those evidence items and their command checks. ChangesReject skip-gate gate + OMN-10970 receipts
Sequence DiagramsequenceDiagram
autonumber
participant PR as Pull Request
participant RepoWF as Repository Workflow (.github)
participant HostedWF as Hosted Reusable Workflow (omniclaude)
participant Contracts as Contracts/Receipts
PR->>RepoWF: open/edit/synchronize/reopen (main) / merge_group
RepoWF->>HostedWF: call reusable workflow (`uses`)
HostedWF->>HostedWF: evaluate skip-gate token checks
HostedWF-->>RepoWF: status check result (scan / reject-skip-gate-token)
RepoWF->>Contracts: record/verify receipts & contract evidence (manual inputs)
Contracts-->>RepoWF: PASS verification (receipt files show status: PASS)
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/call-reject-skip.yml:
- Line 28: Remove the unnecessary secrets inheritance from the reusable-workflow
call: delete the "secrets: inherit" entry in the call that invokes
reject-deploy-gate-skip.yml (the reusable workflow only uses ${{ github.token }}
and declares no secret inputs), so omit the secrets block entirely to enforce
least privilege.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 87577e96-eb81-496b-8503-3ec429f0567e
📒 Files selected for processing (1)
.github/workflows/call-reject-skip.yml
…reject-deploy-gate-skip-on-all-remaining-repos-8
…c PRs (OmniNode-ai#579) * docs(OMN-10376): add DoD contracts and receipts for swarm pattern epic PRs Adds 11 missing ticket contracts + dod receipts for omnibase_core PRs blocked by the Receipt Gate verify/verify check: - OMN-10347 (PR OmniNode-ai#986): harden receipt gate skip tokens - OMN-10351 (PR OmniNode-ai#987): EnumFileZone - OMN-10357 (PR OmniNode-ai#991): ModelCompletionVerifyResult - OMN-10358 (PR OmniNode-ai#990): extract_identifiers - OMN-10363 (PR OmniNode-ai#1001): static import graph - OMN-10367 (PR OmniNode-ai#996): trajectory store - OMN-10368 (PR OmniNode-ai#1000): PRM detectors - OMN-10369 (PR OmniNode-ai#1002): PRM escalation - OMN-10371 (PR OmniNode-ai#1003): EnumDiffSeverity + AST diff models - OMN-10372 (PR OmniNode-ai#998): tree-sitter symbol extractor - OMN-10381 (PR OmniNode-ai#992): dispatch eval models All contracts validated against ModelTicketContract schema. * docs(OMN-10376): add contracts for newly opened swarm pattern PRs Adds 4 more missing ticket contracts + dod receipts for omnibase_core PRs opened after the initial batch: - OMN-10360 (PR OmniNode-ai#1005): verify() + receipt-gate hook - OMN-10356 (PR OmniNode-ai#1006): path-filtered CI matrix docs-only short-circuit - OMN-10375 (PR OmniNode-ai#1009): AST semantic diff CLI + PR risk labeler - OMN-10365 (PR OmniNode-ai#1010): co-change dark matter CLI + JSON output All contracts validated against ModelTicketContract schema. * docs(OMN-10376): add contract and receipts for proof-of-life integration tests * docs(OMN-10376): resolve OCC receipt review comments * ci: kick CI Summary runner (GHA queue stall)
Evidence-Ticket: OMN-10970
Evidence-Source: a84f3c6
Wire the reject-deploy-gate-skip reusable workflow as a caller in this repo. Ensures unapproved skip tokens are rejected org-wide.
dod_evidence:
description: CI workflow addition only — no runtime code modified
Summary by CodeRabbit