Repository navigation
evidence(OMN-14988): OCC companion — check_no_infra_inmemory_import.sh slash-normalization fix - #5132
jonahgabriel wants to merge 1 commit into
Conversation
…port.sh slash-normalization fix
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 7 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Closing as the duplicate. OCC autobind opened #5133 for the product PR OmniNode-ai/omnibase_infra#2498 three minutes after this one; per standing session precedent autobind wins the companion slot and the hand-authored companion closes. Note for whoever lands #5133: it is the thin autobind shape — its three Those content probes should be re-landed onto |
OMN-14988 — OCC companion (net-new file only)
Companion for the product fix in
OmniNode-ai/omnibase_infra(branchjonah/omn-14988-slash-normalization, commitc9ca7eb1).Diff scope: one net-new file,
contracts/OMN-14988.yaml. No existing file touched.What the product PR fixes
scripts/validation/check_no_infra_inmemory_import.sh— theno-infra-inmemory-importpre-commit hook and CI Lint gate (OMN-7077 / OMN-13419) — reported 8 violations on a
clean
devtree, all 8 of them entries in the script's ownALLOWLIST. Signal-to-noisewas 0/8.
Two platform facts compound:
src/assrc//in every hit, so paths arriveas
src//omnibase_infra/.... GNU grep on Linux CI does not.${file//\/\//\/}is bash-version-dependent. Under bash >= 4.3 itcollapses correctly; under bash 3.2 — which is
/usr/bin/env bashon stock macOS, andtherefore the interpreter this hook actually runs under locally — the backslash in the
replacement word is retained literally, producing
src\/omnibase_infra/..., whichmatches no
ALLOWLISTentry.Because the failure needs both, Linux CI never saw it and macOS always did.
Evidence recorded in this contract
dod-omn-14988-gate-clean-tree-exit-zero.200and locallydod-omn-14988-normalization-regression-red-greendod-omn-14988-gate-not-neuteredsrc//prefix still exits 1dod-omn-14988-governed-selection-greentests/unit/scripts/; 840 passed / 0 failed on.200dod-omn-14988-hook-satisfiable-without-bypass--no-verify, no skip tokendod-omn-14988-shellcheck-cleanshellcheck -xclean on the modified scriptOrdering
Companion-first. This PR lands before the product PR so the Receipt Gate can resolve
contracts/OMN-14988.yaml.If OCC autobind opens its own companion for the product PR, autobind wins and this PR is
closed as the duplicate (session precedent).
Merging is Codex's; no
--autoset here.