Skip to content

chore(OMN-14758): allowlist kafka_transport.py freestanding Kafka client - #4395

Closed
jonahgabriel wants to merge 2 commits into
devfrom
jonah/omn-14758-allowlist-kafka-transport
Closed

jonahgabriel wants to merge 2 commits into
devfrom
jonah/omn-14758-allowlist-kafka-transport

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 18, 2026 •

Copy link
Copy Markdown
Contributor

OMN-14758 — allowlist the S6 KafkaTransport freestanding Kafka client

omnibase_infra PR #2341 (S6 composition wiring) imports KafkaTransport into the live service_kernel boot path, flipping src/omnibase_infra/event_bus/kafka_transport.py from dead to live. The imperative-contract guard then blocks on its raw AIOKafkaProducer/AIOKafkaConsumer clients (L160/L182).

KafkaTransport is the pull-based transport implementation RuntimeDispatch consumes (poll/commit/nack) and legitimately owns the raw aiokafka clients — architecturally identical to the already-allowlisted sibling event_bus_kafka.py. This adds the matching freestanding_kafka_client allowlist entry so the guard stays green once #2341 wires the transport live.

Verified locally: check-imperative-contracts --repo-root <infra> --allowlists-dir allowlists --scan-freestanding -> live 0, exit 0.

Self-binding OCC evidence: adds dod_evidence occ-self-bind-pr-4395 to contracts/OMN-14758.yaml plus its PASS receipt.

Closes-partial OMN-14758.

Evidence-Source: OCC#4395
Evidence-Ticket: OMN-14758

The S6 composition wiring (omnibase_infra PR #2341) imports KafkaTransport into
the live service_kernel boot path, flipping event_bus/kafka_transport.py from
dead -> live. It is the pull-based transport implementation RuntimeDispatch
consumes (poll/commit/nack) and legitimately owns the raw aiokafka clients,
exactly like the already-allowlisted event_bus_kafka.py sibling. Allowlist it
for freestanding_kafka_client so the imperative-contract guard stays green.

Evidence-Ticket: OMN-14758
@coderabbitai

coderabbitai Bot commented Jul 18, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 22 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 2dee9c45-0b41-4ff7-85c5-b0ac8a4f3c4c

📥 Commits

Reviewing files that changed from the base of the PR and between 17c55d9 and 3d50247.

📒 Files selected for processing (3)
  • allowlists/omnibase_infra.yaml
  • contracts/OMN-14758.yaml
  • drift/dod_receipts/OMN-14758/occ-self-bind-pr-4395/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14758-allowlist-kafka-transport

Comment @coderabbitai help to get the list of available commands.

Adds dod_evidence occ-self-bind-pr-4395 to contracts/OMN-14758.yaml and its PASS
receipt so the OCC receipt-gate binds this allowlist PR to OMN-14758.

Evidence-Source: OCC#4395
Evidence-Ticket: OMN-14758
@jonahgabriel
jonahgabriel enabled auto-merge (squash) July 18, 2026 11:46
@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Superseded by merged OMN-14758 allowlist/evidence repairs: dev OCC#4393 and main hotfix #4394. Closing this conflicting duplicate to keep the merge queue clean.

auto-merge was automatically disabled July 18, 2026 12:11

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant