Repository navigation
evidence(OMN-14616): bind omnimarket 1769 head b56971 - #4193
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe PR refreshes OMN-14616 evidence for omnimarket PR ChangesOMN-14616 evidence refresh
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@contracts/OMN-14616.yaml`:
- Around line 264-271: Replace the blacklist-based deploy-scope check in the PR
validation command with an exact allowlist comparison of the complete gh pr diff
--name-only output. Require the changed files to be precisely the four expected
paths—contract.yaml, both broker handler files, and the adequacy receipt—while
preserving the existing head commit validation.
- Around line 208-218: Extend the refreshed head verification command after the
existing test_real_engine_dispatch_binds_missing_handle_pre_fix check to also
require the two post-fix regression test symbols previously covered by the
receipt. Preserve the existing file and implementation checks, and use the exact
test names from the earlier evidence so renamed or removed post-fix tests cause
the receipt to fail.
- Around line 228-234: Replace the hard-coded PRODUCT_WORKTREE path in the
check_value command with the verifier-provided temporary checkout or current
working directory, and update the related git -C and cd commands to use that
portable location. Preserve the existing PR head validation and
validate_state_coverage.py invocation.
In
`@drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-product-head-b56971/command.yaml`:
- Around line 1-6: Update the check_value field in all four receipt files to
reference the receipt file itself instead of the contract:
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-product-head-b56971/command.yaml,
drift/dod_receipts/OMN-14616/dod-pr-1769-state-coverage-b56971/command.yaml,
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-local-verification-b56971/command.yaml,
and
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-deploy-scope-b56971/command.yaml.
Preserve the existing schema_version, ticket_id, and evidence_item_id values.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 178ed29f-d59b-419e-a14b-456d1147a2f5
📒 Files selected for processing (5)
contracts/OMN-14616.yamldrift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-deploy-scope-b56971/command.yamldrift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-local-verification-b56971/command.yamldrift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-product-head-b56971/command.yamldrift/dod_receipts/OMN-14616/dod-pr-1769-state-coverage-b56971/command.yaml
Comment on lines
+228
to
+234
| check_value: >- | ||
| PRODUCT_PR_NUMBER=1769; PRODUCT_REPO=OmniNode-ai/omnimarket; PRODUCT_HEAD=b5697123b95cd776367bc61343b41e5f0c8fc6ee; | ||
| PRODUCT_WORKTREE=/Users/jonah/Code/omni_home/omni_worktrees/OMN-14616/omnimarket; gh pr view | ||
| "$PRODUCT_PR_NUMBER" --repo "$PRODUCT_REPO" --json headRefOid --jq '.headRefOid == "'$PRODUCT_HEAD'"' | ||
| | grep -qx true && git -C "$PRODUCT_WORKTREE" rev-parse HEAD | grep -Fx "$PRODUCT_HEAD" && cd | ||
| "$PRODUCT_WORKTREE" && uv run python scripts/validate_state_coverage.py --check-changed origin/dev | ||
| --strict |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Show the relevant section with line numbers
sed -n '210,245p' contracts/OMN-14616.yaml | cat -n
# Look for similar validation commands in nearby contract files
rg -n "validate_state_coverage\.py|origin/dev|PRODUCT_WORKTREE|gh pr view" contracts drift -g '*.yaml' -g '*.yml' || trueRepository: OmniNode-ai/onex_change_control
Length of output: 50388
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the file size and schema-related context if present
wc -l contracts/OMN-14616.yaml
rg -n "check_value:|validate_state_coverage|PRODUCT_HEAD|PRODUCT_REPO|PRODUCT_WORKTREE|origin/dev" contracts/OMN-14616.yaml
# If there are schema docs or model names referenced in repo, find them
rg -n "ModelTicketContract|ModelDayClose|contracts/.*yaml|validate_state_coverage" -g '*.py' -g '*.md' -g '*.yaml' .Repository: OmniNode-ai/onex_change_control
Length of output: 50388
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "=== relevant lines ==="
sed -n '220,236p' contracts/OMN-14616.yaml
echo "=== similar commands elsewhere ==="
rg -n "PRODUCT_WORKTREE=.*origin/dev|validate_state_coverage\.py --check-changed origin/dev" contracts drift -g '*.yaml' -g '*.yml' || trueRepository: OmniNode-ai/onex_change_control
Length of output: 8667
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the exact range around the cited lines with numbering
sed -n '226,252p' contracts/OMN-14616.yaml | cat -n
# Show every occurrence of the worktree/baseline command in this file
rg -n "PRODUCT_WORKTREE|validate_state_coverage\.py|origin/dev|gh pr view|PRODUCT_HEAD" contracts/OMN-14616.yamlRepository: OmniNode-ai/onex_change_control
Length of output: 7477
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Find how evidence_artifact / verified command blocks are described in the repo
rg -n "evidence_artifact|Current-head state-coverage proof|source: \"manual\"|status: \"verified\"|check_value: >-" contracts drift docs -g '*.yaml' -g '*.md' | head -n 200
# Inspect nearby schema/documentation mentions for contract/evidence semantics
rg -n "contract.*schema|evidence.*artifact|verified evidence|manual reproduction|probe_command|check_value" docs contracts drift -g '*.md' -g '*.yaml' | head -n 200Repository: OmniNode-ai/onex_change_control
Length of output: 31182
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Locate the contract schema/model definitions
fd -a ".*(schema|model).*\.py$|.*contract.*\.py$" . | head -n 80
# Search for the fields used in these YAMLs in Python schema files
rg -n "evidence_artifact|probe_command|check_value|status: verified|source: manual" -g '*.py' .Repository: OmniNode-ai/onex_change_control
Length of output: 27633
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the exact top-level structure around the evidence block
sed -n '232,252p' contracts/OMN-14616.yaml | cat -n
# Find references to temporary/verifier checkout wording in similar receipts
rg -n "temporary checkout|verifier-provided|local reproduction|records the local reproduction|origin/dev" drift/dod_receipts contracts -g '*.yaml' | head -n 200Repository: OmniNode-ai/onex_change_control
Length of output: 33907
🏁 Script executed:
#!/bin/bash
set -euo pipefail
# Inspect the contract check runner around evidence handling
sed -n '1,220p' src/onex_change_control/scripts/contract_compliance_check.py | cat -n
echo '---'
sed -n '520,700p' src/onex_change_control/scripts/contract_compliance_check.py | cat -n
# Inspect the DoD check model fields and docstrings
sed -n '1,220p' src/onex_change_control/models/model_dod_check.py | cat -n
# Read the relevant docs section on executable checks
sed -n '170,210p' docs/TEMPLATE_GUIDE.md | cat -nRepository: OmniNode-ai/onex_change_control
Length of output: 27121
Make this check use a portable checkout path. The hard-coded /Users/jonah/.../omnimarket path ties the contract to one workstation; switch to a temp/verifier-provided worktree (or cwd) so the check can run in any environment.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@contracts/OMN-14616.yaml` around lines 228 - 234, Replace the hard-coded
PRODUCT_WORKTREE path in the check_value command with the verifier-provided
temporary checkout or current working directory, and update the related git -C
and cd commands to use that portable location. Preserve the existing PR head
validation and validate_state_coverage.py invocation.
Comment on lines
+264
to
+271
| PRODUCT_PR_NUMBER=1769; PRODUCT_REPO=OmniNode-ai/omnimarket; PRODUCT_HEAD=b5697123b95cd776367bc61343b41e5f0c8fc6ee; | ||
| gh pr view "$PRODUCT_PR_NUMBER" --repo "$PRODUCT_REPO" --json headRefOid,files --jq '.headRefOid | ||
| == "'$PRODUCT_HEAD'"' | grep -qx true && gh pr diff "$PRODUCT_PR_NUMBER" --repo "$PRODUCT_REPO" | ||
| --name-only | grep -Fxq src/omnimarket/nodes/node_pattern_b_broker/contract.yaml && gh pr diff | ||
| "$PRODUCT_PR_NUMBER" --repo "$PRODUCT_REPO" --name-only | grep -Fxq src/omnimarket/nodes/node_pattern_b_broker/handlers/adapter_broker_publish.py | ||
| && gh pr diff "$PRODUCT_PR_NUMBER" --repo "$PRODUCT_REPO" --name-only | grep -Fxq src/omnimarket/nodes/node_pattern_b_broker/handlers/adapter_broker_terminal_consumer.py | ||
| && gh pr diff "$PRODUCT_PR_NUMBER" --repo "$PRODUCT_REPO" --name-only | grep -Fxq scripts/ci/adequacy_receipts/omnimarket.nodes.node_pattern_b_broker.json | ||
| && ! gh pr diff "$PRODUCT_PR_NUMBER" --repo "$PRODUCT_REPO" --name-only | grep -qE '(^|/)(Dockerfile|docker-compose[^/]*|compose[^/]*|deploy|migrations|systemd)(/|$)' |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Use an allowlist for deploy-scope proof.
The blacklist misses deployment surfaces such as k8s/, helm/, terraform/, deploy.sh, and Dockerfile.prod. A deploy artifact could be added while this check still passes. Compare the complete --name-only output against the exact expected file set instead.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@contracts/OMN-14616.yaml` around lines 264 - 271, Replace the blacklist-based
deploy-scope check in the PR validation command with an exact allowlist
comparison of the complete gh pr diff --name-only output. Require the changed
files to be precisely the four expected paths—contract.yaml, both broker handler
files, and the adequacy receipt—while preserving the existing head commit
validation.
Comment on lines
+1
to
+6
| --- | ||
| schema_version: "1.0.0" | ||
| ticket_id: "OMN-14616" | ||
| evidence_item_id: "dod-omnimarket-pr-1769-product-head-b56971" | ||
| check_type: "command" | ||
| check_value: "See contracts/OMN-14616.yaml dod-omnimarket-pr-1769-product-head-b56971." |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Make every refreshed receipt self-referential.
All four receipts currently use Line 6 to point at the contract entry. The receipt gate expects check_value to identify the receipt file itself; the contract remains the source for the verified artifact description.
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-product-head-b56971/command.yaml#L1-L6: setcheck_valueto the product-head receipt path.drift/dod_receipts/OMN-14616/dod-pr-1769-state-coverage-b56971/command.yaml#L1-L6: setcheck_valueto the state-coverage receipt path.drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-local-verification-b56971/command.yaml#L1-L6: setcheck_valueto the local-verification receipt path.drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-deploy-scope-b56971/command.yaml#L1-L6: setcheck_valueto the deploy-scope receipt path.
Based on learnings, ModelDodReceipt.check_value is intentionally self-referential in this repository.
📍 Affects 4 files
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-product-head-b56971/command.yaml#L1-L6(this comment)drift/dod_receipts/OMN-14616/dod-pr-1769-state-coverage-b56971/command.yaml#L1-L6drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-local-verification-b56971/command.yaml#L1-L6drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-deploy-scope-b56971/command.yaml#L1-L6
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-product-head-b56971/command.yaml`
around lines 1 - 6, Update the check_value field in all four receipt files to
reference the receipt file itself instead of the contract:
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-product-head-b56971/command.yaml,
drift/dod_receipts/OMN-14616/dod-pr-1769-state-coverage-b56971/command.yaml,
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-local-verification-b56971/command.yaml,
and
drift/dod_receipts/OMN-14616/dod-omnimarket-pr-1769-deploy-scope-b56971/command.yaml.
Preserve the existing schema_version, ticket_id, and evidence_item_id values.
Source: Learnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OMN-14616 refreshed OCC evidence for OmniNode-ai/omnimarket#1769 after the product head moved to b5697123b95cd776367bc61343b41e5f0c8fc6ee.
Validation:
Evidence-Source: OCC#4193
Evidence-Ticket: OMN-14616
Evidence-Commit: bea41b2
Evidence-Head: b5697123b95cd776367bc61343b41e5f0c8fc6ee