Repository navigation
chore(OMN-9755): OCC contract and dod_evidence receipts for SPI default contract loader - #386
Conversation
Closes OMN-9632.
… loader
Contract: contracts/OMN-9755.yaml
Receipts: drift/dod_receipts/OMN-9755/{dod-001,dod-002,dod-003}/
Required by receipt-gate on omnibase_infra#1418.
Closes OMN-9755.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request adds configuration and evidence records for contract change request OMN-9755, including a contract manifest and three Definition of Done (DoD) receipt records documenting requirement fulfillment checks (file existence, test execution, and pre-commit validation). Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…ertContract (OmniNode-ai#383) * chore(OMN-9749/9751/9755): add OCC contracts and DoD receipts for infra typed-model PRs Unblocks receipt-gate on omnibase_infra PRs: - OmniNode-ai#1415 (OMN-9749): ModelMonitorAlertContract + monitor_logs wire - OmniNode-ai#1417 (OMN-9751): ModelFeatureFlagContract + load_service_contract loader - OmniNode-ai#1418 (OMN-9755): SPI default template loader moved to infra layer * chore(OMN-9749): de-scope OMN-9751 and OMN-9755 from this PR OMN-9755 covered by merged PR OmniNode-ai#386. OMN-9751 covered by open PR OmniNode-ai#385. This PR now contains only OMN-9749 OCC contract + receipts.
…eck_type (OmniNode-ai#389) Receipt-gate derives receipt path from check_type field, ignoring check_value. Contract on main declares check_type: file_exists for dod-002, but PR OmniNode-ai#386 placed the receipt at dod-002/test_passes.yaml. Gate looks for dod-002/file_exists.yaml and fails. Adds the file_exists.yaml receipt at the path the gate actually checks. Same content, schema-correct filename. Mirrors fix for OMN-9746 (OCC PR OmniNode-ai#384, commit 721419b). Unblocks omnibase_infra PR OmniNode-ai#1418 receipt-gate.
… omnimarket omnimemory removed node_intent_event_consumer_effect/contract.yaml in OMN-13701 (PR #386). The consumer for onex.evt.omniintelligence.intent-classified.v1 moved to omnimarket (where node_intent_event_consumer_effect/contract.yaml exists). Update kafka_boundaries.yaml to reflect the live consumer location. Add omnimarket to the validate-boundaries action default repos list so CI can clone it when checking this boundary. This unblocks Cross-Repo Boundary Parity CI check across all omniclaude PRs.
Summary
contracts/OMN-9755.yaml— ModelTicketContract for the infra concrete loaderdrift/dod_receipts/OMN-9755/— 3 PASS receipts (file_exists, test_passes, mypy/hooks)omnibase_infra#1418Ticket
Closes OMN-9755.
dod_evidence
contracts/OMN-9755.yamlcreated and validates against ModelTicketContract (uv run validate-yaml→ OK)status: PASSpre-commit run --all-filespassed (Validate ticket contract YAML hook included)Summary by CodeRabbit