Skip to content

chore(OMN-9755): OCC contract and dod_evidence receipts for SPI default contract loader - #386

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-9755-occ-contract-receipts
Apr 25, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-9755-occ-contract-receipts

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 25, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Adds contracts/OMN-9755.yaml — ModelTicketContract for the infra concrete loader
  • Adds drift/dod_receipts/OMN-9755/ — 3 PASS receipts (file_exists, test_passes, mypy/hooks)
  • Required by receipt-gate on omnibase_infra#1418

Ticket

Closes OMN-9755.

dod_evidence

  • contracts/OMN-9755.yaml created and validates against ModelTicketContract (uv run validate-yaml → OK)
  • All 3 receipt files present with status: PASS
  • pre-commit run --all-files passed (Validate ticket contract YAML hook included)

Summary by CodeRabbit

  • Chores
    • Added internal contract tracking and evidence records for ticket OMN-9755.

… loader

Contract: contracts/OMN-9755.yaml
Receipts: drift/dod_receipts/OMN-9755/{dod-001,dod-002,dod-003}/

Required by receipt-gate on omnibase_infra#1418.

Closes OMN-9755.
@coderabbitai

coderabbitai Bot commented Apr 25, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9bb79b1c-3ef9-42bb-b492-7ec97703e5e2

📥 Commits

Reviewing files that changed from the base of the PR and between 721419b and c2cf3a4.

📒 Files selected for processing (4)
  • contracts/OMN-9755.yaml
  • drift/dod_receipts/OMN-9755/dod-001/file_exists.yaml
  • drift/dod_receipts/OMN-9755/dod-002/test_passes.yaml
  • drift/dod_receipts/OMN-9755/dod-003/file_exists.yaml

📝 Walkthrough

Walkthrough

This pull request adds configuration and evidence records for contract change request OMN-9755, including a contract manifest and three Definition of Done (DoD) receipt records documenting requirement fulfillment checks (file existence, test execution, and pre-commit validation).

Changes

Cohort / File(s) Summary
Contract Manifest
contracts/OMN-9755.yaml
Introduces contract change request manifest specifying ticket OMN-9755, schema version, change summary, interface impact, seam ticket designation, and emergency bypass settings with enumerated DoD requirements.
DoD Evidence Records
drift/dod_receipts/OMN-9755/dod-001/file_exists.yaml, drift/dod_receipts/OMN-9755/dod-002/test_passes.yaml, drift/dod_receipts/OMN-9755/dod-003/file_exists.yaml
Captures three evidence records documenting passing checks: loader implementation presence, unit/integration test passage, and pre-commit validation, each with execution metadata (timestamp, commit SHA, runner, PR number) and exit code confirmation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A contract is sealed with a hop and a bound,
DoD receipts scattered all over the ground,
OMN-9755 dances with glee,
Evidence checked, as clear as can be!
✨ Thump-thump-thump! 📋

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The PR title accurately summarizes the main change: adding an OCC contract (OMN-9755.yaml) and DoD evidence receipts for an SPI default contract loader, which directly matches the file additions in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9755-occ-contract-receipts

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge April 25, 2026 18:59
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 25, 2026
Merged via the queue into main with commit 4e8e568 Apr 25, 2026
27 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9755-occ-contract-receipts branch April 25, 2026 19:03
jonahgabriel added a commit that referenced this pull request Apr 25, 2026
OMN-9755 covered by merged PR #386.
OMN-9751 covered by open PR #385.
This PR now contains only OMN-9749 OCC contract + receipts.
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Apr 27, 2026
…ertContract (OmniNode-ai#383)

* chore(OMN-9749/9751/9755): add OCC contracts and DoD receipts for infra typed-model PRs

Unblocks receipt-gate on omnibase_infra PRs:
- OmniNode-ai#1415 (OMN-9749): ModelMonitorAlertContract + monitor_logs wire
- OmniNode-ai#1417 (OMN-9751): ModelFeatureFlagContract + load_service_contract loader
- OmniNode-ai#1418 (OMN-9755): SPI default template loader moved to infra layer

* chore(OMN-9749): de-scope OMN-9751 and OMN-9755 from this PR

OMN-9755 covered by merged PR OmniNode-ai#386.
OMN-9751 covered by open PR OmniNode-ai#385.
This PR now contains only OMN-9749 OCC contract + receipts.
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Apr 27, 2026
…eck_type (OmniNode-ai#389)

Receipt-gate derives receipt path from check_type field, ignoring
check_value. Contract on main declares check_type: file_exists for dod-002,
but PR OmniNode-ai#386 placed the receipt at dod-002/test_passes.yaml. Gate looks for
dod-002/file_exists.yaml and fails.

Adds the file_exists.yaml receipt at the path the gate actually checks.
Same content, schema-correct filename. Mirrors fix for OMN-9746
(OCC PR OmniNode-ai#384, commit 721419b).

Unblocks omnibase_infra PR OmniNode-ai#1418 receipt-gate.
jonahgabriel added a commit that referenced this pull request Jun 29, 2026
… omnimarket

omnimemory removed node_intent_event_consumer_effect/contract.yaml in OMN-13701
(PR #386). The consumer for onex.evt.omniintelligence.intent-classified.v1 moved
to omnimarket (where node_intent_event_consumer_effect/contract.yaml exists).

Update kafka_boundaries.yaml to reflect the live consumer location.
Add omnimarket to the validate-boundaries action default repos list so CI can
clone it when checking this boundary.

This unblocks Cross-Repo Boundary Parity CI check across all omniclaude PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant