Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 61 additions & 0 deletions contracts/OMN-14172.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-14172"
title: "ci(OMN-14172): fail-closed gate against integration silent-skip false-greens"
summary: >-
Central OCC evidence for omnimarket PR #1652. The PR adds a fail-closed integration silent-skip guard
to omnimarket CI, including data-driven service skip policy, local self-test coverage, and CI summary
wiring. This evidence PR performs no live deploy, runtime restart, branch-protection mutation, or bypass.
is_seam_ticket: false
interface_change: false
interfaces_touched: []
emergency_bypass:
enabled: false
justification: ""
follow_up_ticket_id: ""
dod_evidence:
- id: "dod-omnimarket-pr-1652"
description: >-
omnimarket PR #1652 is open against dev at head cc7303e4976772620506420f12802fa3deffee5b and carries
the integration silent-skip guard implementation plus CI/pre-commit wiring.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml &&
grep -q '^pr_number: 1652$' drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml
&& grep -q '^commit_sha: cc7303e4976772620506420f12802fa3deffee5b$' drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml
- id: "dod-silent-skip-proof"
description: >-
PR #1652 records proof that the guard fails on provisioned-service false-greens and passes for provisioned
execution with only optional skips.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' drift/dod_receipts/OMN-14172/dod-silent-skip-proof/command.yaml &&
grep -q '11/11' drift/dod_receipts/OMN-14172/dod-silent-skip-proof/command.yaml
- id: "dod-no-live-deploy"
description: >-
Scope evidence: this is CI/test-process work only. The OCC PR performs no live deploy, no runtime
restart, no branch-protection change, and no bypass.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' drift/dod_receipts/OMN-14172/dod-no-live-deploy/command.yaml && grep
-qi 'no live deploy' drift/dod_receipts/OMN-14172/dod-no-live-deploy/command.yaml
- id: "dod-occ-pr-self"
description: >-
Self-binding receipt: onex_change_control PR #3741 carries the central OMN-14172 contract and PASS
receipts consumed by omnimarket PR #1652 via Evidence-Source after merge.
source: "manual"
status: "verified"
checks:
- check_type: "command"
check_value: >-
grep -q '^status: PASS$' drift/dod_receipts/OMN-14172/dod-occ-pr-self/command.yaml && grep -q
'^pr_number: 3741$' drift/dod_receipts/OMN-14172/dod-occ-pr-self/command.yaml
22 changes: 22 additions & 0 deletions drift/dod_receipts/OMN-14172/dod-no-live-deploy/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-14172"
evidence_item_id: "dod-no-live-deploy"
check_type: "command"
check_value: "git diff --name-only origin/dev...HEAD"
status: PASS
run_timestamp: "2026-07-09T03:22:00Z"
commit_sha: cc7303e4976772620506420f12802fa3deffee5b
runner: "codex-manual-merge-sweep"
verifier: "occ-evidence-lane"
probe_command: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json files --jq '[.files[].path]'"
probe_stdout: |
[".github/workflows/ci.yml",".pre-commit-config.yaml","scripts/ci/check_integration_skips.py","scripts/ci/integration_skip_guard.yaml","tests/ci/test_check_integration_skips.py"]
actual_output: >-
PASS: OMN-14172 is CI/test-process work only. It performs no live deploy, no runtime restart, no branch-protection
mutation, and no bypass.
exit_code: 0
pr_number: 1652
branch: "jonah/omn-14172-silent-skip-gate"
working_dir: "/Users/jonah/Code/omni_home/omni_worktrees/OMN-14172/omnimarket"
contract_sha256: "sha256:9426c8012e0432615b5feb310e908b7ab2cfcaa9541dad44d7628d808dec0eab"
23 changes: 23 additions & 0 deletions drift/dod_receipts/OMN-14172/dod-occ-pr-self/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-14172"
evidence_item_id: "dod-occ-pr-self"
check_type: "command"
check_value: "gh pr view 3741 --repo OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid"
status: PASS
run_timestamp: "2026-07-09T03:33:00Z"
commit_sha: 0f21a43def22e5b5655ef1d63c18592a520adda3
runner: "codex-manual-merge-sweep"
verifier: "occ-evidence-lane"
probe_command: "gh pr view 3741 --repo OmniNode-ai/onex_change_control --json number,state,headRefName,headRefOid"
probe_stdout: |
{"headRefName":"jonah/omn-14172-occ-evidence","headRefOid":"0f21a43def22e5b5655ef1d63c18592a520adda3","number":3741,"state":"OPEN"}
actual_output: >-
PASS: onex_change_control PR #3741 carries the central OMN-14172 contract and PASS receipts for omnimarket
PR #1652. The downstream PR will cite this OCC PR with Evidence-Source: OCC#3741 after the OCC PR is
merged.
exit_code: 0
pr_number: 3741
branch: "jonah/omn-14172-occ-evidence"
working_dir: "/Users/jonah/Code/omni_home/omni_worktrees/OMN-14172/onex_change_control"
contract_sha256: "sha256:9426c8012e0432615b5feb310e908b7ab2cfcaa9541dad44d7628d808dec0eab"
22 changes: 22 additions & 0 deletions drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-14172"
evidence_item_id: "dod-omnimarket-pr-1652"
check_type: "command"
check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title,files"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

check_value and probe_command don't match.

check_value requests ...baseRefName,title,files but the actually-executed probe_command omits files. The declared check and the executed probe should be identical so the receipt accurately reflects what was verified.

🛡️ Proposed fix
-check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title,files"
+check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title"

Also applies to: 12-12

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml` at line 6,
The receipt check is inconsistent because the declared check_value in the
command YAML does not match the executed probe_command: the probe omits the
files field while the check requests it. Update the command entry so the gh pr
view probe and check declare the exact same JSON fields, keeping the check_value
and probe_command identical in the receipt definition.

status: PASS
run_timestamp: "2026-07-09T03:22:00Z"
commit_sha: cc7303e4976772620506420f12802fa3deffee5b
runner: "codex-manual-merge-sweep"
verifier: "occ-evidence-lane"
probe_command: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title"
probe_stdout: |
{"baseRefName":"dev","headRefName":"jonah/omn-14172-silent-skip-gate","headRefOid":"cc7303e4976772620506420f12802fa3deffee5b","number":1652,"state":"OPEN","title":"ci(OMN-14172): fail-closed gate against integration silent-skip false-greens"}
actual_output: >-
PASS: omnimarket PR #1652 is open against dev at head cc7303e4976772620506420f12802fa3deffee5b and carries
the integration silent-skip guard, config, CI summary wiring, pre-commit hook, and unit tests.
exit_code: 0
pr_number: 1652
branch: "jonah/omn-14172-silent-skip-gate"
working_dir: "/Users/jonah/Code/omni_home/omni_worktrees/OMN-14172/omnimarket"
contract_sha256: "sha256:9426c8012e0432615b5feb310e908b7ab2cfcaa9541dad44d7628d808dec0eab"
23 changes: 23 additions & 0 deletions drift/dod_receipts/OMN-14172/dod-silent-skip-proof/command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
---
schema_version: "1.0.0"
ticket_id: "OMN-14172"
evidence_item_id: "dod-silent-skip-proof"
check_type: "command"
check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json body --jq .body"
status: PASS
run_timestamp: "2026-07-09T03:22:00Z"
commit_sha: cc7303e4976772620506420f12802fa3deffee5b
runner: "codex-manual-merge-sweep"
verifier: "occ-evidence-lane"
probe_command: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json body --jq .body"
probe_stdout: |
PR body dod_evidence records false-green reproduction, provisioned-state pass, --selftest pass, 11/11 unit tests, ruff clean, aislop clean, and pre-commit proof.
actual_output: >-
PASS: omnimarket PR #1652 records guard proof for both cases: provisioned Postgres absence skips fail
closed, provisioned execution with only optional skips passes, and 11/11 unit tests plus selftest validate
the parser/gate.
exit_code: 0
pr_number: 1652
branch: "jonah/omn-14172-silent-skip-gate"
working_dir: "/Users/jonah/Code/omni_home/omni_worktrees/OMN-14172/omnimarket"
contract_sha256: "sha256:9426c8012e0432615b5feb310e908b7ab2cfcaa9541dad44d7628d808dec0eab"
Loading