Skip to content

evidence(OMN-14172): add omnimarket PR 1652 OCC receipts - #3741

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-14172-occ-evidence
Jul 9, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-14172-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 9, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run python -m onex_change_control.scripts.validate_yaml contracts/OMN-14172.yaml
  • uv run python scripts/check_dod_evidence_present.py contracts/OMN-14172.yaml
  • ModelDodReceipt validation for drift/dod_receipts/OMN-14172/*/command.yaml
  • pre-commit hooks passed during commit

Downstream: OmniNode-ai/omnimarket#1652

Summary by CodeRabbit

  • New Features
    • Added contract evidence coverage for CI checks related to skipped tests, false-green prevention, and change-control validation.
    • Added proof that the scope is limited to CI/test processes, with no live deployment or bypass paths enabled.
    • Added receipt linkage to confirm evidence is tracked end-to-end across related checks.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026 •

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR adds a new contract evidence file (contracts/OMN-14172.yaml) declaring four dod_evidence entries with disabled emergency bypass, plus four corresponding drift/dod_receipts/OMN-14172/*/command.yaml files documenting PASS-status command probes (PR checks, git diff scope, silent-skip proof) with execution metadata and contract hashes.

Changes

OMN-14172 Evidence Contract and Receipts

Layer / File(s) Summary
Contract metadata and bypass settings
contracts/OMN-14172.yaml
Declares schema version, ticket identifiers, seam/interface-change flags, and disables emergency_bypass.
PR-1652 evidence entry and receipt
contracts/OMN-14172.yaml, drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml
Adds dod-omnimarket-pr-1652 verified receipt entry and matching gh pr view command probe recording PASS status and PR metadata.
Silent-skip proof evidence entry and receipt
contracts/OMN-14172.yaml, drift/dod_receipts/OMN-14172/dod-silent-skip-proof/command.yaml
Adds dod-silent-skip-proof verified receipt entry and matching command probe confirming guard behavior for false-greens vs. valid execution.
No-live-deploy scope evidence entry and receipt
contracts/OMN-14172.yaml, drift/dod_receipts/OMN-14172/dod-no-live-deploy/command.yaml
Adds dod-no-live-deploy verified receipt entry and matching git diff probe confirming CI/test-process-only scope.
OCC self-binding evidence entry and receipt
contracts/OMN-14172.yaml, drift/dod_receipts/OMN-14172/dod-occ-pr-self/command.yaml
Adds dod-occ-pr-self verified receipt entry and matching gh pr view probe self-binding to PR #3741.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#3149: Both PRs add/update dod-occ-pr-self command-type evidence receipts that self-bind pr_number/status: PASS within corresponding contract YAML evidence lists.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is specific and relevant to the PR, accurately pointing to the OMN-14172 OmniMarket PR 1652 OCC receipts.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14172-occ-evidence

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml`:
- Line 6: The receipt check is inconsistent because the declared check_value in
the command YAML does not match the executed probe_command: the probe omits the
files field while the check requests it. Update the command entry so the gh pr
view probe and check declare the exact same JSON fields, keeping the check_value
and probe_command identical in the receipt definition.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 267f9d33-a39d-4ca8-9362-0dc7970763cc

📥 Commits

Reviewing files that changed from the base of the PR and between 2571327 and 91b937f.

📒 Files selected for processing (5)
  • contracts/OMN-14172.yaml
  • drift/dod_receipts/OMN-14172/dod-no-live-deploy/command.yaml
  • drift/dod_receipts/OMN-14172/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml
  • drift/dod_receipts/OMN-14172/dod-silent-skip-proof/command.yaml

ticket_id: "OMN-14172"
evidence_item_id: "dod-omnimarket-pr-1652"
check_type: "command"
check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title,files"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

check_value and probe_command don't match.

check_value requests ...baseRefName,title,files but the actually-executed probe_command omits files. The declared check and the executed probe should be identical so the receipt accurately reflects what was verified.

🛡️ Proposed fix
-check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title,files"
+check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title"

Also applies to: 12-12

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml` at line 6,
The receipt check is inconsistent because the declared check_value in the
command YAML does not match the executed probe_command: the probe omits the
files field while the check requests it. Update the command entry so the gh pr
view probe and check declare the exact same JSON fields, keeping the check_value
and probe_command identical in the receipt definition.

@jonahgabriel
jonahgabriel merged commit dac2eb1 into dev Jul 9, 2026
51 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-14172-occ-evidence branch July 9, 2026 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant