Repository navigation
evidence(OMN-14172): add omnimarket PR 1652 OCC receipts - #3741
Conversation
📝 WalkthroughWalkthroughThis PR adds a new contract evidence file ( ChangesOMN-14172 Evidence Contract and Receipts
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml`:
- Line 6: The receipt check is inconsistent because the declared check_value in
the command YAML does not match the executed probe_command: the probe omits the
files field while the check requests it. Update the command entry so the gh pr
view probe and check declare the exact same JSON fields, keeping the check_value
and probe_command identical in the receipt definition.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 267f9d33-a39d-4ca8-9362-0dc7970763cc
📒 Files selected for processing (5)
contracts/OMN-14172.yamldrift/dod_receipts/OMN-14172/dod-no-live-deploy/command.yamldrift/dod_receipts/OMN-14172/dod-occ-pr-self/command.yamldrift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yamldrift/dod_receipts/OMN-14172/dod-silent-skip-proof/command.yaml
| ticket_id: "OMN-14172" | ||
| evidence_item_id: "dod-omnimarket-pr-1652" | ||
| check_type: "command" | ||
| check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title,files" |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win
check_value and probe_command don't match.
check_value requests ...baseRefName,title,files but the actually-executed probe_command omits files. The declared check and the executed probe should be identical so the receipt accurately reflects what was verified.
🛡️ Proposed fix
-check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title,files"
+check_value: "gh pr view 1652 --repo OmniNode-ai/omnimarket --json number,state,headRefName,headRefOid,baseRefName,title"Also applies to: 12-12
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@drift/dod_receipts/OMN-14172/dod-omnimarket-pr-1652/command.yaml` at line 6,
The receipt check is inconsistent because the declared check_value in the
command YAML does not match the executed probe_command: the probe omits the
files field while the check requests it. Update the command entry so the gh pr
view probe and check declare the exact same JSON fields, keeping the check_value
and probe_command identical in the receipt definition.
Summary
Verification
Downstream: OmniNode-ai/omnimarket#1652
Summary by CodeRabbit