Repository navigation
chore(OMN-597): dod_receipts for omnibase_core#885 - #343
Conversation
Adds 4 ModelDodReceipt entries for OMN-597 (fsm_metadata <-> metadata dict consistency), unblocking the receipt-gate (verify/verify) on omnibase_core#885. Receipts cover dod-001 through dod-004 from contracts/OMN-597.yaml, tightened from generic templates to check the exact files shipped in PR #885: - dod-001: PR #885 OPEN targeting main -> PASS - dod-002: model_reducer_output.py present in diff (typed fsm_metadata field) -> PASS - dod-003: node_reducer.py present in diff (process_fsm rewired) -> PASS - dod-004: test_node_reducer_fsm_metadata_consistency.py added (12 round-trip tests) -> PASS All receipts validate against ModelDodReceipt. Command check_values were executed live before commit and all return PASS against PR #885 head 5af9b069. OMN-597
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe PR updates the definition-of-done (dod) evidence contract for ticket OMN-597 to validate specific content of GitHub PR Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
…C2 at the merged head (#12166) * evidence(OMN-19994): transcribe the ticket's two criteria and prove AC2 at the merged head contracts/OMN-19994.yaml had no acceptance transcription and no AC bindings, and its product proof pinned dbb2b26e, an earlier head than the one omnidash#343 merged from, so dod_verify proved only that four test cases exist. - The ticket's AC1 and AC2 are transcribed as written; no third criterion is added. - dod-omn19994-current-head-native-vitest supersedes dod-OmniNode-ai-omnidash-pr-343: the squash merge 12ec580a is an ancestor of omnidash dev, PR #343's reviewed head a3d351b6 and merge commit match exactly, and `npm test` runs the overlay resolution and ProjectionContainer tests. It binds AC2 only (typed tenant-not-configured state, no scoped request); the overlay test is supporting evidence and binds nothing. - AC1 (fresh-install Runs readback) stays open behind OMN-19976. Prepared by codex-01a0f6a9 under the approved OMN-19994 evidence spec; verified independently and committed by claude-de42d5d9. * evidence(OMN-19994): fix AC binding gate refusal and add missing receipts - Removed binds_ac AC2 from dod-omn19994-current-head-native-vitest to resolve ac_binding_criterion_unbound error, as AC1 remains unbound and open behind OMN-19976. - Reworded item description to clarify that the Vitest proof serves as the AC2 falsifier without binding a criterion. - Added missing command.yaml and test_passes.yaml receipts under drift/dod_receipts/OMN-19994/ to satisfy occ-preflight and verify checks. - Receipts record PASS status from lab host h201 in an omnidash dev checkout at cc628179717f, confirming 12ec580ac50b is an ancestor of HEAD and 11/11 tests passed. - Pinned formatted contract and entry hashes in receipts to ensure integrity. * evidence(OMN-18921): mint the owed OCC self-bind for PR #12166 --------- Co-authored-by: Lakshman Patel <Lakshmanp230@gmail.com> Co-authored-by: Jonah Gray <jonah@omninode.ai> Co-authored-by: onexbot-occ-writer[bot] <onexbot-occ-writer[bot]@users.noreply.github.com>
Summary
Adds 4
ModelDodReceiptentries for OMN-597 (fsm_metadata <-> metadata dict consistency), unblocking theverify / verifygate on downstreamomnibase_core#885.Receipts cover dod-001 through dod-004 from
contracts/OMN-597.yaml, tightened from generic templates to check the exact files shipped in PR #885:src/omnibase_core/models/reducer/model_reducer_output.pypresent in diff (typedfsm_metadatafield) -> PASSsrc/omnibase_core/nodes/node_reducer.pypresent in diff (process_fsmrewired to derive dict extras from typed model) -> PASStests/unit/nodes/test_node_reducer_fsm_metadata_consistency.pypresent in diff (12 round-trip consistency tests) -> PASSAll receipts validate against
ModelDodReceipt. Commandcheck_valueexpressions were executed live before commit and all return PASS against PR #885 head5af9b069.Pattern mirrors OCC#339 (OMN-7537 receipts for omnibase_core#883).
OMN-597
dod_evidence
drift/dod_receipts/OMN-597/dod-001/command.yaml-> PASSdrift/dod_receipts/OMN-597/dod-002/command.yaml-> PASSdrift/dod_receipts/OMN-597/dod-003/command.yaml-> PASSdrift/dod_receipts/OMN-597/dod-004/command.yaml-> PASSTest plan
pre-commit run --all-files-> all hooks passedcheck_valueexpressions executed locally -> PASSpr-title / check-title+gate / CodeRabbit Thread Checkgreen on this PRSummary by CodeRabbit