Skip to content

chore(OMN-597): dod_receipts for omnibase_core#885 - #343

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-597-dod-receipts
Apr 24, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-597-dod-receipts

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds 4 ModelDodReceipt entries for OMN-597 (fsm_metadata <-> metadata dict consistency), unblocking the verify / verify gate on downstream omnibase_core#885.

Receipts cover dod-001 through dod-004 from contracts/OMN-597.yaml, tightened from generic templates to check the exact files shipped in PR #885:

  • dod-001: omnibase_core PR feat(OMN-10783): add contract for ConfigWriter onboarding task 6 #885 OPEN targeting main -> PASS
  • dod-002: src/omnibase_core/models/reducer/model_reducer_output.py present in diff (typed fsm_metadata field) -> PASS
  • dod-003: src/omnibase_core/nodes/node_reducer.py present in diff (process_fsm rewired to derive dict extras from typed model) -> PASS
  • dod-004: tests/unit/nodes/test_node_reducer_fsm_metadata_consistency.py present in diff (12 round-trip consistency tests) -> PASS

All receipts validate against ModelDodReceipt. Command check_value expressions were executed live before commit and all return PASS against PR #885 head 5af9b069.

Pattern mirrors OCC#339 (OMN-7537 receipts for omnibase_core#883).

OMN-597

dod_evidence

  • drift/dod_receipts/OMN-597/dod-001/command.yaml -> PASS
  • drift/dod_receipts/OMN-597/dod-002/command.yaml -> PASS
  • drift/dod_receipts/OMN-597/dod-003/command.yaml -> PASS
  • drift/dod_receipts/OMN-597/dod-004/command.yaml -> PASS

Test plan

  • pre-commit run --all-files -> all hooks passed
  • All 4 command check_value expressions executed locally -> PASS
  • CI pr-title / check-title + gate / CodeRabbit Thread Check green on this PR

Summary by CodeRabbit

Adds 4 ModelDodReceipt entries for OMN-597 (fsm_metadata <-> metadata
dict consistency), unblocking the receipt-gate (verify/verify) on
omnibase_core#885.

Receipts cover dod-001 through dod-004 from contracts/OMN-597.yaml,
tightened from generic templates to check the exact files shipped in
PR #885:

- dod-001: PR #885 OPEN targeting main -> PASS
- dod-002: model_reducer_output.py present in diff (typed fsm_metadata field) -> PASS
- dod-003: node_reducer.py present in diff (process_fsm rewired) -> PASS
- dod-004: test_node_reducer_fsm_metadata_consistency.py added (12 round-trip tests) -> PASS

All receipts validate against ModelDodReceipt. Command check_values
were executed live before commit and all return PASS against PR #885
head 5af9b069.

OMN-597
@coderabbitai

coderabbitai Bot commented Apr 24, 2026 •

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ed1cb66b-03fa-48c0-be98-4803cf20fc65

📥 Commits

Reviewing files that changed from the base of the PR and between e1d77af and 5a1405e.

📒 Files selected for processing (5)
  • contracts/OMN-597.yaml
  • drift/dod_receipts/OMN-597/dod-001/command.yaml
  • drift/dod_receipts/OMN-597/dod-002/command.yaml
  • drift/dod_receipts/OMN-597/dod-003/command.yaml
  • drift/dod_receipts/OMN-597/dod-004/command.yaml

📝 Walkthrough

Walkthrough

The PR updates the definition-of-done (dod) evidence contract for ticket OMN-597 to validate specific content of GitHub PR #885, replacing generic workflow checks with targeted validations of PR state (OPEN, baseRefName=main) and the presence of three particular files. Four new receipt files document successful verification of these checks.

Changes

Cohort / File(s) Summary
Definition of Done Contract
contracts/OMN-597.yaml
Updated dod_evidence checks: dod-001 validates PR state is OPEN with baseRefName=main; dod-002 through dod-004 confirm presence of model_reducer_output.py, node_reducer.py, and tests/unit/nodes/test_node_reducer_fsm_metadata_consistency.py via GitHub PR file path matching. Removed prior checks for merge time, CI status, and pre-commit execution.
DoD Receipt Records
drift/dod_receipts/OMN-597/dod-{001,002,003,004}/command.yaml
Four new YAML receipt files documenting successful command-based verification of the dod checks against PR #885, each recording execution timestamp, commit SHA, runner info, command output (actual_output: "true"), and exit_code: 0 with status: PASS.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

Poem

🐰 A rabbit hops through PR files with glee,
Checking state and paths with GitHub's decree,
OPEN and main, three files verified true,
Evidence receipts in yaml, all shiny and new! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main change: adding definition of duty (dod) receipts for ticket OMN-597 related to omnibase_core PR #885.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-597-dod-receipts

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge April 24, 2026 02:58
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 24, 2026
Merged via the queue into main with commit 732a06b Apr 24, 2026
27 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-597-dod-receipts branch April 24, 2026 03:03
jonahgabriel added a commit that referenced this pull request Oct 1, 2026
…C2 at the merged head (#12166)

* evidence(OMN-19994): transcribe the ticket's two criteria and prove AC2 at the merged head

contracts/OMN-19994.yaml had no acceptance transcription and no AC bindings,
and its product proof pinned dbb2b26e, an earlier head than the one omnidash#343
merged from, so dod_verify proved only that four test cases exist.

- The ticket's AC1 and AC2 are transcribed as written; no third criterion is
  added.
- dod-omn19994-current-head-native-vitest supersedes dod-OmniNode-ai-omnidash-pr-343:
  the squash merge 12ec580a is an ancestor of omnidash dev, PR #343's reviewed
  head a3d351b6 and merge commit match exactly, and `npm test` runs the overlay
  resolution and ProjectionContainer tests. It binds AC2 only (typed
  tenant-not-configured state, no scoped request); the overlay test is
  supporting evidence and binds nothing.
- AC1 (fresh-install Runs readback) stays open behind OMN-19976.

Prepared by codex-01a0f6a9 under the approved OMN-19994 evidence spec;
verified independently and committed by claude-de42d5d9.

* evidence(OMN-19994): fix AC binding gate refusal and add missing receipts

- Removed binds_ac AC2 from dod-omn19994-current-head-native-vitest to resolve ac_binding_criterion_unbound error, as AC1 remains unbound and open behind OMN-19976.
- Reworded item description to clarify that the Vitest proof serves as the AC2 falsifier without binding a criterion.
- Added missing command.yaml and test_passes.yaml receipts under drift/dod_receipts/OMN-19994/ to satisfy occ-preflight and verify checks.
- Receipts record PASS status from lab host h201 in an omnidash dev checkout at cc628179717f, confirming 12ec580ac50b is an ancestor of HEAD and 11/11 tests passed.
- Pinned formatted contract and entry hashes in receipts to ensure integrity.

* evidence(OMN-18921): mint the owed OCC self-bind for PR #12166

---------

Co-authored-by: Lakshman Patel <Lakshmanp230@gmail.com>
Co-authored-by: Jonah Gray <jonah@omninode.ai>
Co-authored-by: onexbot-occ-writer[bot] <onexbot-occ-writer[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant