Repository navigation
receipt(OMN-13025): OCC contract + DoD receipts for evidence-language guard pre-commit hook - #3247
Conversation
|
Warning Review limit reached
More reviews will be available in 18 minutes and 15 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
8736736 to
d0b2c69
Compare
…2e claims in docs/evidence/** without Playwright artifact (OmniNode-ai#1813) ## Summary OMN-13025 (A-3): Adds `reject-evidence-ui-claims` pre-commit hook that enforces evidence-language honesty in `docs/evidence/**` markdown files. OCC receipt PR: OmniNode-ai/onex_change_control#3247 ## Root Cause PROCESS_FAILURE_RETRO.md §3.A (top-10 failure OmniNode-ai#1): the 2026-06-11 19:27Z evidence doc claimed "UI POST → full chain live" when only curl was run. This led to a false "done" declaration. ## What This PR Adds - `.pre-commit-hooks/reject-evidence-ui-claims.sh` — blocking hook (no warn-only mode per CLAUDE.md Rule OmniNode-ai#5 + Rule OmniNode-ai#10) - `.pre-commit-config.yaml` — wires the hook at `pre-commit` stage on `types: [markdown]` - `contracts/OMN-13025.yaml` — OCC contract with dod_evidence - `tests/hooks/test_reject_evidence_ui_claims.py` — 8 unit tests (TDD-first, all pass before implementation was written) - `tests/hooks/fixtures/evidence_language/` — 6 fixture files covering all reject/accept/ignore cases ## Hook Behavior Blocked claim patterns (case-insensitive) in `docs/evidence/**`: - `UI POST` - `click` - `full chain live` - `end-to-end` / `end to end` A claim is allowed only when the document also references a Playwright artifact (`playwright` or `test-results/` appears anywhere in the doc). ## DoD Evidence ``` dod-hook-exists-executable: test -x .pre-commit-hooks/reject-evidence-ui-claims.sh → PASS (script present and executable) dod-hook-wired-in-precommit: grep -q 'reject-evidence-ui-claims' .pre-commit-config.yaml → PASS (hook registered in pre-commit config) dod-unit-tests-pass: uv run pytest tests/hooks/test_reject_evidence_ui_claims.py -v → 8 passed in 0.37s dod-commit-blocked-on-overstatement: Hook rejects docs/evidence/*.md with "UI POST" and no Playwright reference → EVIDENCE_UI_CLAIM_UNVERIFIED raised (correct behavior) ``` Evidence-Source: OCC#3247 Evidence-Ticket: OMN-13025 Implementation-Head: db97023cf66d47ae4e97a8a1c6d383980b946d56 OCC-Receipt-PR: OmniNode-ai/onex_change_control#3247 --------- Co-authored-by: jonahgabriel <jonahgabriel@users.noreply.github.com>
1 participant
Summary
OCC receipt PR for OMN-13025 (A-3): evidence-language guard pre-commit hook on
docs/evidence/**.Evidence-Source: 2f29ead
Evidence-Ticket: OMN-13025
What This PR Contains
contracts/OMN-13025.yaml— OCC contract declaring the hook implementationdrift/dod_receipts/OMN-13025/— 4 DoD receipts:dod-hook-exists-executable: verifies hook script is present and executabledod-hook-wired-in-precommit: verifies hook is registered in.pre-commit-config.yamldod-unit-tests-pass: verifies all 8 unit tests passdod-occ-self: self-binding OCC receiptDoD
The implementation PR (omniclaude) adds:
.pre-commit-hooks/reject-evidence-ui-claims.sh— blocks UI/e2e claims indocs/evidence/**without Playwright artifact reference.pre-commit-config.yamlwiringcontracts/OMN-13025.yamlRoot cause closed: PROCESS_FAILURE_RETRO.md §3.A (top-10 failure #1) — the 2026-06-11 19:27Z evidence doc claimed "UI POST → full chain live" when only curl was run.