Repository navigation
evidence(OMN-13670): add cryptography CVE floor receipt for expand-trivy-floors follow-up - #3233
jonahgabriel wants to merge 1 commit into
Conversation
… hotfix Adds dod-crypto-floor and dod-occ-self-b evidence items to the OMN-13670 contract and receipts to cover the omnibase_infra follow-up PR (jonah/omn-13670-expand-trivy-floors) that raises cryptography>=48.0.1 to clear GHSA-537c-gmf6-5ccf (HIGH: vulnerable OpenSSL in wheels <48.0.1). Evidence-Ticket: OMN-13670 Evidence-Source: OCC#<this-PR>
📝 WalkthroughWalkthroughTwo new ChangesOMN-13670 DoD Evidence Receipts
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-13670/dod-occ-self-b/command.yaml`:
- Around line 13-21: The self-binding receipt is using prose and an unresolved
placeholder instead of a real OCC PR query. Update the command in probe_command
to use the actual gh pr view lookup that produced the metadata in probe_stdout,
and replace OCC#<PR-number> in actual_output with the bound PR identifier/head
commit. Keep the receipt tied to the existing onex_change_control/OCC PR binding
flow so the PASS summary references concrete evidence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: ade70f02-5570-4cc0-8787-e2004a4000e3
📒 Files selected for processing (3)
contracts/OMN-13670.yamldrift/dod_receipts/OMN-13670/dod-crypto-floor/command.yamldrift/dod_receipts/OMN-13670/dod-occ-self-b/command.yaml
| probe_command: "onex_change_control PR carrying OMN-13670 follow-up crypto floor receipt is open" | ||
| probe_stdout: | | ||
| branch: jonah/omn-13670b-crypto-floor | ||
| baseRefName: dev | ||
| headRefName: jonah/omn-13670b-crypto-floor | ||
| actual_output: >- | ||
| PASS: this follow-up onex_change_control PR adds the dod-crypto-floor receipt for omnibase_infra follow-up | ||
| PR (jonah/omn-13670-expand-trivy-floors) via Evidence-Source: OCC#<PR-number>. The OCC self-binding | ||
| receipt confirms this PR carries valid evidence. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Bind this receipt to a real OCC PR query.
Line 13 is prose instead of the command that produced the PR metadata in Lines 15-17, and Line 20 still has the unresolved OCC#<PR-number> placeholder. That makes the self-binding receipt non-reproducible and leaves the evidence source unbound to a concrete OCC PR/head commit. Based on learnings, PR-binding DoD receipts should use gh pr view in probe_command and the PASS summary should reference the bound head commit.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@drift/dod_receipts/OMN-13670/dod-occ-self-b/command.yaml` around lines 13 -
21, The self-binding receipt is using prose and an unresolved placeholder
instead of a real OCC PR query. Update the command in probe_command to use the
actual gh pr view lookup that produced the metadata in probe_stdout, and replace
OCC#<PR-number> in actual_output with the bound PR identifier/head commit. Keep
the receipt tied to the existing onex_change_control/OCC PR binding flow so the
PASS summary references concrete evidence.
Source: Learnings
Pull request was closed
Summary
dod-crypto-flooranddod-occ-self-bevidence itemscryptography>=48.0.1is declared in pyproject.toml on the follow-up hotfix branch (commit 3f8bffae007c562858a647498f7f6e8707cc1567)Evidence-Ticket: OMN-13670
Evidence-Source: OCC#
Summary by CodeRabbit
Bug Fixes
Chores