Skip to content

fix(contracts): remove circular dod-003 from OMN-8038 contract - #267

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-8038-fix-dod003-test-passes
Apr 14, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-8038-fix-dod003-test-passes

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Apr 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • test_passes for dod-003 evaluates concurrent PR checks mid-flight, which sees other running checks as pending/failing — circular dependency
  • CI tests are verified by the PR gate (CI Summary, CodeQL), not by the compliance check running inside CI
  • Remove dod-003 entirely: "tests pass in CI" is inherently verified by branch protection, not by this check

Unblocks omnibase_compat#53 (OMN-8038). Follow-up to #265, #266.

Summary by CodeRabbit

  • Chores
    • Removed an evidence entry and its associated CI check validation from contract definitions.

@coderabbitai

coderabbitai Bot commented Apr 14, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 3 minutes and 56 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 3 minutes and 56 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7b6d3518-0561-4901-8b63-f7c645ed1115

📥 Commits

Reviewing files that changed from the base of the PR and between 5066e0b and 62f83a0.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • contracts/OMN-8038.yaml
📝 Walkthrough

Walkthrough

The dod-003 evidence entry, which validates that tests pass in CI via a GitHub CLI command, has been removed from the definition of done configuration in contracts/OMN-8038.yaml.

Changes

Cohort / File(s) Summary
Configuration Update
contracts/OMN-8038.yaml
Removed dod-003 evidence entry ("Tests pass in CI") and its associated command check (gh pr checks) from the dod_evidence list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 One less check to hop on by,
A simpler path, no need to query,
Decluttered config, lean and spry,
The evidence thins, all merry!
✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix(contracts): remove circular dod-003 from OMN-8038 contract' directly and specifically describes the main change—removing the problematic dod-003 evidence entry from the contract due to its circular dependency issue.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-8038-fix-dod003-test-passes

Comment @coderabbitai help to get the list of available commands and usage tips.

jonahgabriel added a commit that referenced this pull request Apr 14, 2026
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-8038-fix-dod003-test-passes branch from 60bc276 to e5c64e1 Compare April 14, 2026 07:03
@github-actions
github-actions Bot added this pull request to the merge queue Apr 14, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Apr 14, 2026
@github-actions
github-actions Bot added this pull request to the merge queue Apr 14, 2026
@jonahgabriel
jonahgabriel removed this pull request from the merge queue due to a manual request Apr 14, 2026
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 855bd88 Apr 14, 2026
21 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-8038-fix-dod003-test-passes branch April 14, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant