Skip to content

fix(contracts): use test_passes for OMN-8038 dod-003 to fix pending-checks exit-8 - #266

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-8038-fix-dod003-test-passes
Apr 14, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-8038-fix-dod003-test-passes

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

  • Follow-up to fix(contracts): use {pr}/{repo} placeholders in OMN-8038 DoD commands #265: dod-001 and dod-002 now pass but dod-003 (gh pr checks {pr} --repo {repo}) fails with exit 8 when some checks are still pending at evaluation time
  • Fix: switch dod-003 to check_type: test_passes — this uses the dedicated _check_test_passes handler which returns WARN (not BLOCK) when checks are pending, only blocking on confirmed failures

Root cause

gh pr checks exits 8 for pending checks. The compliance check script already has test_passes check type that handles this gracefully — just need to use it.

Unblocks omnibase_compat#53 (OMN-8038).

@coderabbitai

coderabbitai Bot commented Apr 14, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 14 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 14 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 427c266f-4d6e-4fd6-b7b3-4270d4116e93

📥 Commits

Reviewing files that changed from the base of the PR and between a6ace16 and 3004eec.

📒 Files selected for processing (1)
  • contracts/OMN-8038.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-8038-fix-dod003-test-passes

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge April 14, 2026 06:49
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 4270883 Apr 14, 2026
22 of 23 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-8038-fix-dod003-test-passes branch April 14, 2026 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant