Repository navigation
receipt(OMN-13155): OCC contract + receipts — cross-DB agent_routing_decisions suppression (delivery PR #2636) - #2637
Conversation
…outing_decisions suppression Pairs onex_change_control delivery PR #2636 (head 0631d17) which adds the agent_routing_decisions cross_repo_shared_schema suppression to migration_conflict_suppressions.yaml. - contracts/OMN-13155.yaml: ModelTicketContract, 2 dod_evidence items - drift/dod_receipts/OMN-13155/dod-occ-suppression: conflict-scan before(exit 1)/after(exit 0) proof - drift/dod_receipts/OMN-13155/dod-delivery-pr: delivery PR head-SHA binding + contract validation contract_sha256 matches sha256(contracts/OMN-13155.yaml); verifier receipt-gate-local distinct from runner. Refs OMN-13150, OMN-13127.
|
Warning Review limit reached
More reviews will be available in 3 hours, 1 minute, and 21 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
agent_routing_decisions is a benign cross-DB EXACT_DUPLICATE: infra
docker/migrations/forward/021_create_agent_routing_decisions_table.sql
creates it in the omnibase_infra DB; the omnimarket
node_projection_routing_decision migration (0021, vendored into
omnibase_infra/docker/migrations/forward/nodes/, landed via OMN-13150)
creates the projection copy in omnidash_analytics (the node contract's
declared database). Identical 13-column DDL, two different databases,
both load-bearing — git-rm of either breaks a DB.
This was the sole unsuppressed conflict failing the OCC Migration
Conflict Check (38 sibling cross-DB projection tables already
suppressed under cross_repo_shared_schema). Adds the missing entry in
the same format; documents an intentional cross-DB duplicate, does not
hide a real conflict.
Repro (check-migration-conflicts, OCC gate command):
before: Found 1 migration conflict(s): EXACT_DUPLICATE
agent_routing_decisions -> exit 1
after: No migration conflicts found; Suppressed 39 known
conflict(s) -> exit 0
Broader consolidation tracked under OMN-13127. Refs OMN-13150.
…ipts, Evidence-Source self) Fold the migration_conflict_suppressions.yaml fix into this OCC PR so the dev merge_group Migration Conflict Check passes (a separate receipt PR off dev would itself fail that gate on the unsuppressed agent_routing_decisions conflict). Update receipts to bind to PR #2637 and refresh contract_sha256 to sha256(contracts/OMN-13155.yaml). Re-proven: check-migration-conflicts --check-columns --warn-columns --suppressions-file migration_conflict_suppressions.yaml -> No migration conflicts found, Suppressed 39 known conflict(s), exit 0. Refs OMN-13150, OMN-13127.
OMN-13155 — suppress cross-DB
agent_routing_decisionsduplicate (self-contained OCC PR)Single self-contained OCC PR: carries BOTH the fix (
migration_conflict_suppressions.yaml) AND the OCC contract + PASS receipts (Evidence-Source: self).Why self-contained
The unsuppressed
agent_routing_decisionsEXACT_DUPLICATEfails the OCCMigration Conflict Checkin the dev merge_group, which blocks every OCC PR (a separate receipt PR branched off dev would itself fail that gate). Folding the fix and receipts into one PR clears the gate and lands the evidence atomically.Diagnosis (verified, evidence-based)
agent_routing_decisionsis a benign cross-DBEXACT_DUPLICATE, identical 13-column DDL, two different databases, both load-bearing:omnibase_infra/docker/migrations/forward/021_create_agent_routing_decisions_table.sql-> omnibase_infra DB.omnibase_infra/docker/migrations/forward/nodes/node_projection_routing_decision/0021_create_agent_routing_decisions.sql-> the omnimarketnode_projection_routing_decisionmigration (vendored into infra'sforward/nodes/, landed via OMN-13150 / infra PR evidence(OMN-12514): add SEA inference bus receipts #1985) creating the projection copy in omnidash_analytics (the node contract's declareddb_io.db_tables[0].database).The OCC checker attributes both files to
omnibase_infra(repos-rootparts[0]) because the omnimarket node migration is vendored under the infra tree.git rmof either breaks a database. The canonical mechanism is the suppressions file undercross_repo_shared_schema; 38 sibling cross-DB projection tables are already suppressed. This adds the missingagent_routing_decisionsentry — documents an intentional cross-DB duplicate, does not hide a real conflict.Reproduction (exact OCC gate command)
The 36
MISSING_COLUMNfindings remain--warn-columnswarnings (non-fatal, pre-existing) and were never the blocker.Contents
migration_conflict_suppressions.yaml(+8) — the fixcontracts/OMN-13155.yaml— ModelTicketContract, 2 dod_evidence itemsdrift/dod_receipts/OMN-13155/dod-occ-suppression/command.yaml— PASS (conflict-scan before/after)drift/dod_receipts/OMN-13155/dod-delivery-pr/command.yaml— PASS (self-contained binding)contract_sha256matchessha256(contracts/OMN-13155.yaml); verifierreceipt-gate-localdistinct from runner; receipt-honesty + receipt-hardening gates pass.Scope
Unblock-only. Broader consolidation (one DB per tail table) tracked under OMN-13127.
Evidence-Source: self
Evidence-Ticket: OMN-13155
Refs OMN-13150, OMN-13127. Closes OMN-13155.