feat(OMN-13155): suppress cross-DB agent_routing_decisions duplicate

[jonahgabriel]

OMN-13155 — suppress cross-DB agent_routing_decisions duplicate (unblock OCC Migration Conflict Check)

Adds the missing agent_routing_decisions entry to migration_conflict_suppressions.yaml. This was the sole unsuppressed conflict hard-failing the OCC Migration Conflict Check job in the dev merge_group.

Diagnosis (verified, evidence-based)

agent_routing_decisions is a benign cross-DB EXACT_DUPLICATE, identical 13-column DDL, two different databases, both load-bearing:

• omnibase_infra/docker/migrations/forward/021_create_agent_routing_decisions_table.sql → creates it in the omnibase_infra DB (root forward set, $PGDB=omnibase_infra).
• omnibase_infra/docker/migrations/forward/nodes/node_projection_routing_decision/0021_create_agent_routing_decisions.sql → the omnimarket node_projection_routing_decision migration (vendored into infra's forward/nodes/, landed via OMN-13150 / infra PR evidence(OMN-12514): add SEA inference bus receipts #1985) creates the projection copy in omnidash_analytics (the node contract's declared db_io.db_tables[0].database).

The OCC checker (check-migration-conflicts) attributes both files to omnibase_infra (repos-root parts[0]) because the omnimarket node migration is vendored under the infra tree. git rm of either file breaks a database — not an option. The canonical mechanism is the suppressions file under cross_repo_shared_schema; every sibling cross-DB projection table (session_outcomes, llm_routing_decisions, llm_cost_aggregates, delegation_events, evidence_*) is already suppressed. agent_routing_decisions was simply never added when OMN-13150 introduced the second copy.

This documents an intentional cross-DB duplicate — it does not hide a real conflict.

Reproduction (exact OCC gate command)

Ran check-migration-conflicts --repos-root <repos> --check-columns --warn-columns --suppressions-file migration_conflict_suppressions.yaml against the same repo set the OCC CI clones (omniintelligence, omnibase_infra@dev, omnimemory, omniclaude, omnibase_core):

# BEFORE (current dev suppressions):
Found 1 migration conflict(s):
  EXACT_DUPLICATE: table `agent_routing_decisions`
    - omnibase_infra: 021_create_agent_routing_decisions_table.sql (13 columns)
    - omnibase_infra: 0021_create_agent_routing_decisions.sql (13 columns)
Suppressed 38 known conflict(s) via suppressions file.
-> exit 1

# AFTER (this PR):
No migration conflicts found.
Suppressed 39 known conflict(s) via suppressions file.
-> exit 0

The 36 MISSING_COLUMN findings remain as --warn-columns warnings (non-fatal, pre-existing) — they were never the blocker and are out of scope.

Scope

Unblock-only. The broader "consolidate these tables to one DB" question is tracked separately under OMN-13127 and is out of scope here.

Evidence

Evidence-Source: <OCC_RECEIPT_SHA>
Evidence-Ticket: OMN-13155

Refs OMN-13150, OMN-13127.

Summary by CodeRabbit

• Chores
  • Updated configuration to enhance consistency across internal services.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 882e8b04-eacd-4b6f-af46-d0dc35f82098

📥 Commits

Reviewing files that changed from the base of the PR and between 6d4213f and 0631d17.

📒 Files selected for processing (1)

• migration_conflict_suppressions.yaml

---

📝 Walkthrough

Walkthrough

Adds a new suppression entry to migration_conflict_suppressions.yaml for the agent_routing_decisions table, classifying it as an exact_duplicate conflict of type cross_repo_shared_schema between the omnibase_infra and omnimarket repositories, with a note describing each repo's projection target database.

Changes

Migration Conflict Suppression Config

Layer / File(s)	Summary
agent_routing_decisions suppression entry migration_conflict_suppressions.yaml	New exact_duplicate / cross_repo_shared_schema suppression entry added for agent_routing_decisions, listing omnibase_infra and omnimarket as affected repos with a descriptive multiline note.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

A rabbit hops through YAML fields so neat,
And stamps a suppression to avoid repeat,
"agent_routing_decisions," says she with a wink,
Cross-repo duplicates, no need to think!
The conflict is tamed with a note and a bow 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change: adding a suppression entry for a cross-database duplicate in agent_routing_decisions table.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch jonah/omn-13155-suppress-agent-routing-decisions-dup

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jonahgabriel]

Superseded by #2637, which is self-contained: it carries the migration_conflict_suppressions.yaml agent_routing_decisions fix AND the OCC contract + receipts (Evidence-Source: self). Folding was required because a separate delivery PR off dev fails the OCC Migration Conflict Check on the unsuppressed conflict, blocking the dev merge_group. Refs OMN-13155.