Skip to content

evidence(OMN-12829): C1 escalation contract + DoD receipts - #2358

Merged
jonahgabriel merged 2 commits into
devfrom
jonah/omn-12829-escalation-evidence
Jun 8, 2026
Merged

jonahgabriel merged 2 commits into
devfrom
jonah/omn-12829-escalation-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 8, 2026 •

Copy link
Copy Markdown
Contributor

Canonical OCC evidence for OMN-12829 (close-the-loop C1, OMN-12816B escalation). Pairs with omnimarket PR #1124 (MERGED into the B3 stack base).

Receipts (verifier != runner, real probe_stdout):

Evidence-Ticket: OMN-12829

Summary by CodeRabbit

  • Documentation

    • Added contract documentation describing escalation and error-handling behavior for validation failures, including retry budget management strategies.
  • Chores

    • Added verification records confirming compliance with contract specifications through automated testing.

@coderabbitai

coderabbitai Bot commented Jun 8, 2026 •

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 21 minutes and 38 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 41389f51-0f2b-441b-b96f-b8816fcb9c79

📥 Commits

Reviewing files that changed from the base of the PR and between 55da019 and 91df624.

📒 Files selected for processing (4)
  • contracts/OMN-12829.yaml
  • drift/dod_receipts/OMN-12829/dod-escalation-suite-green/command.yaml
  • drift/dod_receipts/OMN-12829/dod-market-pr-merged-green/command.yaml
  • drift/dod_receipts/OMN-12829/dod-occ-pr-2358/command.yaml
📝 Walkthrough

Walkthrough

This PR adds the contract specification OMN-12829.yaml for escalation behavior in node_generation_consumer when contract validation fails. The contract describes routing authority invocation with per-tier retry budgets and includes two command-based verification receipts (dod-escalation-suite-green and dod-market-pr-merged-green) proving the escalation flow passes integration and merged-PR tests.

Changes

OMN-12829 Escalation Contract and Verification

Layer / File(s) Summary
Contract specification and interface metadata
contracts/OMN-12829.yaml
Core contract metadata, behavioral summary, and interfaces touched (model events and routing/generation handlers). interface_change: true and emergency_bypass disabled.
Verification evidence and test receipts
contracts/OMN-12829.yaml, drift/dod_receipts/OMN-12829/dod-escalation-suite-green/command.yaml, drift/dod_receipts/OMN-12829/dod-market-pr-merged-green/command.yaml
Contract embeds dod_evidence with manual checks using grep probes; two command receipts record PASS status, captured pytest output (6 passed), execution timestamps, SHAs, and working directories.

🎯 2 (Simple) | ⏱️ ~8 minutes

🐰 A contract springs to life in yaml so fine,
With escalation paths and retry lines divine,
Two test receipts dance, both marking PASS,
The routing authority takes the reins at last! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically summarizes the main change: adding an escalation contract (C1) and its proof-of-delivery receipts for ticket OMN-12829, directly matching the changeset content.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12829-escalation-evidence

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-12829-escalation-evidence branch from 55da019 to 1d0a4b3 Compare June 8, 2026 22:21
Canonical OCC evidence for OMN-12829 (close-the-loop C1, OMN-12816B escalation):
the generation consumer escalates contract-validation failures through the
routing authority and emits delegation-escalation-triggered.v1.

Receipts (verifier != runner, real probe_stdout):
- dod-market-pr-merged-green: omnimarket PR #1124 MERGED, all 8 checks green.
- dod-escalation-suite-green: the C1 escalation suite is green (6 passed).

Evidence-Ticket: OMN-12829
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-12829-escalation-evidence branch from 1d0a4b3 to c520ccf Compare June 8, 2026 22:21

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@drift/dod_receipts/OMN-12829/dod-escalation-suite-green/command.yaml`:
- Around line 8-13: The contract_sha256 value in the OMN-12829 escalation-suite
receipt is wrong; update the contract_sha256 field in command.yaml for OMN-12829
to the correct hash used by contracts/OMN-12829.yaml and the
dod-market-pr-merged-green receipt:
sha256:3ba8fb09fde1ba8afd0f8f71a1780df67c95e23b0aa6e4f484773cede92413bf (locate
the contract_sha256 key in the OMN-12829 escalation-suite command.yaml and
replace the existing sha256:c984af75... value with the correct
sha256:3ba8fb09... value).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 64594a53-6a11-4f73-83b3-0eb3f8932f9b

📥 Commits

Reviewing files that changed from the base of the PR and between 74a9108 and 55da019.

📒 Files selected for processing (3)
  • contracts/OMN-12829.yaml
  • drift/dod_receipts/OMN-12829/dod-escalation-suite-green/command.yaml
  • drift/dod_receipts/OMN-12829/dod-market-pr-merged-green/command.yaml

Add dod-occ-pr-2358 self-binding receipt and align all receipt contract_sha256
to the final contract content (post-yamlfmt). Receipt Honesty Gate green.

Evidence-Ticket: OMN-12829
@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 8, 2026
Merged via the queue into dev with commit 2a23a9c Jun 8, 2026
36 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12829-escalation-evidence branch June 8, 2026 22:34
jonahgabriel added a commit that referenced this pull request Sep 7, 2026
The autobind copied the contract entry's check verbatim into
`dod-OmniNode-ai-omnimarket-pr-2358/command.supersede.3266.yaml`. That check
reads omnimarket's uv.lock at a bare commit ref and names nothing the
superseded item declares -- no path, no symbol, not the item id, and not PR
2358 -- so the Supersession Binding Ratchet (OMN-15459) refused it: "a
substantive probe of the WRONG item is still a wrong-item rebind."

Rewritten to resolve the SAME fact (the omnibase-core pin in uv.lock) through
PR #2358's OWN merge commit, so the probe both discriminates the superseded
item by its PR number and stays substantive:

    gh api repos/OmniNode-ai/omnimarket/pulls/2358 --jq .merge_commit_sha
      | xargs -I{} gh api ".../contents/uv.lock?ref={}" --jq '.content'
      | base64 -d | grep -cF '>=0.47.5,<0.48.0'

Verified live: merge_commit_sha f21152190d7c47be483ecad1ad1bc3501cfbc504,
count 2.

The baseline is NOT padded and no `corrects:` record is appended -- the check
now discriminates, which is the first remedy the gate itself names.

RED: `check_receipt_hardening.py --supersession-corpus` reports 1 NEW violation
against the frozen baseline with the autobind's version restored in place.
GREEN: "2344 violating file(s); baseline 2344. Corpus matches the frozen
baseline exactly."
jonahgabriel added a commit that referenced this pull request Sep 7, 2026
#8502)

* evidence: OCC companion pass 1 for OmniNode-ai/omnibase_infra#3266

* evidence: OCC companion self-bind for #8502

* evidence(OMN-17985): the pr-2358 rebind probes the item it supersedes

The autobind copied the contract entry's check verbatim into
`dod-OmniNode-ai-omnimarket-pr-2358/command.supersede.3266.yaml`. That check
reads omnimarket's uv.lock at a bare commit ref and names nothing the
superseded item declares -- no path, no symbol, not the item id, and not PR
2358 -- so the Supersession Binding Ratchet (OMN-15459) refused it: "a
substantive probe of the WRONG item is still a wrong-item rebind."

Rewritten to resolve the SAME fact (the omnibase-core pin in uv.lock) through
PR #2358's OWN merge commit, so the probe both discriminates the superseded
item by its PR number and stays substantive:

    gh api repos/OmniNode-ai/omnimarket/pulls/2358 --jq .merge_commit_sha
      | xargs -I{} gh api ".../contents/uv.lock?ref={}" --jq '.content'
      | base64 -d | grep -cF '>=0.47.5,<0.48.0'

Verified live: merge_commit_sha f21152190d7c47be483ecad1ad1bc3501cfbc504,
count 2.

The baseline is NOT padded and no `corrects:` record is appended -- the check
now discriminates, which is the first remedy the gate itself names.

RED: `check_receipt_hardening.py --supersession-corpus` reports 1 NEW violation
against the frozen baseline with the autobind's version restored in place.
GREEN: "2344 violating file(s); baseline 2344. Corpus matches the frozen
baseline exactly."

---------

Co-authored-by: node-occ-companion-effect <occ-companion-effect@omninode.ai>
Co-authored-by: jonahgabriel <jonah@omninode.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant