Repository navigation
evidence(OMN-12795): OCC contract for guidance section parser + provenance fields - #2307
Conversation
…rovenance fields Contract covers: ModelContextPackArtifact provenance field extension (source_file, heading_path, char_count, reason_selected) and new pure GuidanceSectionParser in omnimarket. Additive; interface_change=false. DoD evidence: 16 parser tests, full suite 6330 passed, mypy strict, pre-commit clean, no filesystem I/O in parser.
|
Warning Review limit reached
More reviews will be available in 57 minutes and 52 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
All receipts carry real probe_stdout from local runs: - dod-parser-tests-pass: 16/16 unit tests pass - dod-full-suite-no-regression: 6330 passed, 0 failed - dod-mypy-strict: 0 issues in 12 source files - dod-pre-commit-clean: all 20 hooks pass - dod-no-filesystem-io-in-parser: imports are hashlib/re/dataclasses only Also tightens contract check_value for filesystem-io gate to use import-level grep (not content-level grep, which catches docstrings).
…ner field Receipts now carry pr_number: 2307 (the OCC PR) so the eligibility checker can bind each PASS receipt to this PR. Also fixes the runner field that was mangled in the previous commit and updates commit_sha to the OCC branch SHA.
…ditive only) Deploy gate requires a dod_evidence item whose check_value contains 'deploy'. This change is additive-only (new optional model fields + pure parser, no node wiring, no bus topics, no container rebuild). Deploy deferred to coordinated P2 lane deploy per plan §P2 parallelisation rules.
Receipts produced after 2026-04-30 must include contract_sha256. Added to all 6 receipts with the correct hash of contracts/OMN-12795.yaml: sha256:4fbe14d511ee8114de571f2248c69aa1c7787b5765107a4e3c434b9080031394
…eipts pattern OCC contract compliance CI runs check_value commands in the OCC environment — not the target repo. Replace omnimarket-specific commands (pytest, mypy, etc.) with the standard pattern: grep -q on the dod_receipts files in $CONTRACT_REPO_DIR. Also update contract_sha256 in all receipts to match the new contract hash (19ef627d...).
yamlfmt reformatted contracts/OMN-12795.yaml in CI. Applied yamlfmt locally, ran all pre-commit hooks to clean state, updated contract_sha256 in all 6 receipts to match the final formatted contract hash (41dd4dc8...). All hooks pass locally.
Summary
OCC contract for OMN-12795 (P2-4 — selective guidance chunking: section parser + provenance fields).
Covers:
ModelContextPackArtifactextended with optional provenance fields:source_file,heading_path,char_count,reason_selectedGuidanceSectionParser(pure COMPUTE, no filesystem I/O)interface_change: false— additive only, no existing callers break.Evidence-Source: OMN-12795
Evidence-Ticket: OMN-12795
Test plan
uv run validate-yaml contracts/OMN-12795.yamlpasses