Skip to content

docs(OMN-12636): OCC contracts + DoD receipts for dirty-canonical sweep fixes (also OMN-12635) - #2119

Closed
jonahgabriel wants to merge 4 commits into
devfrom
jonah/omn-12636-occ-contract-receipts
Closed

jonahgabriel wants to merge 4 commits into
devfrom
jonah/omn-12636-occ-contract-receipts

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 3, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Central OCC ticket contracts and PASS DoD receipts backing omnimarket PR #1023 (merged), which fixes two bugs in node_dirty_canonical_sweep (HandlerDirtyCanonicalSweep, epic OMN-7466 / skill /onex:ship_dirty_canonical).

  • OMN-12636 (primary) — stale-base diff: the rescue worktree was branched from origin/<base> (dev) instead of the canonical clone's actual HEAD, so when the clone was behind dev the copy reverted already-merged dev commits and produced a regressive partial PR (observed 2026-06-03: omnibase_infra 20 commits behind dev -> PR evidence(OMN-10409): bind receipt contract hashes #1845, 11 of 31 files, +50/-329, closed and re-shipped as evidence(OMN-10409): record final manual merge sweep #1846). Fix branches the worktree from git rev-parse HEAD.
  • OMN-12635 (paired, same omnimarket PR) — untracked-directory crash: the copy loop called read_bytes() on a dirty directory entry (e.g. evidence/OMN-12584/), raising [Errno 21] Is a directory and failing the ship (observed on onex_change_control, shipped manually). Fix recurses directory entries with rglob.

Artifacts

  • contracts/OMN-12636.yaml, contracts/OMN-12635.yaml — validate against ModelTicketContract.
  • drift/dod_receipts/OMN-12636/{dod-tdd-reproduction,dod-full-suite-green,dod-occ-pr-self}/command.yaml — all status: PASS.
  • drift/dod_receipts/OMN-12635/{dod-tdd-reproduction,dod-occ-pr-self}/command.yaml — all status: PASS.

The dod-occ-pr-self receipts bind to this PR (#2119) for OCC self-eligibility. Each receipt's contract_sha256 matches the committed (yamlfmt-canonical) contract hash.

Evidence-Ticket: OMN-12636
Evidence-Ticket: OMN-12635

@coderabbitai

coderabbitai Bot commented Jun 3, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 17 minutes and 8 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9026d47d-d03c-4051-9523-1c57038e051d

📥 Commits

Reviewing files that changed from the base of the PR and between 49a230e and 1e53582.

📒 Files selected for processing (3)
  • contracts/OMN-12635.yaml
  • drift/dod_receipts/OMN-12635/dod-occ-pr-self/command.yaml
  • drift/dod_receipts/OMN-12635/dod-tdd-reproduction/command.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12636-occ-contract-receipts

Comment @coderabbitai help to get the list of available commands and usage tips.

… sweep fixes (also OMN-12635)

Carries the OCC ticket contracts and PASS DoD receipts that back omnimarket
PR #1023, which fixes two bugs in node_dirty_canonical_sweep
(HandlerDirtyCanonicalSweep, epic OMN-7466 / skill /onex:ship_dirty_canonical):

- OMN-12636 (primary): rescue worktree branched from origin/<base> instead of
  the canonical clone HEAD, producing regressive partial PRs when the clone is
  behind dev. Fix branches from `git rev-parse HEAD`.
- OMN-12635 (paired): copy loop crashed on untracked directories
  (read_bytes IsADirectoryError). Fix recurses directory entries.

Receipts (status: PASS) under drift/dod_receipts/OMN-12636/ and
drift/dod_receipts/OMN-12635/ record the TDD red->green reproduction, the
full-suite-green run, and the OCC-PR self-binding. This OCC PR head is the
Evidence-Source for omnimarket PR #1023.
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-12636-occ-contract-receipts branch from 79e4e7e to 3ac079c Compare June 3, 2026 15:48
@jonahgabriel
jonahgabriel changed the base branch from main to dev June 3, 2026 15:48
@jonahgabriel
jonahgabriel enabled auto-merge June 3, 2026 15:50
@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Superseded by #2139.

Reason: this branch still carries historical OMN-12636 commit metadata, while current dev already has the newer OMN-12636 OCC contract/receipts from the merged evidence path. The OCC eligibility validator correctly fails this PR because no OMN-12636 receipt binds to PR #2119. Rather than rewriting this branch or adding redundant OMN-12636 self-evidence, #2139 reopens the remaining missing piece as a clean OMN-12635-only PR from current dev with local OCC eligibility passing.

@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Closed as superseded by #2139.

auto-merge was automatically disabled June 4, 2026 01:17

Pull request was closed

@jonahgabriel
jonahgabriel deleted the jonah/omn-12636-occ-contract-receipts branch June 11, 2026 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant