Repository navigation
docs(OMN-12636): OCC contracts + DoD receipts for dirty-canonical sweep fixes (also OMN-12635) - #2119
jonahgabriel wants to merge 4 commits into
Conversation
|
Warning Review limit reached
More reviews will be available in 17 minutes and 8 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
… sweep fixes (also OMN-12635) Carries the OCC ticket contracts and PASS DoD receipts that back omnimarket PR #1023, which fixes two bugs in node_dirty_canonical_sweep (HandlerDirtyCanonicalSweep, epic OMN-7466 / skill /onex:ship_dirty_canonical): - OMN-12636 (primary): rescue worktree branched from origin/<base> instead of the canonical clone HEAD, producing regressive partial PRs when the clone is behind dev. Fix branches from `git rev-parse HEAD`. - OMN-12635 (paired): copy loop crashed on untracked directories (read_bytes IsADirectoryError). Fix recurses directory entries. Receipts (status: PASS) under drift/dod_receipts/OMN-12636/ and drift/dod_receipts/OMN-12635/ record the TDD red->green reproduction, the full-suite-green run, and the OCC-PR self-binding. This OCC PR head is the Evidence-Source for omnimarket PR #1023.
79e4e7e to
3ac079c
Compare
|
Superseded by #2139. Reason: this branch still carries historical OMN-12636 commit metadata, while current |
|
Closed as superseded by #2139. |
Pull request was closed
Summary
Central OCC ticket contracts and PASS DoD receipts backing omnimarket PR #1023 (merged), which fixes two bugs in
node_dirty_canonical_sweep(HandlerDirtyCanonicalSweep, epic OMN-7466 / skill/onex:ship_dirty_canonical).origin/<base>(dev) instead of the canonical clone's actual HEAD, so when the clone was behind dev the copy reverted already-merged dev commits and produced a regressive partial PR (observed 2026-06-03: omnibase_infra 20 commits behind dev -> PR evidence(OMN-10409): bind receipt contract hashes #1845, 11 of 31 files, +50/-329, closed and re-shipped as evidence(OMN-10409): record final manual merge sweep #1846). Fix branches the worktree fromgit rev-parse HEAD.read_bytes()on a dirty directory entry (e.g.evidence/OMN-12584/), raising[Errno 21] Is a directoryand failing the ship (observed on onex_change_control, shipped manually). Fix recurses directory entries withrglob.Artifacts
contracts/OMN-12636.yaml,contracts/OMN-12635.yaml— validate againstModelTicketContract.drift/dod_receipts/OMN-12636/{dod-tdd-reproduction,dod-full-suite-green,dod-occ-pr-self}/command.yaml— allstatus: PASS.drift/dod_receipts/OMN-12635/{dod-tdd-reproduction,dod-occ-pr-self}/command.yaml— allstatus: PASS.The
dod-occ-pr-selfreceipts bind to this PR (#2119) for OCC self-eligibility. Each receipt'scontract_sha256matches the committed (yamlfmt-canonical) contract hash.Evidence-Ticket: OMN-12636
Evidence-Ticket: OMN-12635