evidence(OMN-10998): bind omniclaude PR 1587 by jonahgabriel · Pull Request #1023 · OmniNode-ai/onex_change_control

jonahgabriel · 2026-05-15T12:10:23Z

Summary

Add central OCC contract for OMN-10998 / omniclaude#1587.
Add PASS DoD receipts for PR head binding, direct import proof, focused delegation tests, live LLM skip, ruff/diff checks, and OCC self-binding.
Add compact evidence report under evidence/OMN-10998.

Validation

uv run validate-yaml contracts/OMN-10998.yaml
uv run python scripts/check_dod_evidence_present.py contracts/OMN-10998.yaml
uv run python scripts/lint_contract_check_values.py contracts/OMN-10998.yaml
uv run pytest tests/test_dod_evidence_schema.py tests/test_validate_yaml_cli.py -q -> 50 passed
uv run python receipt parser for drift/dod_receipts/OMN-10998 -> PASS
pre-commit run --files -> passed
commit hooks passed
push hooks passed

Implementation proofs re-run in omniclaude worktree:

direct import proof -> PASS
uv run pytest tests/delegation/test_e2e_smoke.py tests/delegation/test_e2e_inprocess_wiring.py -q -> 7 passed, 13 skipped
uv run pytest tests/delegation/test_e2e_live_llm.py -q -> 1 skipped
uv run ruff check src/omniclaude/delegation/inprocess_runner.py tests/delegation/test_e2e_smoke.py -> All checks passed
git diff --check -> clean

Evidence-Source candidate for omniclaude#1587: onex_change_control PR #1023 at commit 437adfa.

Summary by CodeRabbit

Chores
- Added infrastructure contract and verification evidence artifacts for internal quality assurance tracking and compliance documentation.

coderabbitai · 2026-05-15T12:10:29Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: a3561b33-3ed3-44a7-bbf8-79fe5164ddeb

📥 Commits

Reviewing files that changed from the base of the PR and between 9e9cf1e and 437adfa.

📒 Files selected for processing (8)

contracts/OMN-10998.yaml
drift/dod_receipts/OMN-10998/dod-focused-delegation-tests/command.yaml
drift/dod_receipts/OMN-10998/dod-import-proof/command.yaml
drift/dod_receipts/OMN-10998/dod-live-llm-skip/command.yaml
drift/dod_receipts/OMN-10998/dod-occ-pr-self/command.yaml
drift/dod_receipts/OMN-10998/dod-omniclaude-pr-1587/command.yaml
drift/dod_receipts/OMN-10998/dod-ruff-diff-check/command.yaml
evidence/OMN-10998/dod_report.json

📝 Walkthrough

Walkthrough

This PR adds a complete seam ticket contract (OMN-10998) for cleaning up omniclaude stale delegation imports, along with evidence receipts proving all required DOD checks have passed and a summary report of verification results.

Changes

OMN-10998 Contract and Verification

Layer / File(s)	Summary
Contract definition and DOD requirements `contracts/OMN-10998.yaml`	Defines ticket metadata, binds to omniclaude PR `#1587`, specifies manual/test evidence requirements, and lists five DOD receipt checks: PR head verification, import proof, focused delegation tests, live-LLM skip, and lint validation.
DOD evidence receipt records `drift/dod_receipts/OMN-10998/dod-occ-pr-self/command.yaml`, `drift/dod_receipts/OMN-10998/dod-import-proof/command.yaml`, `drift/dod_receipts/OMN-10998/dod-focused-delegation-tests/command.yaml`, `drift/dod_receipts/OMN-10998/dod-live-llm-skip/command.yaml`, `drift/dod_receipts/OMN-10998/dod-ruff-diff-check/command.yaml`, `drift/dod_receipts/OMN-10998/dod-omniclaude-pr-1587/command.yaml`	Five command-type evidence files record verification results with PASS status, execution timestamps, runner/verifier identifiers, probe commands and captured output, and contract SHA-256 digests; delegat ion tests show 7 passed/13 skipped, live-LLM shows 1 skipped.
Evidence aggregation report `evidence/OMN-10998/dod_report.json`	Summarizes overall status as pass, references PR `#1587` as open, and aggregates counts: 5 verified, 0 failed, 1 skipped test, with per-check evidence array documenting each result.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A ticket born, with evidence in tow,
Five checks all passing, a verdant glow,
No failures here, just tests that skipped,
Our contracts signed, our proofs well-whipped!
✨

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title clearly and concisely summarizes the main change: binding omniclaude PR 1587 evidence to the OMN-10998 contract, which is the primary purpose of this changeset.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch jonah/omn-10998-omniclaude-1587-occ

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

…tive-evidence diffs Adds a `zone-filter` job at the head of ci.yml that calls the reusable workflow shipped in omnibase_core (OmniNode-ai/omnibase_core/.github/ workflows/zone-filter.yml@main). Two heavy jobs gain `needs: zone-filter` plus `if: needs.zone-filter.outputs.docs_only != 'true'`: - type-check (mypy on src/ + tests/) - test (pytest with coverage) `pre-commit`, `ai-slop-check`, `context-integrity-contracts`, `migration-conflicts`, `migration-inventory`, `kafka-boundary-parity`, `cross-repo-null-contract`, `seam-contract-coverage`, `validate-contracts`, `contract-sync-gate`, and `contract-compliance` continue to run on every PR. `schema-purity` previously hard-required `needs: [test, contract-compliance]` without a fallback; relaxed its `if:` to also pass when test was skipped by zone-filter (`always() && contract-compliance == success && (test == success || test == skipped)`). The pre-existing `ci-summary` aggregator already uses `contains(needs.*.result, 'failure' || 'cancelled')` which treats `skipped` as success-equivalent. This is the highest-leverage caller in the ecosystem: most OCC traffic is contract+receipt YAML in `contracts/` and `drift/dod_receipts/`, both DOCS zone after OMN-10475. PRs that previously triggered the full mypy + pytest matrix will now skip both. DOCS zone now covers `docs/`, `standards/`, plus `contracts/`, `drift/dod_receipts/`, `allowlists/`, `.evidence/` (per OMN-10475 — see omnibase_core PR #1023).

* ci(OMN-10475): wire zone-filter caller — skip heavy matrix on declarative-evidence diffs Adds a `zone-filter` job at the head of ci.yml that calls the reusable workflow shipped in omnibase_core (OmniNode-ai/omnibase_core/.github/ workflows/zone-filter.yml@main). Two heavy jobs gain `needs: zone-filter` plus `if: needs.zone-filter.outputs.docs_only != 'true'`: - type-check (mypy on src/ + tests/) - test (pytest with coverage) `pre-commit`, `ai-slop-check`, `context-integrity-contracts`, `migration-conflicts`, `migration-inventory`, `kafka-boundary-parity`, `cross-repo-null-contract`, `seam-contract-coverage`, `validate-contracts`, `contract-sync-gate`, and `contract-compliance` continue to run on every PR. `schema-purity` previously hard-required `needs: [test, contract-compliance]` without a fallback; relaxed its `if:` to also pass when test was skipped by zone-filter (`always() && contract-compliance == success && (test == success || test == skipped)`). The pre-existing `ci-summary` aggregator already uses `contains(needs.*.result, 'failure' || 'cancelled')` which treats `skipped` as success-equivalent. This is the highest-leverage caller in the ecosystem: most OCC traffic is contract+receipt YAML in `contracts/` and `drift/dod_receipts/`, both DOCS zone after OMN-10475. PRs that previously triggered the full mypy + pytest matrix will now skip both. DOCS zone now covers `docs/`, `standards/`, plus `contracts/`, `drift/dod_receipts/`, `allowlists/`, `.evidence/` (per OMN-10475 — see omnibase_core PR #1023). * evidence(OMN-10475): bind OCC PR 1127

… sweep fixes (also OMN-12635) Carries the OCC ticket contracts and PASS DoD receipts that back omnimarket PR #1023, which fixes two bugs in node_dirty_canonical_sweep (HandlerDirtyCanonicalSweep, epic OMN-7466 / skill /onex:ship_dirty_canonical): - OMN-12636 (primary): rescue worktree branched from origin/<base> instead of the canonical clone HEAD, producing regressive partial PRs when the clone is behind dev. Fix branches from `git rev-parse HEAD`. - OMN-12635 (paired): copy loop crashed on untracked directories (read_bytes IsADirectoryError). Fix recurses directory entries. Receipts (status: PASS) under drift/dod_receipts/OMN-12636/ and drift/dod_receipts/OMN-12635/ record the TDD red->green reproduction, the full-suite-green run, and the OCC-PR self-binding. This OCC PR head is the Evidence-Source for omnimarket PR #1023.

…sable workflow (OmniNode-ai#637) Paired contract+evidence for omnibase_core PR OmniNode-ai#1023, which extracts the zone-filter as a reusable GitHub Actions workflow and expands zone_classifier._DOCS_PREFIXES to also cover contracts/, drift/dod_receipts/, allowlists/, .evidence/. Four DoD evidence receipts proving the omnibase_core PR is green locally: - dod-001: pytest of zone_classifier (17) + zone_diff_filter (5) — 22/22 pass - dod-002: ruff check + ruff format --check on the touched files — clean - dod-003: mypy --strict on src/omnibase_core/validation/zone_classifier.py - dod-004: pre-commit run --files on the four touched files in PR OmniNode-ai#1023 All receipts captured against commit a8c3ef488ee82fb9c4583d492417caca9a2fa5fa (jonah/zone-filter-reusable-workflow HEAD), runner: zone-deployer, exit_code 0.

evidence(OMN-10998): bind omniclaude PR 1587

437adfa

jonahgabriel force-pushed the jonah/omn-10998-omniclaude-1587-occ branch from aa84339 to 437adfa Compare May 15, 2026 12:13

Merge branch 'main' into jonah/omn-10998-omniclaude-1587-occ

9a8ed68

jonahgabriel merged commit c42c761 into main May 15, 2026
29 checks passed

jonahgabriel deleted the jonah/omn-10998-omniclaude-1587-occ branch May 15, 2026 12:29

jonahgabriel mentioned this pull request May 20, 2026

evidence(OMN-10151,OMN-10475): bind OCC receipt gates #1202

Merged

jonahgabriel mentioned this pull request Jun 3, 2026

docs(OMN-12636): OCC contracts + DoD receipts for dirty-canonical sweep fixes (also OMN-12635) #2119

Closed

This was referenced Jun 3, 2026

contracts(OMN-12636,OMN-11599): bind dod evidence for merged dev work #2132

Merged

docs(OMN-12635): add OCC contract and receipts for dirty-directory sweep fix #2139

Merged

Navigation Menu

Repository navigation

evidence(OMN-10998): bind omniclaude PR 1587 - #1023

evidence(OMN-10998): bind omniclaude PR 1587#1023
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-10998-omniclaude-1587-occ

jonahgabriel commented May 15, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 15, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

jonahgabriel commented May 15, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jonahgabriel commented May 15, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 15, 2026 •

edited

Loading