Repository navigation
evidence(OMN-12420): dod receipts for node_dod_verify envelope-unwrap fix - #1853
Merged
jonahgabriel merged 4 commits intoMay 29, 2026
Merged
Conversation
|
Warning Review limit reached
More reviews will be available in 12 minutes and 37 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
… fix Binds the omnimarket node_dod_verify dispatch fix to central OCC evidence. dod-001: regression test proves the wrapped envelope run-node publishes is unwrapped by the runtime dispatch callback, validated against ModelDodVerifyStartCommand with no ValidationError, returning a ModelDispatchResult carrying the terminal ModelDodVerifyState. dod-002: the node CLI writes a guard-valid ModelDodReceipt dod_report.json to $ONEX_EVIDENCE_ROOT/OMN-12420/ (run_timestamp + status=PASS). dod-deploy-assessment: honest deploy assessment — touches a runtime path and requires a stability-test runtime redeploy to take effect on the deployed 0.4.2 container; redeploy is the documented follow-up (live deploy, user-gated). Receipt-gate validator passes locally: 3 checks across 1 ticket all PASS.
jonahgabriel
force-pushed
the
jonahgabriel/omn-12420-dod-verify-receipt-evidence
branch
from
May 29, 2026 12:38
93093f9 to
023e3f8
Compare
Receipts produced after 2026-04-30 must record the contract hash. Adds contract_sha256 to all four OMN-12420 receipts to satisfy the receipt-gate contract-hash binding check.
…ter) The contract_sha256 insertion had landed inside the wrapped check_value string, producing invalid YAML. Rewritten cleanly; all four receipts parse with status=PASS and contract_sha256 present.
jonahgabriel
added this pull request to the merge queue
May 29, 2026
jonahgabriel
deleted the
jonahgabriel/omn-12420-dod-verify-receipt-evidence
branch
May 29, 2026 12:57
jonahgabriel
added a commit
that referenced
this pull request
Jul 4, 2026
…on for Done-flip) The omniclaude DoD Evidence Check reads a committed .onex_state/evidence/ OMN-13914/dod_report.json to permit the OMN-13914 Done-flip. omniclaude PR #1853 commits that receipt but its receipt-gate needs a PASS receipt binding PR #1853. Add net-new dod-omniclaude-pr-1853 evidence item + receipt. Existing receipts' contract_sha256 rebound to the mutated whole-file hash (OMN-13888 whole-file-hash cascade), values only — no other receipt edits. Mirrors merged precedent OCC #3563 (OMN-13886 add-deploy-evidence).
jonahgabriel
added a commit
that referenced
this pull request
Jul 4, 2026
…on for Done-flip) The omniclaude DoD Evidence Check reads a committed .onex_state/evidence/ OMN-13914/dod_report.json to permit the OMN-13914 Done-flip. omniclaude PR #1853 commits that receipt but its receipt-gate needs a PASS receipt binding PR #1853. Add net-new dod-omniclaude-pr-1853 evidence item + receipt. Existing receipts' contract_sha256 rebound to the mutated whole-file hash (OMN-13888 whole-file-hash cascade), values only — no other receipt edits. Mirrors merged precedent OCC #3563 (OMN-13886 add-deploy-evidence).
jonahgabriel
added a commit
that referenced
this pull request
Oct 12, 2026
Appends dod_evidence item dod-omn19984-pr1853-c32-auth-cases-tests to contracts/OMN-19984.yaml, binding AC1. Adds PASS receipt at drift/dod_receipts/OMN-19984/dod-omn19984-pr1853-c32-auth-cases-tests/command.yaml with pr_number 1853 and commit_sha e07c89ad4ddcac22ec05858a848b1486fbc63777. Captured with check_receipt_hardening.py --capture-probe: 104 passed, exit 0. Reason: occ-preflight on omninode_infra#1853 failed pr_ticket_mismatch because OCC#13449 bound OMN-19984 only by self-bind and no PASS receipt bound PR #1853.
jonahgabriel
added a commit
that referenced
this pull request
Oct 12, 2026
…3472) * evidence(OMN-19984): add C32 auth cases PASS receipt for PR #1853 Appends dod_evidence item dod-omn19984-pr1853-c32-auth-cases-tests to contracts/OMN-19984.yaml, binding AC1. Adds PASS receipt at drift/dod_receipts/OMN-19984/dod-omn19984-pr1853-c32-auth-cases-tests/command.yaml with pr_number 1853 and commit_sha e07c89ad4ddcac22ec05858a848b1486fbc63777. Captured with check_receipt_hardening.py --capture-probe: 104 passed, exit 0. Reason: occ-preflight on omninode_infra#1853 failed pr_ticket_mismatch because OCC#13449 bound OMN-19984 only by self-bind and no PASS receipt bound PR #1853. * evidence(OMN-18921): mint the owed OCC self-bind for PR #13472 * evidence(OMN-18921): mint the owed OCC self-bind for PR #13472 --------- Co-authored-by: onexbot-occ-writer[bot] <onexbot-occ-writer[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Central OCC evidence binding the omnimarket
node_dod_verifydispatch envelope-unwrap fix (OMN-12420) to PASS DoD receipts so the omnimarket PR's Receipt Gate can resolve them viaEvidence-Source.Evidence
test_dispatch_envelope_unwrap.pyproves the exact wrapped envelopeonex run-nodepublishes is unwrapped by the runtime dispatch callback (built with the contract'sevent_model), validated againstModelDodVerifyStartCommandwith no ValidationError, and returns aModelDispatchResultcarrying the terminalModelDodVerifyState(which the runtimeDispatchResultApplierpublishes todod-verify-completed.v1).ModelDodReceiptdod_report.jsonto$ONEX_EVIDENCE_ROOT/OMN-12420/(run_timestamp + status=PASS).Receipt-gate validator (
validator_receipt_gate_cli) passes locally: 2 checks across 1 ticket all PASS.Pairs with omnimarket PR for OMN-12420.
Closes OMN-12420