Skip to content

contracts(OMN-11970): refresh cleanup receipts - #1590

Merged
jonahgabriel merged 1 commit into
mainfrom
jonah/omn-11970-11971-refresh-occ-receipts
May 25, 2026
Merged

jonahgabriel merged 1 commit into
mainfrom
jonah/omn-11970-11971-refresh-occ-receipts

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 25, 2026 •

Copy link
Copy Markdown
Contributor

Evidence-Source: 7ce91f1a2d1af5f086359e29f198d1f4912e8368
Evidence-Ticket: OMN-11970

Summary

Verification

  • uv run python scripts/check_dod_evidence_present.py OMN-11970 OMN-11971
  • uv run pre-commit run --files contracts/OMN-11970.yaml drift/dod_receipts/OMN-11970/dod-omniclaude-pr-1653/command.yaml drift/dod_receipts/OMN-11971/dod-omniintelligence-pr-671/command.yaml

Summary by CodeRabbit

  • Chores
    • Updated internal configuration and verification records with refreshed metadata and corrected references.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 25, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've used your available PR reviews for now.

Your plan includes 5 reviews of capacity. Refill in 46 minutes and 56 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4fba0611-ee67-4c87-b313-333f0ba18559

📥 Commits

Reviewing files that changed from the base of the PR and between cfd7146 and 72cdff1.

📒 Files selected for processing (5)
  • contracts/OMN-11970.yaml
  • drift/dod_receipts/OMN-11970/dod-deploy-assessment/command.yaml
  • drift/dod_receipts/OMN-11970/dod-occ-pr-1590/command.yaml
  • drift/dod_receipts/OMN-11970/dod-omniclaude-pr-1653/command.yaml
  • drift/dod_receipts/OMN-11971/dod-omniintelligence-pr-671/command.yaml
📝 Walkthrough

Walkthrough

This PR updates contract definitions and test evidence receipts across two tickets to document a model name resolution infrastructure change. The contract now validates against PR 1653, and test receipts reflect model-name resolution via explicit OMNICLAUDE_TRANSITION_SELECTOR_MODEL_NAME environment variable with fail-loud behavior, with refreshed execution metadata across all evidence artifacts.

Changes

Model Name Resolution Infrastructure

Layer / File(s) Summary
Contract definition and evidence updates
contracts/OMN-11970.yaml, drift/dod_receipts/OMN-11970/dod-deploy-assessment/command.yaml, drift/dod_receipts/OMN-11970/dod-omniclaude-pr-1653/command.yaml, drift/dod_receipts/OMN-11971/dod-omniintelligence-pr-671/command.yaml
Contract OMN-11970 updates PR validation from 1570 to 1653 and deploy-assessment description to reference explicit overlay environment variable resolution. Deploy-assessment, omniclaude-pr-1653, and omniintelligence-pr-671 receipts are refreshed with new run metadata and check values reflecting OMNICLAUDE_TRANSITION_SELECTOR_MODEL_NAME environment variable resolution with fail-loud behavior.

Estimated Code Review Effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 The overlay calls out, fail-loud and clear,
Model names dance in environment here,
From registry chains to explicit ways,
Contracts and receipts align their days,
One sixty-three-five validates the cheer! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: refreshing OCC (OmniNode Change Control) receipts for tickets OMN-11970 and OMN-11971, which matches the primary objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11970-11971-refresh-occ-receipts

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-11970-11971-refresh-occ-receipts branch from c334983 to cfd7146 Compare May 25, 2026 00:42
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-11970-11971-refresh-occ-receipts branch from cfd7146 to 72cdff1 Compare May 25, 2026 00:51
@jonahgabriel
jonahgabriel merged commit 509ae56 into main May 25, 2026
33 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11970-11971-refresh-occ-receipts branch May 25, 2026 01:00
andywu42 pushed a commit to andywu42/onex_change_control that referenced this pull request Jun 10, 2026
…iNode-ai#1590 (OmniNode-ai#1002)

* contract(OMN-10954): bind omnibase_infra savings/POSTGRES_HOST PR OmniNode-ai#1590

Add OCC contract OMN-10954.yaml and dod_evidence receipts for the
omnibase_infra PR that unblocks .201 runtime boot:
- dod-omnibase-infra-pr-1590: binds the downstream fix PR
- dod-occ-pr-self: self-binding so this OCC PR satisfies the
  receipt-gate Evidence-Source check on PR OmniNode-ai#1590

OMN-10954

* fix(OMN-10954): satisfy receipt-gate schema on dod-occ-pr-self

Receipt-gate rejected commit_sha="self-binding" (must be 7-40 hex chars)
and pr_number=0 (must be >= 1). Aligns with the OCC self-binding receipt
convention used in OMN-10789/10793 (short SHA + real OCC PR number).

Unblocks omnibase_infra#1590.

OMN-10954

Evidence-Source: OCC#self
Evidence-Ticket: OMN-10954
jonahgabriel added a commit that referenced this pull request Jul 3, 2026
…amp contract_sha256

Fixes the pr_ticket_mismatch that blocked BOTH omnimarket PR #1594 (occ-preflight/eligibility,
verify) and this OCC PR #3551 (self-eligibility): the OMN-13501 contract declared evidence only
for PR #1590/#3537, so the receipt-gate eligibility loop (which iterates contract-declared
dod_evidence items) never checked the net-new burn-down receipts and found no PR-#1594/#3551-bound
PASS receipt.

- Append two dod_evidence items to contracts/OMN-13501.yaml: dod-omnimarket-pr-1594 (binds code
  PR #1594) and dod-occ-3551-self-binding (binds this OCC PR #3551).
- Whole-file contract hash changes on append (f63451bb -> 05ecb897), so re-stamp contract_sha256
  in all six receipts to the new hash — the exact pattern merged OCC #3537 used when it added the
  deploy-assessment evidence item. Receipt semantics are unchanged; only the hash pointer updates.

Verified locally with validator_occ_merge_eligibility: PR#3551 and PR#1594 both eligible=True
(present, PASS, hash-bound, PR-bound). yamlfmt idempotent; all OCC pre-commit gates pass
(Receipt Honesty Gate, Receipt Hardening Gate, dod_evidence required, contract YAML schema).

Evidence-Ticket: OMN-13501
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant