Repository navigation
evidence(OMN-11982): Wave 2 OCC contracts and receipts for knowledge platform PRs - #1580
Merged
Merged
Conversation
…tform PRs Adds contracts and DoD receipts for three knowledge platform tickets that are blocking omniclaude PRs #1650, #1651, and #1652: - OMN-11938: recall skill --scope flag and knowledge federation (omniclaude #1650) - OMN-11940: design_to_plan Phase 0 knowledge preload (omniclaude #1651) - OMN-11941: ticket-work research enrichment documentation (omniclaude #1652) Lane 1 (LLM topology) and Lane 5 (hardcoded model cleanup) are already covered by prior merged OCC PRs (#1570 OMN-11970, #1569 OMN-11971).
|
Warning Review limit reached
Your plan includes 5 reviews of capacity. Refill in 54 minutes and 50 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThis pull request adds four new ticket contract definitions with supporting verification receipts. Each ticket is registered as a contract YAML with metadata, feature flags, and references to DoD evidence, paired with corresponding command-based receipt files that confirm verification status via ChangesTicket Contracts and Evidence Receipts
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
enabled auto-merge (squash)
May 24, 2026 23:35
Add contracts/OMN-11982.yaml and receipt so the OCC eligibility check passes for this PR. The receipt gate requires every OCC PR to have its own ticket contract present at the pinned commit SHA.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-11938/dod-omniclaude-pr-1650/command.yaml`:
- Line 10: Replace the placeholder value for contract_sha256 with the actual
SHA-256 digest of the final PR-head contract file; compute the SHA-256 hash of
contracts/OMN-11938.yaml and update the command.yaml field contract_sha256:
"sha256:<actual-digest>" so the receipt’s contract_sha256 matches the final
contract content referenced by contracts/OMN-11938.yaml.
In `@drift/dod_receipts/OMN-11940/dod-omniclaude-pr-1651/command.yaml`:
- Line 10: Replace the placeholder contract_sha256 value with the actual SHA-256
digest of the final contract file; compute the SHA-256 hash of
contracts/OMN-11940.yaml from the PR head commit and update the contract_sha256
field in command.yaml (replace "sha256:pending" with "sha256:<actual-digest>")
so the receipt matches the contract content exactly.
In `@drift/dod_receipts/OMN-11941/dod-omniclaude-pr-1652/command.yaml`:
- Line 10: The contract_sha256 field in command.yaml must be replaced with the
actual SHA-256 digest of the PR-head contract file; compute the SHA-256 hash of
contracts/OMN-11941.yaml (the final content in this PR) and update the
contract_sha256 value (currently "sha256:pending") with the computed value
prefixed by "sha256:". Ensure the checksum exactly matches the file bytes used
in the PR so the associated receipt's contract_sha256 equals the contract YAML
hash.
In `@drift/dod_receipts/OMN-11982/dod-occ-pr-1580/command.yaml`:
- Line 10: Replace the placeholder value of contract_sha256 in command.yaml with
the actual SHA-256 digest of the OMN-11982 contract file (OMN-11982.yaml) from
this branch's head commit: compute the file's SHA-256 (e.g., checkout the PR
head and run a sha256 tool against OMN-11982.yaml) and set contract_sha256 to
"sha256:<hex>" (matching the computed hex); ensure the hex matches exactly and
save the updated command.yaml so contract_sha256 and the OMN-11982 contract file
are in sync.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 5e91085f-37cd-4d38-b9f2-4143adb38208
📒 Files selected for processing (8)
contracts/OMN-11938.yamlcontracts/OMN-11940.yamlcontracts/OMN-11941.yamlcontracts/OMN-11982.yamldrift/dod_receipts/OMN-11938/dod-omniclaude-pr-1650/command.yamldrift/dod_receipts/OMN-11940/dod-omniclaude-pr-1651/command.yamldrift/dod_receipts/OMN-11941/dod-omniclaude-pr-1652/command.yamldrift/dod_receipts/OMN-11982/dod-occ-pr-1580/command.yaml
The ModelDodReceipt validator requires contract_sha256 to be a real sha256:<64-hex> digest. Update all four receipts with actual file hashes computed from the contract YAML files in this PR.
andywu42
pushed a commit
to andywu42/onex_change_control
that referenced
this pull request
Jun 10, 2026
…-ai#987) * contract(OMN-10930): ruff to rdjsonl converter OCC contract * receipt(OMN-10930): add dod receipt for omniclaude PR OmniNode-ai#1580 * contract(OMN-10930): bind OCC receipt PR * contract(OMN-10930): use neutral OCC receipt workdir
jake-b-omni
added a commit
that referenced
this pull request
Sep 19, 2026
Eligibility on this PR needs a receipt naming this PR, the same way #1580 needs one naming #1580. The parity receipt carries it: its measurement is about the hotfix branch this companion evidences. No contract entry changes. Refs: OMN-18601 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P5jA4UseYGEptrKijm4X9g
jake-b-omni
added a commit
that referenced
this pull request
Sep 19, 2026
…ane that gate reads (#10440) * fix(OMN-18601): bind the PSA evidence to omninode_infra#1580 on the lane that gate reads The eligibility gate on omninode_infra#1580 refused with pr_ticket_mismatch: all nine OMN-18601 receipts resolve and PASS, but none binds the PR under review. For a product-repo PR that binding is the PRODUCT repo's number, not the OCC companion's. occ-autobind did mint pr-1580 receipts, in OCC#10439, but merged them to this repository's DEV lane. A hotfix targeting omninode_infra main pins its evidence at OCC MAIN — the failing run recorded occ_commit_sha 4841460, main's head — and the two lanes carry different OMN-18601 contracts, so the dev-side binding is invisible from the lane being read. The test-suite receipt is the honest owner of the field: that suite was run on #1580's branch. No contract entry changes, so every contract_entry_sha256 on this lane stays valid and the whole-file hash is untouched. Refs: OMN-18601, OMN-18089 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P5jA4UseYGEptrKijm4X9g * chore(OMN-18601): self-bind this companion to OCC#10440 Eligibility on this PR needs a receipt naming this PR, the same way #1580 needs one naming #1580. The parity receipt carries it: its measurement is about the hotfix branch this companion evidences. No contract entry changes. Refs: OMN-18601 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P5jA4UseYGEptrKijm4X9g --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This was referenced Sep 19, 2026
jake-b-omni
added a commit
that referenced
this pull request
Sep 19, 2026
… its gate runs (#10467) * fix(OMN-18601): bind the guard evidence to omninode_infra#1583 before its gate runs The OCC eligibility gate binds a ticket's evidence to the PR under review, which for a product-repo PR is the product repo's number. The detects receipt is the honest owner: its measurement is of the guard #1583 carries. Added proactively rather than after a refusal. The same shape cost a round trip on #1580, where the evidence stamp named a merged OCC PR whose commit predated the binding, so the gate checked out a tree that could not contain it. Both halves are needed — this pr_number, and a stamp on #1583 naming the OCC PR whose merge commit carries it. No contract entry changes, so every per-entry hash stays valid. Refs: OMN-18601 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P5jA4UseYGEptrKijm4X9g * chore(OMN-18601): self-bind this companion to OCC#10467 Eligibility on this PR needs a receipt naming this PR, the same way #1583 needs one naming #1583. Two different receipts carry the two bindings, since pr_number is single-valued. No contract entry changes. Refs: OMN-18601 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01P5jA4UseYGEptrKijm4X9g --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
contracts/OMN-11938.yaml— central OCC contract for OMN-11938 (recall skill --scope flag and knowledge federation; omniclaude contracts(OMN-12153): add OCC contract + receipts binding omninode_infra#469 #1650)contracts/OMN-11940.yaml— central OCC contract for OMN-11940 (design_to_plan Phase 0 knowledge preload; omniclaude contracts(OMN-12155): add OCC contract binding omninode_infra#471 #1651)contracts/OMN-11941.yaml— central OCC contract for OMN-11941 (ticket-work research enrichment docs; omniclaude contracts(OMN-12154): add OCC contract for Valkey rate limiter fix #1652)drift/dod_receipts/OMN-11938/dod-omniclaude-pr-1650/command.yaml— PR contracts(OMN-12153): add OCC contract + receipts binding omninode_infra#469 #1650 receiptdrift/dod_receipts/OMN-11940/dod-omniclaude-pr-1651/command.yaml— PR contracts(OMN-12155): add OCC contract binding omninode_infra#471 #1651 receiptdrift/dod_receipts/OMN-11941/dod-omniclaude-pr-1652/command.yaml— PR contracts(OMN-12154): add OCC contract for Valkey rate limiter fix #1652 receiptContext
Wave 2 of the May-24 integration closeout. Lanes 1 (LLM topology: PRs already merged) and 5 (hardcoded
model cleanup: OMN-11970 via #1570, OMN-11971 via #1569) are already covered by prior merged OCC PRs.
This PR covers Lane 2 knowledge platform tickets whose DoD Evidence Check and validate-pr-contracts
gates are failing on omniclaude PRs #1650, #1651, and #1652.
Test plan
uv run validate-yaml contracts/OMN-11938.yaml contracts/OMN-11940.yaml contracts/OMN-11941.yamlpre-commit run --all-filespasses cleanlyOMN-11982
Summary by CodeRabbit