Repository navigation
evidence(OMN-9068): add omniclaude receipt gate contracts - #1201
Merged
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThis PR adds contract definitions and Definition of Done (DoD) evidence receipts for three independent omniclaude workflow tickets. Each contract specifies requirements and evidence validation; corresponding receipt files document passing evidence from GitHub CLI probes against PR metadata and CI gate status. ChangesContract definitions and DoD receipts
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
jonahgabriel
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 3
🧹 Nitpick comments (1)
contracts/OMN-11151.yaml (1)
14-15: 💤 Low valueConsider explicit YAML multiline syntax for long commands.
The command spans two lines using implicit continuation. While YAML will parse this correctly (converting the newline to a space), using explicit multiline syntax (
>for folded or|for literal) would improve readability and maintainability.📝 Example using folded scalar
description: "Blocking validation workflow tests pass on omniclaude PR `#1613`." - command: "uv run pytest tests/workflows/test_blocking_validation_workflows.py tests/validation/test_validate_skill_node_boundary.py - tests/unit/skills/generate_ticket_contract/test_proof_validation.py -q" + command: > + uv run pytest tests/workflows/test_blocking_validation_workflows.py + tests/validation/test_validate_skill_node_boundary.py + tests/unit/skills/generate_ticket_contract/test_proof_validation.py -q🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@contracts/OMN-11151.yaml` around lines 14 - 15, The YAML 'command' value in contracts/OMN-11151.yaml is a long, implicitly continued string; replace the current inline/implicit multi-line form under the 'command' key with an explicit YAML multiline scalar (use '>' for folded or '|' for literal) so the long pytest invocation is clearer and preserves formatting; update the 'command' entry accordingly (keeping the same arguments and spacing) to improve readability and maintainability.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@drift/dod_receipts/OMN-11151/dod-product-ci-gates/command.yaml`:
- Around line 6-13: The check_value and probe_command are inconsistent:
check_value uses "gh pr checks ..." while probe_command runs "gh pr view ...
--json statusCheckRollup ...". Pick one canonical command and make them match;
either update check_value to the JSON-formatted probe_command string used by
probe_command, or replace probe_command with the original "gh pr checks 1613
--repo OmniNode-ai/omniclaude" string so both check_value and probe_command are
identical. Ensure you only change the value of check_value or probe_command
(whichever you choose) and keep the pr number and repo name the same.
In `@drift/dod_receipts/OMN-9068/dod-product-ci-gates/command.yaml`:
- Line 6: The check_value string does not match the actual probe_command used:
check_value is set to "gh pr checks 1610 --repo OmniNode-ai/omniclaude" while
probe_command uses "gh pr view 1610 ... --json statusCheckRollup"; update one to
match the other so they align (either change check_value to use the gh pr view
invocation and expected JSON path, or change probe_command to run gh pr checks)
— modify the check_value and/or probe_command entries (look for the check_value
and probe_command keys in this command.yaml and the sibling
dod-omniclaude-pr-1610/command.yaml) so both use the same gh CLI command and
expected output format.
In `@drift/dod_receipts/OMN-9069/dod-omniclaude-pr-1609/command.yaml`:
- Around line 6-16: The probe is asserting the PR is open but neither
check_value nor probe_command request the PR's .state field; update both the
check_value and probe_command (they currently call gh pr view 1609 --json
headRefOid,title,url,headRefName,baseRefName) to include state (i.e., add ,state
to the --json list) so probe_stdout will record the PR state alongside
headRefOid/title/url/headRefName/baseRefName and the actual_output assertion can
be directly supported.
---
Nitpick comments:
In `@contracts/OMN-11151.yaml`:
- Around line 14-15: The YAML 'command' value in contracts/OMN-11151.yaml is a
long, implicitly continued string; replace the current inline/implicit
multi-line form under the 'command' key with an explicit YAML multiline scalar
(use '>' for folded or '|' for literal) so the long pytest invocation is clearer
and preserves formatting; update the 'command' entry accordingly (keeping the
same arguments and spacing) to improve readability and maintainability.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 585d17d0-337a-405a-8230-3fe63e084b43
📒 Files selected for processing (9)
contracts/OMN-11151.yamlcontracts/OMN-9068.yamlcontracts/OMN-9069.yamldrift/dod_receipts/OMN-11151/dod-omniclaude-pr-1613/command.yamldrift/dod_receipts/OMN-11151/dod-product-ci-gates/command.yamldrift/dod_receipts/OMN-9068/dod-omniclaude-pr-1610/command.yamldrift/dod_receipts/OMN-9068/dod-product-ci-gates/command.yamldrift/dod_receipts/OMN-9069/dod-omniclaude-pr-1609/command.yamldrift/dod_receipts/OMN-9069/dod-product-ci-gates/command.yaml
jonahgabriel
changed the title
jonahgabriel
enabled auto-merge (squash)
May 20, 2026 01:49
This was referenced May 20, 2026
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Downstream
Summary by CodeRabbit
Note: This release contains internal infrastructure updates with no visible end-user facing changes.
Evidence-Ticket: OMN-9068
Evidence-Source: OCC#1201