Repository navigation
docs(OMN-10475): bind omniclaude salvage PR 1633 - #1321
Merged
Merged
Conversation
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (16)
📝 WalkthroughWalkthroughThis PR adds a new manual evidence record for ticket OMN-10475 related to PR 1633. It includes a contract entry in ChangesPR Evidence Record Addition
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
drift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yaml (1)
1-20:⚠️ Potential issue | 🔴 Critical | ⚡ Quick winAdd missing
contract_sha256to the receipt
drift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yamlis missing the requiredcontract_sha256field.- Other receipts under the same ticket include it (e.g.
drift/dod_receipts/OMN-10475/dod-occ-pr-1321/command.yamlusescontract_sha256: "sha256:<hex>").- Populate
contract_sha256with the SHA-256 ofcontracts/OMN-10475.yamlfor the contract’s final version at the PR head; this receipt’scommit_sha(e4dbff...) is not present as a commit in this repo, so compute from the correct contract revision instead.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@drift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yaml` around lines 1 - 20, The receipt file command.yaml is missing the required contract_sha256 field; open drift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yaml and add a new top-level line contract_sha256: "sha256:<hex>" where <hex> is the SHA-256 digest of the final contracts/OMN-10475.yaml content as used for this PR head (compute the hash over the file bytes of the contract's final revision rather than using the provided commit_sha which is not present in the repo); ensure the digest string exactly matches the format used by other receipts (e.g. contract_sha256: "sha256:abc123...") and commit the updated receipt.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@drift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yaml`:
- Around line 1-20: The receipt file command.yaml is missing the required
contract_sha256 field; open
drift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yaml and add a new
top-level line contract_sha256: "sha256:<hex>" where <hex> is the SHA-256 digest
of the final contracts/OMN-10475.yaml content as used for this PR head (compute
the hash over the file bytes of the contract's final revision rather than using
the provided commit_sha which is not present in the repo); ensure the digest
string exactly matches the format used by other receipts (e.g. contract_sha256:
"sha256:abc123...") and commit the updated receipt.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 6460f9b7-7c47-49bf-a10d-ad03bbb7f0a3
📒 Files selected for processing (2)
contracts/OMN-10475.yamldrift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yaml
jonahgabriel
pushed a commit
that referenced
this pull request
Jun 20, 2026
…igibility) The OCC PR's own occ-preflight/verify eligibility check requires a PASS receipt bound to this PR. Repoints dod-occ-pr from the historical #2000 binding to #2864 (pr_number-based binding). Route-PR receipts (#2052, #1321) and the enum-half #1187 receipt are unchanged; local validator_occ_merge_eligibility returns eligible:true for the OCC-self snapshot and both route-PR snapshots. Evidence-Ticket: OMN-12545
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the central OCC receipt binding
OMN-10475toomniclaude#1633/e4dbff517a08e2e370fc4c210a17795fe4108a35so downstream Receipt Gate no longer failspr_ticket_mismatch.Evidence-Ticket: OMN-10475
Evidence-Source: OCC#1321
Verification:
uv run python scripts/check_dod_evidence_present.py contracts/OMN-10475.yamluv run python scripts/lint_contract_check_values.py contracts/OMN-10475.yamluv run pre-commit run --files contracts/OMN-10475.yaml drift/dod_receipts/OMN-10475/dod-omniclaude-pr-1633/command.yamluv run python -m omnibase_core.validation.validator_occ_merge_eligibility --repo omniclaude --pr-number 1633 --pr-title "chore(OMN-10475): salvage worktree follow-up for omniclaude" --pr-body-file <tmp body> --pr-branch jonah/omn-10475-omniclaude-followup-20260522 --pr-commit-sha e4dbff517a08e2e370fc4c210a17795fe4108a35 --occ-commit-sha 0a3ca8c2add80be9509684cc43316826f1c2c1b4 --contracts-dir contracts --receipts-dir drift/dod_receiptsSummary by CodeRabbit