Skip to content

evidence(OMN-9121): bind omnibase infra PR 1650 - #1226

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9121-occ-evidence
May 20, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-9121-occ-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Evidence-Ticket: OMN-9121

Summary

Verification

  • uv run python scripts/lint_contract_check_values.py contracts/OMN-9121.yaml
  • uv run python scripts/check_dod_evidence_present.py contracts/OMN-9121.yaml
  • CONTRACT_REPO_DIR=$PWD uv run python scripts/ci/run_contract_compliance_check.py --pr 1650 --repo OmniNode-ai/omnibase_infra --contracts-dir contracts
  • git diff --check

Summary by CodeRabbit

  • New Features

    • Added Prometheus crash-loop alerting rules for runtime containers to detect restart storms, high restart counts, and scrape failures.
  • Tests

    • Validated Prometheus rule configuration and syntax with successful test execution.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 20, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 24 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7ee2fb65-4be1-4f3c-9fea-b43d562a2b44

📥 Commits

Reviewing files that changed from the base of the PR and between 5ac9755 and e1e031c.

📒 Files selected for processing (6)
  • contracts/OMN-9121.yaml
  • drift/dod_receipts/OMN-9121/dod-clean-root-tests/command.yaml
  • drift/dod_receipts/OMN-9121/dod-occ-pr-1226/command.yaml
  • drift/dod_receipts/OMN-9121/dod-omnibase-infra-pr-1650/command.yaml
  • drift/dod_receipts/OMN-9121/dod-promtool-config/command.yaml
  • drift/dod_receipts/OMN-9121/dod-promtool-rules/command.yaml
📝 Walkthrough

Walkthrough

This PR adds OMN-9121, a new ticket specification for Prometheus crash-loop alerting on runtime containers. The contract defines evidence requirements for validating the Prometheus rules implementation, and includes four supporting result receipts from promtool validation, GitHub PR verification, and pytest checks confirming all requirements are met.

Changes

OMN-9121 Prometheus Crash-Loop Alerting Specification

Layer / File(s) Summary
Ticket contract and evidence requirements
contracts/OMN-9121.yaml
Defines OMN-9121 contract with schema metadata, implementation summary for crash-loop alerting (restart storms, high restart counts, scrape failures), and evidence requirements for promtool validation and repository verification.
Validation evidence receipts
drift/dod_receipts/OMN-9121/dod-omnibase-infra-pr-1650/command.yaml, drift/dod_receipts/OMN-9121/dod-promtool-config/command.yaml, drift/dod_receipts/OMN-9121/dod-promtool-rules/command.yaml, drift/dod_receipts/OMN-9121/dod-clean-root-tests/command.yaml
Documents four validation checks proving OMN-9121 compliance: promtool Prometheus rules validation, promtool config validation, GitHub PR verification for omnibase_infra changes, and pytest clean-root validation confirming observability directory is permitted.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A ticket born, with rules so bright,
To catch those restarts through the night,
Four proof stones laid, each passing true—
Prometheus guards the runtime crew! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding evidence for OMN-9121 ticket by binding the omnibase_infra PR 1650.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9121-occ-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-9121-occ-evidence branch from 865b8c2 to e1e031c Compare May 20, 2026 12:58
@jonahgabriel
jonahgabriel enabled auto-merge (squash) May 20, 2026 12:59
@jonahgabriel
jonahgabriel merged commit 3ddf43d into main May 20, 2026
32 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-9121-occ-evidence branch May 20, 2026 13:01
jonahgabriel added a commit that referenced this pull request Jun 11, 2026
…1226

Adds dod-core-dev-backmerge-clean receipt (binds commit_sha 730c67b8f / PR #1226)
so the omnibase_core main->dev backmerge clears the Receipt Gate OCC eligibility
check. Re-stamps all OMN-12934 receipts' contract_sha256 to the updated contract
hash (new evidence item added). Verified locally: validator_occ_merge_eligibility
returns eligible=true (hash-bound + PR-bound); receipt-honesty PASSES.
jonahgabriel added a commit that referenced this pull request Jun 11, 2026
…1226

Adds dod-core-dev-backmerge-clean receipt (binds commit_sha 730c67b8f / PR #1226)
so the omnibase_core main->dev backmerge clears the Receipt Gate OCC eligibility
check. Re-stamps all OMN-12934 receipts' contract_sha256 to the updated contract
hash (new evidence item added). Verified locally: validator_occ_merge_eligibility
returns eligible=true (hash-bound + PR-bound); receipt-honesty PASSES.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant