Skip to content

evidence(OMN-11292): bind omnibase_core PR 1119 - #1221

Merged
jonahgabriel merged 3 commits into
mainfrom
jonah/omn-11292-omnibase-core-1119-evidence
May 20, 2026
Merged

jonahgabriel merged 3 commits into
mainfrom
jonah/omn-11292-omnibase-core-1119-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Validation

  • uv run validate-yaml contracts/OMN-11292.yaml
  • uv run python - <<'PY'
    from pathlib import Path
    import yaml
    from omnibase_core.models.contracts.ticket.model_dod_receipt import ModelDodReceipt
    for path in sorted(Path('drift/dod_receipts/OMN-11292').rglob('*.yaml')):
    ModelDodReceipt.model_validate(yaml.safe_load(path.read_text()))
    print(f'OK {path}')
    PY
  • local grep checks for dod-omnibase-core-pr-1119 and dod-non-receipt-checks

Summary by CodeRabbit

  • Chores
    • Added internal governance and verification records to support contract management and compliance tracking processes.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 20, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 38 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d5cbfd4f-01e5-43c9-a245-3e3bcd9719e7

📥 Commits

Reviewing files that changed from the base of the PR and between 9b9c8d4 and 297da23.

📒 Files selected for processing (2)
  • contracts/OMN-11292.yaml
  • drift/dod_receipts/OMN-11292/dod-occ-pr/command.yaml
📝 Walkthrough

Walkthrough

This PR adds a new evidence contract for ticket OMN-11292 that binds omnibase_core PR #1119 dependency verification to OCC central evidence. The contract specifies evidence requirements (PR open, CI checks passing, OCC PR bound) and includes corresponding DoD receipt records that validate each requirement with PASS status.

Changes

Evidence Binding for OMN-11292

Layer / File(s) Summary
Contract definition and verified evidence receipts
contracts/OMN-11292.yaml, drift/dod_receipts/OMN-11292/*
OMN-11292 contract defines evidence requirements for dependency PR open status, non-Receipt-Gate CI checks in SUCCESS/SKIPPED state, and OCC PR binding; corresponding command.yaml receipt records validate each requirement with PASS status, matching commit SHA, and execution metadata.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • OmniNode-ai/onex_change_control#1207: Both PRs add new OMN ticket contracts and command.yaml receipts using the same gh pr checks logic to validate all non-Receipt-Gate checks for dependency PRs are SUCCESS or SKIPPED.

Poem

🐰 A contract signed, sealed, with proof in hand,
The core PR verified, as evidence planned,
Checks all pass, receipts aligned,
Dependency gates redesigned! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding evidence binding omnibase_core PR 1119 to the OMN-11292 ticket, which is the primary objective of the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11292-omnibase-core-1119-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel merged commit 0add8b0 into main May 20, 2026
32 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11292-omnibase-core-1119-evidence branch May 20, 2026 10:13
jonahgabriel added a commit that referenced this pull request Jun 14, 2026
The OCC merge-eligibility validator requires at least one PASS receipt for
the cited ticket to bind to THIS OCC PR (pr_number == the OCC PR, or
commit_sha in the OCC PR's commits). dod-occ-pr is the self-attestation
receipt; re-point it from the superseded OCC #2621 to #2635 so eligibility
is satisfied for the #1221 emit-evidence PR. Refresh its evidence text to
describe the 4-receipt set (3 re-pinned #1215 routing-gate receipts +
dod-emit-wired-pr1221 for #1221).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant