Skip to content

evidence(OMN-11228): add contract and dod receipts for session phase topics - #1131

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-11228-evidence
May 20, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-11228-evidence

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 18, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Ticket

OMN-11228 — part of epic OMN-11224

Evidence

Evidence-Source: OCC#1131
Evidence-Ticket: OMN-11228

Summary by CodeRabbit

  • Chores
    • Added contract specification and definition-of-done verification records for session phase topics registration.

Review Change Stack

…topics

Adds OCC contract contracts/OMN-11228.yaml and dod receipt binding
omnibase_core PR #1105 (5 session phase topics registered in TopicBase).
@coderabbitai

coderabbitai Bot commented May 18, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 49 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9f404929-bb76-4eca-a8ab-7eeb5fd2bebf

📥 Commits

Reviewing files that changed from the base of the PR and between 8f319e8 and eea75ae.

📒 Files selected for processing (1)
  • drift/dod_receipts/OMN-11228/dod-occ-pr/command.yaml
📝 Walkthrough

Walkthrough

This PR establishes a new contract definition for ticket OMN-11228 ("Register session phase topics in TopicBase") along with a recorded evidence receipt documenting a passing pytest run. The contract specifies unit test and CI check requirements, and the corresponding command.yaml receipt demonstrates those tests passed.

Changes

OMN-11228 Contract and DOD Evidence

Layer / File(s) Summary
Contract definition and evidence requirements
contracts/OMN-11228.yaml
Ticket metadata, schema versioning, unit test invocation requirements, CI checks command reference, disabled emergency bypass, and DOD evidence receipt structure with bindings to generated and manual receipts.
Command evidence receipt
drift/dod_receipts/OMN-11228/dod-core-pr-1105/command.yaml
Recorded pytest execution capturing PASS status, 5 tests passed in 0.73s, exit code 0, with associated commit SHA, runner identity, and PR number metadata.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

A rabbit hops through contracts bold,
Recording proof of tests that hold,
Five tests passed, the evidence clear—
Session topics registered here! 🐰✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly and specifically describes the main change: adding a contract definition and definition-of-done receipts for ticket OMN-11228 related to session phase topics.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11228-evidence

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contracts/OMN-11228.yaml`:
- Around line 36-43: The contract references a DoD item with id "dod-occ-pr" but
the required receipt file under the OMN-11228 dod_receipts (the
dod-occ-pr/command.yaml checked by the grep conditions) is missing; either add
that receipt file with a status: PASS and ticket_id: "OMN-11228" matching the
grep checks, or remove the "dod-occ-pr" entry from the OMN-11228 contract so the
check is not performed.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 922dbd31-9b29-4df8-9790-f2c9355ffd22

📥 Commits

Reviewing files that changed from the base of the PR and between 513e442 and 8f319e8.

📒 Files selected for processing (2)
  • contracts/OMN-11228.yaml
  • drift/dod_receipts/OMN-11228/dod-core-pr-1105/command.yaml

Comment thread contracts/OMN-11228.yaml
@jonahgabriel
jonahgabriel merged commit d502960 into main May 20, 2026
34 of 35 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-11228-evidence branch May 20, 2026 05:49
jonahgabriel added a commit that referenced this pull request May 22, 2026
Bind OMN-11608, OMN-11546, and OMN-11605 receipts for omnibase_core PRs #1132, #1131, and #1133.
jonahgabriel added a commit that referenced this pull request May 22, 2026
* evidence(OMN-11608): bind core receipt contracts

Bind OMN-11608, OMN-11546, and OMN-11605 receipts for omnibase_core PRs #1132, #1131, and #1133.

* evidence(OMN-11608): bind OCC receipt self checks

Bind OMN-11608, OMN-11546, and OMN-11605 receipts to onex_change_control PR #1360.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant