Repository navigation
evidence(OMN-15359): bind AC1 and AC4 to checks that can fail - #11045
Merged
Merged
Conversation
The contract carried 28 evidence items and no binds_ac; the ticket's acceptance bullets have now been labelled AC1-AC5 so the binding gate can see them. AC1: the omninode_internal relation family record in knowledge-base-internal (#441), read from main; it carries owner, domain, migration stream, and per-relation producer and consumer. It binds the one family this ticket built; tenant and platform_catalog were descoped to OMN-17887 on 2026-09-04. AC4: a live READ ONLY query on the .201 dev lane that passes only when every omninode_internal table has RLS off, the schema has no policy, and tenant_projection_writer can read none of them (AC4-OK 18). The same predicate on public and on a missing schema reads AC4-FAIL. local_done_gate, because hosted CI has no ssh to the lab host. AC2 (OMN-17886), AC3 (OMN-17887) and AC5 are not bound here.
Contributor
|
Close-out. Merged 2026-09-24T09:33:43Z as In short: there are no review comments to answer. The PR has no reviews, no inline comments and no issue comments (read 2026-09-27T18:48Z). The AC1 binding still stands and passes today. The AC4 binding was wrong, and I retired it the same day in onex_change_control#11061. What it boundIt appended two items to
How it was verified
What happened to these bindings since
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Binds AC1 and AC4 of OMN-15359 to checks that can fail.
contracts/OMN-15359.yamlcarried 28 evidence items and nobinds_ac. The ticket's acceptance bullets carried noAClabels, so the binding gate could see none of its criteria (criteria_by_labelreturned[]). The five bullets have now been labelled AC1–AC5 in the ticket, with no other text changed. AC2, AC3 and AC5 are not bound here.What changed
Append-only, in
contracts/OMN-15359.yamlplus one new receipt per item underdrift/dod_receipts/OMN-15359/:AC1:
ac1-omninode-internal-relation-family-record(command).reference/omninode-internal-relation-family.mdfrom knowledge-base-internalmain. That page is the transformation receipt AC1 names: knowledge-base-internal#441, regenerated after the original was deleted by the OMN-16607 scrub.tenantandplatform_catalogwere descoped to OMN-17887 on 2026-09-04, and the item says so.AC4:
ac4-internal-no-tenant-guc-tenant-roles-denied(command,local_done_gate). It is a liveREAD ONLYquery on the .201 dev lane (omnidash_analytics) and passes only when all of these hold:omninode_internalhas row-level security off;pg_policyrows;tenant_projection_writercan SELECT none of them;This matches how the 2026-09-04 and 2026-09-05 adjudications scored AC4. It is
local_done_gate(OMN-15392) because hosted CI has no ssh to the lab host.Deliberately not done:
How it was verified
maina9aa611f(2026-09-24T08:24:05Z). Negative control: a heading the page does not carry exits 1.AC4-OK 18at 2026-09-24T08:22:36Z; the parsed check exits 0 at 08:24:05Z. The runtime image on the lane is at omnibase_infra5a7aa99e. Negative controls:publicreadsAC4-FAIL(11 RLS tables, 12 policies, 16 readable by the tenant writer) and the check exits 1;AC4-FAILwith n=0.check_value, per-entry hash and probe command matches the parsed contract after yamlfmt, with 0 mismatches.onexbot-occ-writer[bot]'s own mint (OMN-18921) and is unsigned, the same shape onex_change_control#10904 and evidence(OMN-17422): bind AC1-AC5 to checks that can fail #11019 merged with. It is not rewritten.Local gates
--no-verify, noSKIP=, no--no-gpg-sign, nocore.hooksPathoverride. Every pre-commit and pre-push hook ran.Not in this change