Skip to content

docs(OMN-16933): drop the deleted cr-thread-gate row from the CI monitoring guide - #469

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-16933-omnimemory-ci-guide
Aug 31, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-16933-omnimemory-ci-guide

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

Registry hygiene for OMN-16933 (operator ruling 2026-08-29: "remove completely.").

docs/ci/CI_MONITORING_GUIDE.md still listed .github/workflows/cr-thread-gate.yml
as an active gate — "Fails if unresolved CodeRabbit review threads exist". That
workflow was deleted from this repo in #458 under this same ticket, so the row
documents a file that no longer exists and a gate that is required on no branch.

Anyone triaging CI from this guide would go looking for a check that can never
report. Removing the row; no other content touched (plus a Last-Updated bump).

Verification

  • gate / CodeRabbit Thread Check absent from required_status_checks on dev
    across all 12 registry repos (live gh api readback, 2026-08-31).
  • .github/workflows/cr-thread-gate.yml confirmed gone from this repo tree.
  • Org-wide open-PR sweep: no PR blocked by the context.

Docs-only. Pushed through the governed pre-push hook with no PREPUSH_* override.

OMN-16933

Evidence-Ticket: OMN-16933
Evidence-Source: OCC#7837

Summary by CodeRabbit

  • Documentation
    • Updated the CI monitoring guide’s last-updated date.
    • Removed a retired workflow from the documented CI workflow list.

The workflow file was removed from this repo in #458 (OMN-16933, operator
ruling 2026-08-29: "remove completely."), but the CI monitoring guide still
listed it as an active gate that "Fails if unresolved CodeRabbit review
threads exist". That row documents a file that no longer exists and a gate
that is no longer required on any branch, so it sends anyone triaging CI
looking for a check that can never report.

Verified before removal: `gate / CodeRabbit Thread Check` is absent from
`required_status_checks` on dev across all 12 registry repos, and
`.github/workflows/cr-thread-gate.yml` is gone from this repo's tree.

OMN-16933
@onexbot-occ-writer

Copy link
Copy Markdown
Contributor

OCC autobind did not mint a companion for this PR: no changed-file candidate could be proven RED against the merge base, and emitting a PR-existence probe instead would be non-falsifiable evidence (OMN-15247). Hand-authored evidence is required.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026 •

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cd8099ee-fcb8-405a-918e-d514a0a8c82a

📥 Commits

Reviewing files that changed from the base of the PR and between 372b51f and b54cdc8.

📒 Files selected for processing (1)
  • docs/ci/CI_MONITORING_GUIDE.md

Included review availability: 0 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 1 review per hour.


📝 Walkthrough

Walkthrough

The CI monitoring guide updates its “Last Updated” date to 2026-08-31 and removes cr-thread-gate.yml from the listed CI workflows.

Changes

CI monitoring guide

Layer / File(s) Summary
Guide metadata and workflow list
docs/ci/CI_MONITORING_GUIDE.md
The guide updates the “Last Updated” date and removes cr-thread-gate.yml from the documented workflow list.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to b54cd

This docs-only change removes a deleted CI gate from the monitoring guide without changing product or runtime behavior; no actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the documentation update and removal of the deleted cr-thread-gate entry. It accurately summarizes the main change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-16933-omnimemory-ci-guide

Comment @coderabbitai help to get the list of available commands.

jonahgabriel pushed a commit to OmniNode-ai/onex_change_control that referenced this pull request Aug 31, 2026
)

* evidence: OCC companion pass 1 for OmniNode-ai/omnimemory#469

* evidence: OCC companion self-bind for #7837

---------

Co-authored-by: node-occ-companion-effect <occ-companion-effect@omninode.ai>
@jonahgabriel
jonahgabriel merged commit 29e942b into dev Aug 31, 2026
51 of 52 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-16933-omnimemory-ci-guide branch August 31, 2026 12:58
jonahgabriel added a commit that referenced this pull request Aug 31, 2026
…pattern fixes (#470)

omnimemory#466 (OMN-17236) fixed three PII detector pattern defects on a live
persistence path and merged to dev at 2026-08-30T17:50:52Z. The v0.18.0 tag and
PyPI publish had already happened at 14:06Z that day, so the fixes missed the
cut by under four hours and there has been no release since.

The consequence is live and reproducible in the .201 dev lane, whose containers
all report omninode-memory 0.18.0:

    docker exec omninode-runtime python -c "... PIIDetector().detect_pii(s) ..."
    visa     -> 'card ***-***-****111111 end'   types: ['phone']
    discover -> 'card ***-***-****111117 end'   types: ['phone']
    uuid     -> 'run 550e8400-e29b-41d4-a***-***-****40000 done'
    ssn-sp   -> 'ssn 123 45 6789 end'           types: []

The trailing six digits of a Visa or Discover card are still being written into
stored content, UUID-bearing storage requests are still refused, and a
space-separated SSN is still not detected at all.

This bump is the first of three links; the omnimarket repin (exact pin at
==0.18.0) and the dev-lane image rebuild follow on OMN-17390.

Release contents (v0.18.0..dev): #466 PII fixes + 170 behavioral tests,
#467 all 14 Dependabot alerts, #464 omnibase-infra 0.38.14, #468 sibling locks,
#469 CI guide doc fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant