Skip to content

OMN-9359 fix demo fanout type extraction - #964

Closed
jonahgabriel wants to merge 1 commit into
devfrom
jonah/omn-9359-demo-runtime
Closed

jonahgabriel wants to merge 1 commit into
devfrom
jonah/omn-9359-demo-runtime

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 28, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Verification

  • uv run ruff check src/omnimarket/nodes/node_demo_fanout_orchestrator/handlers/handler_fanout.py
  • uv run mypy src/omnimarket/nodes/node_demo_fanout_orchestrator/handlers/handler_fanout.py --strict
  • uv run pytest src/omnimarket/nodes/node_demo_fanout_orchestrator/tests/test_golden_chain.py tests/test_demo_runtime_path.py -q

Evidence-Source: OCC#1815

@coderabbitai

coderabbitai Bot commented May 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 50 minutes and 2 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d29707a3-bd9f-420b-833e-baea018cbf53

📥 Commits

Reviewing files that changed from the base of the PR and between 160df36 and f56cd18.

📒 Files selected for processing (1)
  • src/omnimarket/nodes/node_demo_fanout_orchestrator/handlers/handler_fanout.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-9359-demo-runtime

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel force-pushed the jonah/omn-9359-demo-runtime branch from 0d480ae to f56cd18 Compare May 28, 2026 21:17
@github-actions

Copy link
Copy Markdown

✅ Architectural Review — PASSED

Errors: 0
Warnings: 0

What this checks

Rule Description
ARCH-TOPIC-001 No hardcoded Kafka topic strings in handler code
ARCH-DI-001 No event_bus=None bypass
ARCH-DI-002 No direct Handler instantiation outside workflow_runner/adapters
ARCH-DI-003 No reinvented DI containers
ARCH-TOPIC-002 contract.yaml topics follow `onex.{cmd

No architectural violations found.

Powered by node_pr_review_bot

@github-actions

Copy link
Copy Markdown

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@github-actions

github-actions Bot commented May 28, 2026 •

Copy link
Copy Markdown

✅ PR Review Bot — CLEAN

Findings: 0
Run ID: ``

Note: Reviewer models are running as stubs (OMN-7969–OMN-7972 pending). Architectural findings from Phase 1 (arch-lint) are the authoritative signal until model handlers land.


Verdict semantics

Verdict Meaning
clean No blocking findings
risks_noted Findings noted; threads passed verification
blocking_issue MAJOR/CRITICAL findings not resolved — do not merge

Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out

@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Closing as superseded: after rebasing onto current dev, the only OMN-9359 demo fanout type fix is already upstream via merged omnimarket #962. Focused verification on the rebased tree passed: mypy handler strict, ruff handler check, and demo fanout/runtime tests (14 passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant