Repository navigation
OMN-9359 implement demo market skill runtime nodes - #958
Conversation
|
Warning Review limit reached
More reviews will be available in 6 minutes. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — Qwen3-Coder-30B reviewer + DeepSeek-R1 judge (OMN-7963) |
…ver the body (#2139) _extract_tickets keyed a minted OCC companion to the shared _extract_ticket_ids(body, title) result — body closing-keyword matches exclusive, title only as fallback. The Receipt Gate's own identity check (_verify_ticket_identity Axis 1) requires the PR TITLE, never the body, to reference whatever ticket the companion's Evidence-Ticket names, so a body-first extraction is structurally unable to satisfy the gate it feeds whenever the body cites an unrelated ticket via a closing keyword. Live incident: omninode_infra PR #958 (title cited OMN-16368; body cited OMN-15757 as related context via a closing keyword) minted a companion keyed to OMN-15757, which could never pass OMN-16368's Receipt Gate run — a second, hand-authored companion was required and the wrong one closed as dead weight. Fix: _extract_tickets now takes only `title` and delegates to _extract_ticket_ids("", title) — same title-token regex the gate itself falls back to, body structurally excluded from the call. Regression tests reproduce the exact OMN-16368/#958 shape (title=A, body cites unrelated B via a closing keyword) both as a direct _extract_tickets assertion and end-to-end through _emit_companion_sync, asserting the minted contract/receipts key to A and that no contracts/<B>.yaml or receipt tree for B is ever authored.
Summary
Verification
Notes
Evidence-Source: OCC#1812