Repository navigation
feat(OMN-11766): registration golden chain e2e test - #768
jonahgabriel wants to merge 2 commits into
Conversation
Registration golden chain: onex.evt.omniclaude.routing-decision.v1 -> agent_routing_decisions (omnibase_infra db, migration 021). Follows the delegation e2e pattern from OMN-11765: - pytestmark skipif guard on OMN_ALLOW_LIVE_INTEGRATION_TESTS - @pytest.mark.integration + @pytest.mark.kafka - Real asyncpg connection to stability-test lane (port 5436) - Replay idempotency validated (ON CONFLICT DO NOTHING on id) - Required fields populated assertion OMN-11766
|
Warning Review limit reached
Your plan currently allows 1 review/hour. Refill in 29 minutes and 50 seconds. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more review capacity refills, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
…istration golden chain The two `192.168.86.201` fallback defaults in test_registration_e2e.py had bare `# onex-allow-internal-ip:` comments on the closing-paren line, not on the literal line itself. The gate requires (1) annotation on the same line as the literal and (2) the form `onex-allow-internal-ip OMN-XXXXX reason="..."`. Fixed both assignments to single-line form with `# fmt: skip` to prevent ruff from re-wrapping them, and updated annotations to the full required format.
|
Closing as stale from the merge sweep. This branch is 15 commits behind and conflict-marked only around generated dep-health evidence plus golden-chain package wiring. More importantly, the test scope no longer matches current registration ownership: current projection registration consumes platform node introspection/heartbeat and writes node_service_registry, while this PR exercises routing-decision.v1 -> agent_routing_decisions, which is now outside the registration projection lane. If a live broad-routing proof is still required, it should be recreated from current main with the correct runtime ownership and evidence surface. |
Summary
onex.evt.omniclaude.routing-decision.v1→agent_routing_decisions(omnibase_infra db)id)OMN_ALLOW_LIVE_INTEGRATION_TESTS=true— skips in CI without env varTest plan
OMN_ALLOW_LIVE_INTEGRATION_TESTSagent_routing_decisionsOMN-11766
Evidence-Ticket: OMN-11766
Evidence-Source: 937759c1080c1fd9c0c79e1c0d9e7e9831d5df6b