Skip to content

feat(OMN-11766): registration golden chain e2e test - #768

Closed
jonahgabriel wants to merge 2 commits into
mainfrom
jonah/omn-11766-registration-golden-chain
Closed

jonahgabriel wants to merge 2 commits into
mainfrom
jonah/omn-11766-registration-golden-chain

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented May 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Registration golden chain: onex.evt.omniclaude.routing-decision.v1 → agent_routing_decisions (omnibase_infra db)
  • Follows delegation e2e pattern established in OMN-11765
  • Replay idempotency validated (ON CONFLICT DO NOTHING on id)
  • Guarded by OMN_ALLOW_LIVE_INTEGRATION_TESTS=true — skips in CI without env var

Test plan

  • Verify 3 tests collect and skip without OMN_ALLOW_LIVE_INTEGRATION_TESTS
  • Run with env var against stability-test lane to confirm row appears in agent_routing_decisions
  • Verify idempotency: replay same event, assert count stays at 1

OMN-11766

Evidence-Ticket: OMN-11766
Evidence-Source: 937759c1080c1fd9c0c79e1c0d9e7e9831d5df6b

Registration golden chain: onex.evt.omniclaude.routing-decision.v1 ->
agent_routing_decisions (omnibase_infra db, migration 021).

Follows the delegation e2e pattern from OMN-11765:
- pytestmark skipif guard on OMN_ALLOW_LIVE_INTEGRATION_TESTS
- @pytest.mark.integration + @pytest.mark.kafka
- Real asyncpg connection to stability-test lane (port 5436)
- Replay idempotency validated (ON CONFLICT DO NOTHING on id)
- Required fields populated assertion

OMN-11766
@coderabbitai

coderabbitai Bot commented May 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 29 minutes and 50 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bcaaa745-4074-4470-9f19-9ed442a600a2

📥 Commits

Reviewing files that changed from the base of the PR and between ba9b8b9 and c39df52.

📒 Files selected for processing (7)
  • docs/evidence/dep-health-sweep/proof-of-life-001/findings.json
  • docs/evidence/dep-health-sweep/proof-of-life-001/projection_rows.json
  • docs/evidence/dep-health-sweep/proof-of-life-001/proof_summary.md
  • docs/evidence/dep-health-sweep/proof-of-life-001/run_manifest.json
  • tests/integration/golden_chain/__init__.py
  • tests/integration/golden_chain/expected_golden_chain_registration.json
  • tests/integration/golden_chain/test_registration_e2e.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-11766-registration-golden-chain

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge May 23, 2026 14:34
@github-actions

github-actions Bot commented May 23, 2026 •

Copy link
Copy Markdown

✅ Architectural Review — PASSED

Errors: 0
Warnings: 0

What this checks

Rule Description
ARCH-TOPIC-001 No hardcoded Kafka topic strings in handler code
ARCH-DI-001 No event_bus=None bypass
ARCH-DI-002 No direct Handler instantiation outside workflow_runner/adapters
ARCH-DI-003 No reinvented DI containers
ARCH-TOPIC-002 contract.yaml topics follow `onex.{cmd

No architectural violations found.

Powered by node_pr_review_bot

@github-actions

github-actions Bot commented May 23, 2026 •

Copy link
Copy Markdown

✅ PR Review Bot — CLEAN

Findings: 0
Run ID: ``

Note: Reviewer models are running as stubs (OMN-7969–OMN-7972 pending). Architectural findings from Phase 1 (arch-lint) are the authoritative signal until model handlers land.


Verdict semantics

Verdict Meaning
clean No blocking findings
risks_noted Findings noted; threads passed verification
blocking_issue MAJOR/CRITICAL findings not resolved — do not merge

Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out

@github-actions

github-actions Bot commented May 23, 2026 •

Copy link
Copy Markdown

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

…istration golden chain

The two `192.168.86.201` fallback defaults in test_registration_e2e.py had
bare `# onex-allow-internal-ip:` comments on the closing-paren line, not on
the literal line itself.  The gate requires (1) annotation on the same line as
the literal and (2) the form `onex-allow-internal-ip OMN-XXXXX reason="..."`.

Fixed both assignments to single-line form with `# fmt: skip` to prevent ruff
from re-wrapping them, and updated annotations to the full required format.
@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Closing as stale from the merge sweep. This branch is 15 commits behind and conflict-marked only around generated dep-health evidence plus golden-chain package wiring. More importantly, the test scope no longer matches current registration ownership: current projection registration consumes platform node introspection/heartbeat and writes node_service_registry, while this PR exercises routing-decision.v1 -> agent_routing_decisions, which is now outside the registration projection lane. If a live broad-routing proof is still required, it should be recreated from current main with the correct runtime ownership and evidence surface.

auto-merge was automatically disabled May 23, 2026 23:40

Pull request was closed

@jonahgabriel
jonahgabriel deleted the jonah/omn-11766-registration-golden-chain branch June 11, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant