Skip to content

feat: migrate node_ticket_classify_compute to omnimarket [OMN-7579] - #14

Merged
jonahgabriel merged 2 commits into
mainfrom
jonah/omn-7579-migrate-ticket-classify-compute
Apr 7, 2026
Merged

jonahgabriel merged 2 commits into
mainfrom
jonah/omn-7579-migrate-ticket-classify-compute

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

  • Migrate node_ticket_classify_compute from omnibase_infra to omnimarket as part of build-loop handler migration epic (OMN-7575)
  • Replace EnumBuildability with a local enum copy -- zero imports from omnibase_infra
  • Replace EnumHandlerType/EnumHandlerTypeCategory with Literal types
  • Update all module paths in contract.yaml and Python imports to omnimarket.nodes.node_ticket_classify_compute
  • Add metadata.yaml and register onex.nodes entry point in pyproject.toml

Test plan

  • 8 golden chain tests passing (classification logic, event bus wiring, all buildability categories)
  • CI green
  • Verify no remaining omnibase_infra imports in the migrated node

@coderabbitai

coderabbitai Bot commented Apr 7, 2026 •

Copy link
Copy Markdown

Warning

Rate limit exceeded

@jonahgabriel has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 5 minutes and 26 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 26 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: f4dbfa07-013e-4232-8876-905ca90f35ee

📥 Commits

Reviewing files that changed from the base of the PR and between 047a00b and 55c761f.

📒 Files selected for processing (14)
  • pyproject.toml
  • src/omnimarket/nodes/node_ticket_classify_compute/__init__.py
  • src/omnimarket/nodes/node_ticket_classify_compute/contract.yaml
  • src/omnimarket/nodes/node_ticket_classify_compute/handlers/__init__.py
  • src/omnimarket/nodes/node_ticket_classify_compute/handlers/handler_ticket_classify.py
  • src/omnimarket/nodes/node_ticket_classify_compute/metadata.yaml
  • src/omnimarket/nodes/node_ticket_classify_compute/models/__init__.py
  • src/omnimarket/nodes/node_ticket_classify_compute/models/enum_buildability.py
  • src/omnimarket/nodes/node_ticket_classify_compute/models/model_ticket_classification.py
  • src/omnimarket/nodes/node_ticket_classify_compute/models/model_ticket_classify_input.py
  • src/omnimarket/nodes/node_ticket_classify_compute/models/model_ticket_classify_output.py
  • src/omnimarket/nodes/node_ticket_classify_compute/models/model_ticket_for_classification.py
  • src/omnimarket/nodes/node_ticket_classify_compute/tests/__init__.py
  • tests/test_golden_chain_ticket_classify_compute.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-7579-migrate-ticket-classify-compute

Comment @coderabbitai help to get the list of available commands and usage tips.

@jonahgabriel
jonahgabriel enabled auto-merge April 7, 2026 13:47
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 7, 2026
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-7579-migrate-ticket-classify-compute branch 2 times, most recently from 69ee112 to 3c9af18 Compare April 7, 2026 16:53
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 7, 2026
@jonahgabriel

Copy link
Copy Markdown
Contributor Author

Closing — this PR's content was already merged via #12.

@jonahgabriel jonahgabriel reopened this Apr 7, 2026
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-7579-migrate-ticket-classify-compute branch from 3c9af18 to 0eb9cb3 Compare April 7, 2026 17:27
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 7, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Apr 7, 2026
…579]

Migrate the ticket classify compute node to omnimarket as part of the
build-loop handler migration epic (OMN-7575). Key changes:

- Copy handler, models, contract.yaml from omnibase_infra
- Replace EnumBuildability with local enum (zero omnibase_infra imports)
- Replace EnumHandlerType/EnumHandlerTypeCategory with Literal types
- Update all module paths to omnimarket.nodes.node_ticket_classify_compute
- Add metadata.yaml following node_platform_readiness pattern
- Register onex.nodes entry point in pyproject.toml
- Add 8 golden chain tests (all passing)
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-7579-migrate-ticket-classify-compute branch from 0eb9cb3 to 55c761f Compare April 7, 2026 17:45
@jonahgabriel
jonahgabriel added this pull request to the merge queue Apr 7, 2026
Merged via the queue into main with commit a3bb46b Apr 7, 2026
13 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-7579-migrate-ticket-classify-compute branch April 7, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant