Skip to content

ci(OMN-12934): preserve hotfix/* PR acceptance in main-target-guard - #1156

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-12934-omnimarket-guard-preserve
Jun 11, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-12934-omnimarket-guard-preserve

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jun 11, 2026 •

Copy link
Copy Markdown
Contributor

OMN-12934: preserve hotfix/* PR acceptance ahead of dev→main alignment

Targeted preservation for the omnimarket fix-main operation (prod promotion to a
stable baseline). The 2026-06-11 main-unique audit classified omnimarket as
needs-targeted-preservation: the only main-unique non-metadata content is
.github/workflows/main-target-guard.yml, which on main is NEWER than dev —
it adds the hotfix/* PR-acceptance path (hotfix-evidence: OCC-<n> +
backmerge: #<n>). Aligning main to dev without this would regress hotfix-PR
governance.

This PR ports main's guard onto dev. The result is the union:

  • retains dev's existing promotion/* clause
  • adds main's hotfix/* acceptance block

No product-source preservation is required — the audit verified every
hotfix-touched source/contract/handler/test (OMN-12245/12765/12770/12816) is on
dev in equal-or-newer form (0 main-only product files; 1059/1142 byte-identical;
57/60 differing files have main's blob as an ancestor in dev history). Version
metadata (pyproject 0.4.6 + uv.lock) re-mints on the next release bump.

Ticket: OMN-12934
Evidence-Ticket: OMN-12934
Evidence-Source: OCC#2454
OCC evidence pairing: onex_change_control PR #2454 carries
contracts/OMN-12934.yaml with PASS-backed dod_evidence for the dev→main
promotion + State A closure gate.

Evidence: docs/evidence/2026-06-11-prod-promotion/fix-main/omnimarket/

Port main's main-target-guard.yml hotfix-PR acceptance path onto dev ahead of
the OMN-12934 dev->main promotion so the hotfix-PR governance (hotfix-evidence:
OCC-N + backmerge: #N) is not regressed when main is aligned to dev.

This is the targeted preservation called for by the 2026-06-11 main-unique audit
(omnimarket: needs-targeted-preservation). The union retains dev's existing
promotion/* clause and adds main's hotfix/* acceptance block. No product-source
preservation required; version metadata (pyproject 0.4.6 + uv.lock) re-mints on
the next release bump.

Evidence: docs/evidence/2026-06-11-prod-promotion/fix-main/omnimarket/
@coderabbitai

coderabbitai Bot commented Jun 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 1 hour, 48 minutes, and 29 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4e218ef1-2d5c-4736-a330-556a07f0362a

📥 Commits

Reviewing files that changed from the base of the PR and between 98a81fb and 3784c46.

📒 Files selected for processing (1)
  • .github/workflows/main-target-guard.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12934-omnimarket-guard-preserve

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge June 11, 2026 07:45
@github-actions

Copy link
Copy Markdown

✅ Architectural Review — PASSED

Errors: 0
Warnings: 0

What this checks

Rule Description
ARCH-TOPIC-001 No hardcoded Kafka topic strings in handler code
ARCH-DI-001 No event_bus=None bypass
ARCH-DI-002 No direct Handler instantiation outside workflow_runner/adapters
ARCH-DI-003 No reinvented DI containers
ARCH-TOPIC-002 contract.yaml topics follow `onex.{cmd

No architectural violations found.

Powered by node_pr_review_bot

@github-actions

github-actions Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

✅ PR Review Bot — CLEAN

Findings: 0
Run ID: ``

Required gate: This check blocks merge when verdict is blocking_issue.


Verdict semantics

Verdict Meaning
clean No blocking findings
risks_noted Findings noted; threads passed judge verification
blocking_issue MAJOR/CRITICAL findings not resolved — do not merge

Powered by node_pr_review_bot — Qwen3-Coder-30B reviewer + DeepSeek-R1 judge (OMN-7963)

@github-actions

Copy link
Copy Markdown

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 11, 2026
Merged via the queue into dev with commit 9a6e3b2 Jun 11, 2026
51 of 54 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12934-omnimarket-guard-preserve branch June 11, 2026 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant