Repository navigation
fix(OMN-12659): repoint contract.yaml module refs from compat to core (B1 finish) - #1034
Conversation
The three delegation node contracts still pointed handler_routing event_model modules and subscribe_topic_metadata schema_refs at omnibase_compat.contracts.delegation.wire after the Python import repoint landed in #1032. This finishes B1 by updating: - node_delegation_quality_gate_reducer/contract.yaml (ModelQualityGateIntent) - node_delegation_routing_reducer/contract.yaml (ModelRoutingIntent) - node_llm_delegation_call_effect/contract.yaml (ModelInferenceIntent, ModelInferenceResponseData — 3 refs) All symbols (ModelQualityGateIntent, ModelRoutingIntent, ModelInferenceIntent, ModelInferenceResponseData) are confirmed present in omnibase_core.models.delegation.wire.__all__. git grep -c omnibase_compat.contracts.delegation.wire -- src/ = 0 The compat shims in omnibase_compat itself are addressed in a separate PR against that repo (OMN-12659). Evidence-Ticket: OMN-12659
|
Warning Review limit reached
More reviews will be available in 35 minutes and 51 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
d69e9dd to
4fa9d26
Compare
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
Summary
Finishes WS-B1 of the SEA e2e epic (OMN-12588). PR #1032 repointed the Python importers but left three contract YAML files still pointing at omnibase_compat.contracts.delegation.wire. This PR completes the migration.
Files changed:
Verification:
Compat shim deletion: shim package lives in omnibase_compat; a separate PR will delete it.
Evidence
Evidence-Source: 418d86f9ded42d577a9d5560b273ca582759dfba
Evidence-Ticket: OMN-12659