Skip to content

fix(OMN-12659): repoint contract.yaml module refs from compat to core (B1 finish) - #1034

Merged
jonahgabriel merged 1 commit into
devfrom
jonah/omn-12659-contract-yaml-repoint
Jun 4, 2026
Merged

jonahgabriel merged 1 commit into
devfrom
jonah/omn-12659-contract-yaml-repoint

Conversation

@jonahgabriel

Copy link
Copy Markdown
Contributor

Summary

Finishes WS-B1 of the SEA e2e epic (OMN-12588). PR #1032 repointed the Python importers but left three contract YAML files still pointing at omnibase_compat.contracts.delegation.wire. This PR completes the migration.

Files changed:

  • node_delegation_quality_gate_reducer/contract.yaml (ModelQualityGateIntent)
  • node_delegation_routing_reducer/contract.yaml (ModelRoutingIntent)
  • node_llm_delegation_call_effect/contract.yaml (ModelInferenceIntent + ModelInferenceResponseData — 3 refs)

Verification:

  • git grep -c omnibase_compat.contracts.delegation.wire -- src/ = 0 (was 5 lines across 3 files)
  • 1103 contract/delegation tests passed, 56 validation tests passed
  • runtime_sweep 293/293 entry points OK
  • All pre-commit hooks passed

Compat shim deletion: shim package lives in omnibase_compat; a separate PR will delete it.

Evidence

Evidence-Source: 418d86f9ded42d577a9d5560b273ca582759dfba
Evidence-Ticket: OMN-12659

The three delegation node contracts still pointed handler_routing
event_model modules and subscribe_topic_metadata schema_refs at
omnibase_compat.contracts.delegation.wire after the Python import
repoint landed in #1032. This finishes B1 by updating:

- node_delegation_quality_gate_reducer/contract.yaml (ModelQualityGateIntent)
- node_delegation_routing_reducer/contract.yaml (ModelRoutingIntent)
- node_llm_delegation_call_effect/contract.yaml (ModelInferenceIntent, ModelInferenceResponseData — 3 refs)

All symbols (ModelQualityGateIntent, ModelRoutingIntent, ModelInferenceIntent,
ModelInferenceResponseData) are confirmed present in
omnibase_core.models.delegation.wire.__all__.

git grep -c omnibase_compat.contracts.delegation.wire -- src/ = 0

The compat shims in omnibase_compat itself are addressed in a separate
PR against that repo (OMN-12659).

Evidence-Ticket: OMN-12659
@coderabbitai

coderabbitai Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

@jonahgabriel, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 35 minutes and 51 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6ab28de3-12c0-4ff7-b6da-f7f018fb223b

📥 Commits

Reviewing files that changed from the base of the PR and between d8c036e and 4fa9d26.

📒 Files selected for processing (3)
  • src/omnimarket/nodes/node_delegation_quality_gate_reducer/contract.yaml
  • src/omnimarket/nodes/node_delegation_routing_reducer/contract.yaml
  • src/omnimarket/nodes/node_llm_delegation_call_effect/contract.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-12659-contract-yaml-repoint

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
github-actions Bot enabled auto-merge June 4, 2026 12:53
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-12659-contract-yaml-repoint branch from d69e9dd to 4fa9d26 Compare June 4, 2026 12:53
@github-actions

github-actions Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

✅ Architectural Review — PASSED

Errors: 0
Warnings: 0

What this checks

Rule Description
ARCH-TOPIC-001 No hardcoded Kafka topic strings in handler code
ARCH-DI-001 No event_bus=None bypass
ARCH-DI-002 No direct Handler instantiation outside workflow_runner/adapters
ARCH-DI-003 No reinvented DI containers
ARCH-TOPIC-002 contract.yaml topics follow `onex.{cmd

No architectural violations found.

Powered by node_pr_review_bot

@github-actions

github-actions Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

✅ PR Review Bot — CLEAN

Findings: 0
Run ID: ``

Note: Reviewer models are running as stubs (OMN-7969–OMN-7972 pending). Architectural findings from Phase 1 (arch-lint) are the authoritative signal until model handlers land.


Verdict semantics

Verdict Meaning
clean No blocking findings
risks_noted Findings noted; threads passed verification
blocking_issue MAJOR/CRITICAL findings not resolved — do not merge

Powered by node_pr_review_bot — FSM pipeline with multi-model review fan-out

@github-actions

github-actions Bot commented Jun 4, 2026 •

Copy link
Copy Markdown

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@jonahgabriel
jonahgabriel added this pull request to the merge queue Jun 4, 2026
Merged via the queue into dev with commit adb2a23 Jun 4, 2026
91 of 95 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-12659-contract-yaml-repoint branch June 4, 2026 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant