Repository navigation
feat(OMN-12659): repoint delegation.wire importers from compat to core - #1032
Conversation
WS-B1: All 29 omnimarket importers of omnibase_compat.contracts.delegation.wire repointed to omnibase_core.models.delegation.wire (OMN-12126 graduation). - Bump omnibase_core pin to git SHA 307e51f9 (dev tip, 0.44.0) which includes: TopicBase infra delegation topics (OMN-12663), widened tier Literal (OMN-12663), and full 12-value task_type Literal (OMN-12663 follow-on) - Repoint aggregator src/omnimarket/models/delegation/wire/__init__.py to import from omnibase_core.models.delegation.wire.* with explicit per-module imports - Repoint 22 individual shim modules in nodes/ and adapters/ - Update 5 test files to reference core module paths for identity assertions - Update test_delegation_dto_omnibase_compat_imports.py: canonical_ref paths now use core file names (model_delegation_wire_request, model_delegation_wire_envelope) and module-origin assertions updated from compat to core Result: 0 omnibase_compat.contracts.delegation.wire importers in src/ or tests/; 4040 unit tests pass, 0 failures; aggregator __all__ fully bound (38 symbols).
Pre-commit end-of-file-fixer normalized trailing newlines in dep-health-sweep evidence artifacts.
📝 WalkthroughWalkthroughThis PR systematically migrates delegation DTO imports across omnimarket from the ChangesDelegation DTO Migration to Core
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
…-ws-b1-repoint-delegationwire-compat-importers-to-core-delete
✅ PR Review Bot — CLEANFindings: 0
Verdict semantics
Powered by node_pr_review_bot — Qwen3-Coder-30B reviewer + DeepSeek-R1 judge (OMN-7963) |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
✅ Architectural Review — PASSEDErrors: 0 What this checks
No architectural violations found. Powered by node_pr_review_bot |
…r_quality_gate mypy --strict rejected string literal assignment to EnumQualityGateCategory variable. Replace "pass"/"fail_heuristic" string literals with EnumQualityGateCategory.PASS/FAIL_HEURISTIC enum members. Pre-existing type error (not introduced by OMN-12659 compat->core repoint), fixed in this PR to unblock CI typecheck gate.
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/evidence/dep-health-sweep/proof-of-life-001/findings.json`:
- Line 6: The committed findings.json contains absolute private workspace paths
in the "file_path" field; update the code that populates findings entries (the
serializer that creates findings.json / the function that sets "file_path") to
convert absolute paths to repository-relative ones before writing (use
os.path.relpath against the repo root or replace the fixture tmp prefix with
"<fixture>/..."), and apply the same normalization for all occurrences
(including the other reported index) so no /private/tmp/... paths are written to
the JSON.
In `@docs/evidence/dep-health-sweep/proof-of-life-001/projection_rows.json`:
- Line 7: Projection evidence currently stores absolute temp paths in the
"file_path" field (see projection_rows.json) which leaks private workspace info;
update the serialization logic that populates the "file_path" key to
normalize/redact these values (for example convert to repo-relative paths or
replace temp prefixes with a fixture token) before persisting. Locate the code
that writes projection rows (the routine that sets "file_path" when building
projection_rows.json) and replace the direct absolute path assignment with a
normalization function (e.g., normalizeFilePath or sanitizePath) that strips
/private/tmp or converts to repo-relative or tokenizes fixture names, and add a
unit test ensuring an input absolute temp path becomes a normalized/tokenized
value in the stored JSON. Ensure all places that emit "file_path" use the same
sanitizer to cover the other affected rows.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b43c619b-b04e-4f06-b4be-ff15ea47fe23
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (35)
docs/evidence/dep-health-sweep/proof-of-life-001/findings.jsondocs/evidence/dep-health-sweep/proof-of-life-001/projection_rows.jsondocs/evidence/dep-health-sweep/proof-of-life-001/proof_summary.mddocs/evidence/dep-health-sweep/proof-of-life-001/run_manifest.jsonpyproject.tomlsrc/omnimarket/adapters/llm/bifrost/model_bifrost_delegation_config.pysrc/omnimarket/events/delegation.pysrc/omnimarket/models/delegation/wire/__init__.pysrc/omnimarket/nodes/node_budget_policy_compute/models/model_budget_limits.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_baseline_intent.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_compliance_loop_result.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_delegation_event.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_delegation_request.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_delegation_result.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_inference_intent.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_inference_response_data.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_quality_gate_intent.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_routing_intent.pysrc/omnimarket/nodes/node_delegation_orchestrator/models/model_task_delegated_event.pysrc/omnimarket/nodes/node_delegation_quality_gate_reducer/handlers/handler_quality_gate.pysrc/omnimarket/nodes/node_delegation_quality_gate_reducer/handlers/handler_quality_gate_intent.pysrc/omnimarket/nodes/node_delegation_quality_gate_reducer/models/model_quality_contract.pysrc/omnimarket/nodes/node_delegation_quality_gate_reducer/models/model_quality_gate_input.pysrc/omnimarket/nodes/node_delegation_quality_gate_reducer/models/model_quality_gate_result.pysrc/omnimarket/nodes/node_delegation_routing_reducer/handlers/handler_routing_intent.pysrc/omnimarket/nodes/node_delegation_routing_reducer/models/model_delegation_config.pysrc/omnimarket/nodes/node_delegation_routing_reducer/models/model_routing_tier.pysrc/omnimarket/nodes/node_delegation_routing_reducer/models/model_tier_model.pysrc/omnimarket/nodes/node_llm_delegation_call_effect/handlers/handler_inference_intent.pytests/test_delegation_dto_omnibase_compat_imports.pytests/unit/delegation/test_delegation_chain_e2e.pytests/unit/delegation/test_handler_inference_intent.pytests/unit/delegation/test_handler_quality_gate_intent.pytests/unit/delegation/test_handler_routing_intent.pytests/unit/models/delegation/wire/test_public_exports.py
…ON artifacts CodeRabbit flagged private workspace absolute paths in dep-health-sweep proof-of-life evidence. Replace /private/tmp/.../src/ with src/ in findings.json and projection_rows.json.
Summary
WS-B1 of the SEA e2e OMN-12588 epic. All 29 omnimarket importers of omnibase_compat.contracts.delegation.wire repointed to omnibase_core.models.delegation.wire (graduation completed in OMN-12126).
Evidence-Ticket: OMN-12659
Evidence-Source: 388ae1dbcc65c04b791829a12e198ef621d35214
Changes
Test Results
OCC Receipt
OCC PR #2151 (merged): OmniNode-ai/onex_change_control#2151
OCC merge SHA: 388ae1dbcc65c04b791829a12e198ef621d35214