Skip to content

docs(OMN-14105): genericize onex skills — strip internal operating detail for public exposure - #1869

Merged
jonahgabriel merged 10 commits into
devfrom
jonah/omn-14105-genericize-onex-skills
Jul 9, 2026
Merged

jonahgabriel merged 10 commits into
devfrom
jonah/omn-14105-genericize-onex-skills

Conversation

@jonahgabriel

@jonahgabriel jonahgabriel commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Genericizes plugins/onex/skills/** to remove OmniNode-internal operating context before the public "Fable Going Behind API Pricing" article drives readers to the repo.

Closes OMN-14105.

What changed (85 skill files + new gate)

  • Real identity / PII — a contractor's real name, operator name/email/ssh-user/--author git-filter → ${OPERATOR_*}/${GIT_AUTHOR}/<user> placeholders.
  • Infra — LAN IPs (192.168.86.x) → localhost+env; .201/.200 host nicknames → generic; /Volumes/PRO-G40 machine paths → $OMNI_HOME.
  • Internal doctrine — feedback_*/project_*/reference_* memory-doc citations → inlined principle, doc name dropped.
  • Ticket numbers — specific OMN-<number> → <TICKET>; omni_home prose/vars → "workspace".
  • Preserved (functional, non-sensitive): $OMNI_HOME env, OmniNode-ai org, node_* names, OMN-XXXX/OMN-\d+ placeholders, topic strings.

Enforcement in the same change (Rule #5)

  • scripts/check_public_skill_hygiene.py + scripts/public_skill_hygiene_allowlist.yaml — detects 9 leak classes, allowlists 4 documented keeps (golden-path fixtures, denylist guard IP, generic SSRF test IPs, canonical interpreter path).
  • Wired as a pre-commit hook + CI workflow "Public Skill Hygiene" (required-status context to add to branch protection).

dod_evidence

  • Hygiene gate green: 464 scanned, 0 blocked, 54 allowlisted.
  • Full pre-commit suite green (ruff/mypy/spdx/skill-hygiene/…); pre-push hooks green.
  • Independent verifier re-ran the hygiene gate against this PR head (0 blocked/464 scanned), spot-checked ~10 changed skill files, and re-compiled all 29 changed .py files clean — see OCC companion.

OCC companion

Evidence-Source: OCC#3676
Evidence-Ticket: OMN-14105

@coderabbitai

coderabbitai Bot commented Jul 7, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 4189a068-ba7d-4939-97ab-62a06d93e49f

📥 Commits

Reviewing files that changed from the base of the PR and between df599a0 and 5a573ee.

📒 Files selected for processing (91)
  • .github/workflows/hostile-reviewer.yml
  • .github/workflows/omni-standards-compliance.yml
  • .github/workflows/public-skill-hygiene.yml
  • .github/workflows/security-scan.yml
  • .pre-commit-config.yaml
  • contracts/OMN-14105.yaml
  • plugins/onex/skills/_bin/_common.sh
  • plugins/onex/skills/_bin/_lib/armed_not_enqueued.py
  • plugins/onex/skills/_bin/_lib/ci_status.py
  • plugins/onex/skills/_bin/_lib/ghost_auto_merge.py
  • plugins/onex/skills/_bin/_lib/repo_sync_status.py
  • plugins/onex/skills/_bin/_lib/run_armed_not_enqueued.py
  • plugins/onex/skills/_bin/armed-not-enqueued.sh
  • plugins/onex/skills/_golden_path_validate/golden_path_runner.py
  • plugins/onex/skills/_lib/_filter_helpers.sh
  • plugins/onex/skills/_lib/begin_day/begin_day.py
  • plugins/onex/skills/_lib/contract_generator/generate_contract.py
  • plugins/onex/skills/_lib/contracts/helpers.md
  • plugins/onex/skills/_lib/decision_store/semantic_check.py
  • plugins/onex/skills/_lib/dod-evidence-runner/dod_evidence_runner.py
  • plugins/onex/skills/_lib/generate_ticket_contract/cli_validate_proofs.py
  • plugins/onex/skills/_lib/integration-branch/helpers.md
  • plugins/onex/skills/_lib/merge_planner/track_classifier.py
  • plugins/onex/skills/_lib/plan_to_tickets/detect_structure.py
  • plugins/onex/skills/_lib/pr-safety/helpers.md
  • plugins/onex/skills/_lib/request_agent_routing/execute_kafka.py
  • plugins/onex/skills/_lib/rrh/rrh_adapter.py
  • plugins/onex/skills/_lib/skill_backing_node_allowlist.yaml
  • plugins/onex/skills/_lib/status/status.py
  • plugins/onex/skills/_lib/validate_skill_aspiration.py
  • plugins/onex/skills/_lib/validate_skill_backing_node.py
  • plugins/onex/skills/_shared/friction_aggregator.py
  • plugins/onex/skills/_shared/friction_recorder.py
  • plugins/onex/skills/_shared/friction_signal.py
  • plugins/onex/skills/_shared/kafka_helper.py
  • plugins/onex/skills/_shared/systemd_helper.py
  • plugins/onex/skills/authorize/SKILL.md
  • plugins/onex/skills/changelog_audit/_lib/dispatch.py
  • plugins/onex/skills/checkpoint/SKILL.md
  • plugins/onex/skills/contract_sweep/SKILL.md
  • plugins/onex/skills/contract_sweep/prompt.md
  • plugins/onex/skills/coverage_sweep/SKILL.md
  • plugins/onex/skills/dashboard_sweep/prompt.md
  • plugins/onex/skills/decision_store/examples/query_decisions.md
  • plugins/onex/skills/decision_store/examples/record_decision.md
  • plugins/onex/skills/decompose_epic/SKILL.md
  • plugins/onex/skills/demo/_lib/topics.py
  • plugins/onex/skills/dispatch_engine/_lib/run.py
  • plugins/onex/skills/dispatch_engine/topics.yaml
  • plugins/onex/skills/dispatch_watchdog/SKILL.md
  • plugins/onex/skills/dispatch_worker/SKILL.md
  • plugins/onex/skills/dispatch_worker/prompt.md
  • plugins/onex/skills/docs_dirty_alert/SKILL.md
  • plugins/onex/skills/env_sync_alert/_lib/check.py
  • plugins/onex/skills/epic_team/SKILL.md
  • plugins/onex/skills/epic_team/prompt.md
  • plugins/onex/skills/epic_team/run.sh
  • plugins/onex/skills/executing_plans/SKILL.md
  • plugins/onex/skills/gap/SKILL.md
  • plugins/onex/skills/gap/legacy-denylist.yaml
  • plugins/onex/skills/generate_node/generate
  • plugins/onex/skills/generate_node/regenerate
  • plugins/onex/skills/handoff/SKILL.md
  • plugins/onex/skills/handoff/prompt.md
  • plugins/onex/skills/merge_sweep/topics.yaml
  • plugins/onex/skills/pipeline_fill/SKILL.md
  • plugins/onex/skills/preflight/SKILL.md
  • plugins/onex/skills/progression.yaml
  • plugins/onex/skills/redeploy/topics.yaml
  • plugins/onex/skills/release/prompt.md
  • plugins/onex/skills/rewind/SKILL.md
  • plugins/onex/skills/rolling_plan_governor/SKILL.md
  • plugins/onex/skills/rolling_plan_governor/prompt.md
  • plugins/onex/skills/runtime_closeout/SKILL.md
  • plugins/onex/skills/ship_dirty_canonical/SKILL.md
  • plugins/onex/skills/skill_functional_audit/SKILL.md
  • plugins/onex/skills/skills_to_market_manifest.yaml
  • plugins/onex/skills/system_status/check_database_health/_lib/execute.py
  • plugins/onex/skills/system_status/check_system_health/_lib/execute.py
  • plugins/onex/skills/tech_debt_sweep/SKILL.md
  • plugins/onex/skills/ticketing_insights/config.yaml
  • plugins/onex/skills/ticketing_insights/deep-dive
  • plugins/onex/skills/ticketing_insights/estimation-accuracy
  • plugins/onex/skills/ticketing_insights/setup
  • plugins/onex/skills/ticketing_insights/velocity-estimate
  • plugins/onex/skills/two_strike_arbiter/SKILL.md
  • plugins/onex/skills/verify_plugin/verify-deploy.sh
  • plugins/onex/skills/wave_scheduler/SKILL.md
  • plugins/onex/skills/worktree/SKILL.md
  • scripts/check_public_skill_hygiene.py
  • scripts/public_skill_hygiene_allowlist.yaml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch jonah/omn-14105-genericize-onex-skills

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Jul 7, 2026 •

Copy link
Copy Markdown
Contributor

⚠️ Hostile Reviewer — DEGRADED (informational)

Blocking findings (critical/error): 0
Total findings: 0
Models succeeded: none

Note: All reviewer models failed or were unavailable. Degraded results are informational during the pilot phase (OMN-8524) and do not block merge. Error: cli_review exited non-zero (all models failed or binary error)


Gate semantics (pilot phase)

Verdict Meaning Blocks merge?
passed No critical/error findings No
blocked CRITICAL or ERROR findings found Yes
degraded All models unavailable (infra) No (pilot)

Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)

@jonahgabriel
jonahgabriel disabled auto-merge July 8, 2026 17:00
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-14105-genericize-onex-skills branch from 47e1d3e to b0145f7 Compare July 9, 2026 15:14
…tail for public exposure

Scrub OmniNode-internal operating context from plugins/onex/skills/** before the
public article drives readers to the repo: a contractor's real name, operator
identity/email/ssh-user, LAN IPs + host nicknames, internal memory-doc citations,
specific OMN ticket numbers, and machine paths (/Volumes/PRO-G40, omni_home) ->
env-parameterized or generic placeholders. Preserves functional identifiers
($OMNI_HOME, OmniNode-ai org, node_* names, OMN-XXXX/regex placeholders, topics).

Adds a public-skill-hygiene gate (scripts/check_public_skill_hygiene.py + allowlist
+ pre-commit hook + CI workflow "Public Skill Hygiene") so internal detail cannot
regress into the public skills — detection wired as enforcement in the same change.

Evidence: hygiene gate green (464 scanned, 0 blocked, 54 allowlisted keeps).
@jonahgabriel
jonahgabriel force-pushed the jonah/omn-14105-genericize-onex-skills branch from b4940f2 to 5a573ee Compare July 9, 2026 20:36
@jonahgabriel
jonahgabriel merged commit 62308da into dev Jul 9, 2026
195 of 202 checks passed
@jonahgabriel
jonahgabriel deleted the jonah/omn-14105-genericize-onex-skills branch July 9, 2026 20:59
jonahgabriel added a commit that referenced this pull request Jul 10, 2026
…x + routine) (#1879)

## omniclaude dev→main promotion

Promotes `dev` (5fa434d) to `main` (currently e614e57). 9 commits,
all routine previously-merged/reviewed ci/build/docs/fix work. The
load-bearing change is the OMN-14244 deploy-gate matcher fix, which
callers (omnibase_core/omnibase_infra/omnimarket) resolve from
omniclaude `@main` — this promotion is required to unblock
omnibase_infra#2245 (OMN-14190 Piece-4).

Promotion branch tree equals `origin/dev` (`-s ours
--allow-unrelated-histories` merge of `origin/main` for mergeability
only — `origin/main` and `origin/dev` have no common git ancestor in
this repo's history; verified `git diff origin/dev` on the promotion
branch is empty). dev-head (5fa434d) is an ancestor of this branch so
the cited OCC receipt binds.

Tracked under a dedicated promotion ticket (OMN-14249, following the
OMN-13828 promotion-ticket precedent) so the OCC receipt binds cleanly
to this PR's number without superseding the already-merged
OMN-14244/OMN-14190 contracts. Branch renamed from an earlier
`promotion/omn-14244-...` attempt (#1878, closed) because the repo's DoD
Evidence Check hard gate derives its required ticket from the branch
name.

### Commits (origin/main..origin/dev)

- `5fa434d06` fix(OMN-14244): narrow deploy-gate runtime-path matcher
(stop false-positiving non-deploy CLIs, catch real deploy CLIs) (#1876)
- `1b74ec1f0` feat(OMN-14190): wire OCC stamp/validate pre-commit hook
(#1875)
- `62308da2e` docs(OMN-14105): genericize onex skills — strip internal
operating detail for public exposure (#1869)
- `60cfec6fd` ci(OMN-14176): keep hostile reviewer on dev torch-free
path (#1873)
- `df599a05c` docs(OMN-13961): handoff skill writes canonical
docs/handoff/ (singular) not docs/handoffs/ (#1864)
- `8e19db1b2` build(OMN-14178): bump omniintelligence pin to torch-free
base (post-#768 rl split) (#1874)
- `a6272b37d` ci(OMN-13502): flip no-faked-boundary gate report-only ->
enforcing (#1860)
- `b94d846db` ci(OMN-13902): sibling-lock-refresh workflow (fan-out)
(#1857)
- `12fe25f4d` fix(OMN-13940): unquarantine executable merge sweep cron
(#1861)

### Note on `a6272b37d` (no-faked-boundary: report-only -> enforcing)

This is a hardening flip, not a behavior regression — omniclaude's
self-scan was burned to zero findings before the flip (OMN-13500/#1849)
and the job is not yet a required branch-protection context (documented
as a deliberate follow-up in #1860's own body), so it cannot wedge this
or any other PR.

### Why this is not a prod/runtime action

This is a `dev -> main` release-branch promotion for the omniclaude repo
(a Claude Code plugin repo). It does not touch `.201`, any prod compose
lane, or any live runtime. Operator-authorized (OMN-14190 Piece-4
chain).

promotion-receipt: OCC-3791
Evidence-Source: OCC#3791
Evidence-Ticket: OMN-14249
Evidence-Commit: 40b994cd457bdd5cc71b123c8787114ea891c0ce

Refs OMN-14249, OMN-14244, OMN-14190, OMN-13502. Supersedes #1877/#1878
(closed).

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: jonahgabriel <jonahgabriel@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant