Repository navigation
feat(OMN-13023): UTC timestamp discipline pre-commit hook — reject Z-suffixed times adjacent to mtime citations (retro B-11) - #1746
Conversation
…suffixed times adjacent to mtime citations (retro B-11) Rejects Z-suffixed clock times cited on the same line as a file-mtime marker (ls -l, mtime, Finder, last modified) in docs/handoffs/** and docs/evidence/** markdown. Local mtimes relabeled as UTC manufactured the false '16:00Z mass worker death / 4h undetected' outage narrative on 2026-06-11 (PROCESS_FAILURE_RETRO.md §5.1). Escape hatch: 'utc-ok: <reason>' on the line. - .pre-commit-hooks/check-utc-timestamp-discipline.sh (language: script) - wired in .pre-commit-config.yaml stage-1 pre-commit block - 7 unit tests + 3 fixtures (reject, date-u pass, escape hatch, scope guards) Epic OMN-13013 (process enforcement ratchets — June 12 retro).
|
Warning Review limit reached
More reviews will be available in 28 minutes and 1 second. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more credits in the billing tab to continue. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (6)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
| Verdict | Meaning | Blocks merge? |
|---|---|---|
passed |
No critical/error findings | No |
blocked |
CRITICAL or ERROR findings found | Yes |
degraded |
All models unavailable (infra) | No (pilot) |
Powered by omniintelligence.review_pairing.cli_review — node-based adversarial review via HandlerLlmCliSubprocess (OMN-8524)
Summary
Retro B-11 (PROCESS_FAILURE_RETRO.md §3.B / §5.1): new pre-commit hook
check-utc-timestamp-discipline.shrejecting Z-suffixed clock times cited adjacent to file-mtime markers indocs/handoffs/**anddocs/evidence/**markdown.Failure class prevented: the 2026-06-11 evening handoff transcribed local-EDT
ls -lmtimes with aZsuffix, manufacturing a false "16:00Z mass worker death / 4h undetected" outage narrative that the architecture investigation initially consumed as fact (refuted-finding §5.1).Ticket: OMN-13023 (epic OMN-13013 — process enforcement ratchets, June 12 retro).
Changes
.pre-commit-hooks/check-utc-timestamp-discipline.sh— same-line detection of mtime marker +HH:MM[:SS]Ztime; staged-index read with working-tree fallback (mirrorscheck-handoff-infra-health.sh); escape hatchutc-ok: <reason>; hard fail, no warn-only (CLAUDE.md Rule Phase 3: Local Template System Implementation #5)..pre-commit-config.yaml— wired in the stage-1 pre-commit block.tests/hooks/test_check_utc_timestamp_discipline.py— 7 unit tests (reject in handoffs + evidence, date-u-sourced pass, escape hatch, out-of-scope doc/extension guards, executable bit) + 3 fixtures.Verification
uv run pytest tests/hooks/test_check_utc_timestamp_discipline.py -v— 7/7 pass.uv run pytest tests/ -q -m "not integration"— 3 failed, 11074 passed; all 3 failures verified pre-existing on clean origin/dev (22fe1d6) via stash/run/restore and ticketed as OMN-13064 (delegation test_runner x2, sweep_preflight cached_block). Full integration leg requires the localbus-localbroker (OMN-3571 guard); CI runs the full matrix.uv run pre-commit run --files <changed files>— clean. Two--all-filesfailures (hardcoded-topics inplugins/onex/skills/demo/_lib/dispatch.py, legacy-session-id inplugins/onex/hooks/lib/delegation_hook_runner.py) are pre-existing on dev tip in files untouched by this diff.Evidence-Source: de777bb6b3faec7de229103ee81843bed4942fbc
Evidence-Ticket: OMN-13023