Skip to content

fix(OMN-1992): Follow-up review fixes for PluginIntelligence bootstrap #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonahgabriel merged 1 commit into from
Feb 8, 2026
Merged

fix(OMN-1992): Follow-up review fixes for PluginIntelligence bootstrap #266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/omnibase_infra/nodes/node_registration_orchestrator/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,7 +867,10 @@ async def start_consumers(

# Duck typing: check for subscribe capability rather than concrete type
# Per CLAUDE.md: "Protocol Resolution - Duck typing through protocols, never isinstance"
if not hasattr(config.event_bus, "subscribe"):
if not (
hasattr(config.event_bus, "subscribe")
and callable(getattr(config.event_bus, "subscribe", None))
):
return ModelDomainPluginResult.skipped(
plugin_id=self.plugin_id,
reason="Event bus does not support subscribe",
Expand Down
5 changes: 5 additions & 0 deletions src/omnibase_infra/runtime/service_kernel.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -730,6 +730,11 @@ async def bootstrap() -> int:
version=config.contract_version or "v1",
)
else:
# Graceful degradation (OMN-1992): config.name absence is logged
# rather than raising ProtocolConfigurationError so kernels with
# optional introspection can still boot. Plugins that require
# node_identity (e.g. PluginRegistration.start_consumers) will
# return a "skipped" result instead of failing.
logger.error(
"runtime_config.yaml missing 'name' field — plugin consumers "
"will not subscribe to introspection events. "
Expand Down