Repository navigation
fix(infra): OMN-9154 import DEFAULT_INTROSPECTION_TOPIC from model SoT - #1392
Conversation
The CLI previously held its own `DEFAULT_INTROSPECTION_TOPIC` derived from the generated `EnumPlatformTopic` enum. Align the CLI with the canonical model-level default (`model_introspection_config.DEFAULT_INTROSPECTION_TOPIC`, which resolves to `SUFFIX_NODE_INTROSPECTION`) so there is a single source of truth for the topic. Add a unit test that guards against drift between the CLI default, the model default, and `SUFFIX_NODE_INTROSPECTION`. The `envvar="ONEX_INTROSPECTION_TOPIC"` operator-override knob is left in place; the allowlist-vs-ban decision is the responsibility of OMN-9151 child #1 and is intentionally out of scope here.
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 5 minutes and 54 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Ticket: OMN-9154 — replace
DEFAULT_INTROSPECTION_TOPIChardcoded literal incli/infra_test/introspect.pywith import from the canonical source.The original hardcoded literal was removed in a prior PR (OMN-7226), but the CLI still held its own copy of
DEFAULT_INTROSPECTION_TOPICderived from the generatedEnumPlatformTopic. This PR:DEFAULT_INTROSPECTION_TOPICdirectly fromomnibase_infra.models.discovery.model_introspection_config(the canonical model-level default that resolves toSUFFIX_NODE_INTROSPECTION), removing the CLI-layer duplicate.TestDefaultIntrospectionTopicSoTthat guard against drift:SUFFIX_NODE_INTROSPECTION.Acceptance criteria
model_introspection_config.DEFAULT_INTROSPECTION_TOPIC).TestDefaultIntrospectionTopicSoT).Scope note
The
envvar="ONEX_INTROSPECTION_TOPIC"operator-override knob on line 104 is intentionally left in place. The allowlist-vs-ban decision for*_TOPICenvvars is the responsibility of OMN-9151 child #1 (validator) and is out of scope here.dod_evidence
tests/unit/cli/infra_test/test_introspect.py::TestDefaultIntrospectionTopicSoT(2 tests, both PASS)tests/unit/cli tests/unit/mixins/test_mixin_node_introspection.py tests/unit/models/discovery: 418 PASSTest plan
uv run pytest tests/unit/cli/infra_test/test_introspect.py -v— 18/18 PASSuv run pytest tests/unit/cli tests/unit/mixins/test_mixin_node_introspection.py tests/unit/models/discovery -v— 418/418 PASSuv run ruff format && uv run ruff check— cleanpre-commit run --files ...— all hooks passed