Repository navigation
ci(OMN-20969): omnibase_core's repo-evidence caller stops comparing with OCC on dev (S6 precursor for omnibase_core#1930) - #1954
Merged
Conversation
jonahgabriel
enabled auto-merge (squash)
October 11, 2026 15:20
jonahgabriel
pushed a commit
to OmniNode-ai/onex_change_control
that referenced
this pull request
Oct 11, 2026
…13687) * evidence(OMN-20969): author OCC companion for OmniNode-ai/omnibase_core#1954 OCC companion by node_pr_lifecycle_fix_effect (OMN-13317 F1 / OMN-13990 / OMN-14285). Product PR head 7769ecff88c70a97149639140e5cdee9160ca057. * evidence(OMN-20969): self-bind OCC#13687 + rebind contract_sha256 --------- Co-authored-by: omnimarket-bot <bot@omninode.ai>
Expect compare-with-occ false after the caller cutover and name the test for the ticket. Preserve every other assertion in the file.
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Child ticket: OMN-20969. Parent: OMN-20074.
The caller runs on pull_request_target, so omnibase_core#1930 is judged by dev's caller input. Dev currently passes compare-with-occ "true"; #1930 removes the OCC result producer, and its repo-evidence job waits for the absent result and exits 1.
Set compare-with-occ to "false" on dev and update the S5 comment for S6. Preserve every other caller input, the reusable workflow pin and the remaining workflow lines. OCC producers and required contexts remain until the separate cutover. The existing caller test now expects the S6 value. The child contract binds AC1 and AC2 to a focused pytest file that compares against the base and rejects injected drift.
Lab: host=h101 lane=occ-ret-coreoccfalse-k3-5d21 command=/Users/jonah/omni_home/omnibase_core/.venv/bin/python -m pytest tests/ci/test_s6_caller_occ_disabled_omn20969.py -q -n 0 --no-cov observed=3 passed; before the edit, 2 failed and 1 passed.
Additional lab controls: omnimarket 0.4.305 verifies the child contract at the staged tree (1/1 checks) and fails at the base. The pinned receipt-gate predicate disables OCC comparison with "false" and no OCC result; the same verifier's "true" no-result control exits 1 with not_compared. Advisory job gate returns 0 findings against the cached 37-context list; a separate offline 34-context control returns exit 1 with 4 findings.
Ruff, mypy, contract schema and focused YAML formatting passed. Full pre-commit in the remote sandbox could not resolve origin/dev for the required-context producer hook; the launching host must complete governed hooks before publishing.
On dev plus this precursor, #1930's exact-head AC3, AC22 and AC23 test files still fail because OCC contexts, callers and the workflow budget remain. Their comparison assertions pass. This is a prospective base control, pending this PR's merge.
Evidence-Ticket: OMN-20969
Evidence-Source: OCC#13687