Repository navigation
ci(OMN-20074): omnibase_core S6 part 2, delete the OCC callers and stop comparing with OCC - #1930
Conversation
09e9323 to
096d4b1
Compare
096d4b1 to
1c02afa
Compare
|
Lab: head=1c02afacf14b887913182236c1db11be24d7bc4f host=h201 lane=occ-ret-core-s6-d3-5d21 command="uv run pytest -n 4 -p no:randomly -q tests/ci/test_no_occ_callers_omn20074.py tests/ci/test_repo_evidence_caller_omn20074.py tests/ci/test_s6_part1_cutover_omn20074.py tests/ci/test_workflow_uses_refs_resolve.py tests/unit/scripts/ci/test_ci_summary_gate.py tests/unit/validation/test_auto_merge_workflow_shape.py tests/unit/validation/test_quality_gate_docs_only_short_circuit_omn16625.py tests/validation/test_pull_request_workflow_ratchet.py tests/ci/test_ci_fold_gates_omn20074.py tests/scripts/test_propagate_config.py tests/ci/test_ci_summary_l4_wait_omn20522.py" result="383 passed"
|
S6 part 2 of the OCC retirement for omnibase_core, mirroring omnibase_infra#4792; stacked on S6 part 1 (omnibase_core#1929). Deleted call-occ-autobind.yml, occ-companion-merge-heal.yml, call-receipt-gate.yml. Removed occ-companion-effect, occ-companion-merged, contract-compliance jobs from ci.yml. Removed deferred test_passes step from CI Summary; timeout back to 140 minutes. Removed embedded occ-preflight job, needs edges, and if: always() lines from 37 workflows. Kept occ-preflight.yml, receipt-gate.yml, occ_preflight_wait.py, check_occ_companion_merged.py. Deleted occ_companion_merge_heal.py, occ_manual_replay_precheck.py, resolve_contract_compliance_evidence.py, run_contract_compliance_with_evidence.py, defer_test_passes_driver.py, deferred_test_passes_gate.py, and their tests. ci_summary_gate.py: GATE_JOBS and STRICT_SUCCESS_JOBS drop two OCC-era entries. required-checks.yaml: occ-preflight, verify, occ-companion-effect, Contract Compliance RETIRED. call-repo-evidence-gate.yml: compare-with-occ "false". PR-workflow budget 30 -> 29; call-occ-autobind.yml waiver closed. contracts/OMN-20074.yaml adds AC8 bound to tests/ci/test_no_occ_callers_omn20074.py. contracts/OMN-17427.yaml drops AC1-AC3 (the contract-compliance dep-scope push behaviour, whose job this deletes).
test_occ_born_path_pins_are_dev_not_main (OMN-14941 F1 pin) held both OCC born-path callers to one omniclaude sha; S6 part 2 deletes both callers, so it failed with an empty set. Replaced by test_no_occ_born_path_caller_remains_after_the_s6_cutover, asserting the map of omniclaude call-occ-* callers is empty; the unused re import is removed. Found by the lab run of the wider CI test directories at 2323bea (work unit lw-cd68afc903304701).
Declares auto-merge.yml jobs pre-check and auto-merge, and propagate-config.yml job propagate, as automation with `# advisory-automation: OMN-20074 <what it automates>`. These are the three advisory-job-gate UNENFORCED_VERIFICATION_JOB findings this branch carries once the OCC preflight caller is deleted. The gate that reads the declaration is the omniclaude advisory-job-gate change for OMN-20074; this repo's caller pin must move to that change's squash commit before the declarations are read in CI. Authority: operator RULING 2026-10-10T15:10:25Z.
Moves the uses: pin in .github/workflows/advisory-job-gate.yml from 966d61ce9f0c2eb6e18b317c2453bdfbe9eeb7d0 to 52227ebfeb738cde2f671104270a0e01071b9e53, the squash commit of omniclaude#2659. This is the first advisory_job_gate that reads and checks the "# advisory-automation:" declarations added to auto-merge.yml and propagate-config.yml. Between the pins, only scripts/advisory_job_gate.py changed; config/advisory_job_baseline.yaml and the reusable workflow are unchanged. Offline runs at the old pin FAIL with 3 UNENFORCED_VERIFICATION_JOB findings, while runs at the new pin PASS with 0 findings under both context lists.
84db795 to
2460d99
Compare
…-part2 # Conflicts: # contracts/OMN-20074.yaml
Remove declaration marker from comment in advisory-job-gate.yml. Comment now says "advisory-automation declarations" without the marker. Gate reports PASS (0 findings) with 37 and 34 required contexts.
|
Lab: head=04272ebb187b859b27aaf456a1f2c2e934fb486d host=h201 lane=occ-ret-core1930-k1-5d21
|
# Conflicts: # .github/workflows/call-repo-evidence-gate.yml # tests/ci/test_s6_part1_cutover_omn20074.py
|
Lab: head=494ae04f307e74b06fe30be8799c876539502917 Resolved two conflicts on host h200 (lane surge-core-1930-7-8e80) for the merge of origin/dev 6c9ec59 into the branch. The old head was 04272eb; the new head is 494ae04, pushed as a normal fast-forward push, not forced.
|
Brings in OMN-21008 (#1957): the pr-title job runs omnimarket's node_pr_title_check_compute inline instead of the onex_change_control reusable. Conflict in .github/workflows/pr-title-check.yml: keep dev's inline pr-title job and drop the occ-preflight job plus pr-title's "needs: occ-preflight" / "if: always()", as OMN-20074 does. tests/ci/test_pr_title_check_omnimarket_node.py (added on dev) asserted the occ-preflight dependency; it now asserts pr-title has no needs/if and the occ-preflight job is absent. .github/required-checks.yaml auto-merged.
|
landing-controller (OMN-20768): worker lease L6467 pushed head 9929d62 (dispatched on 494ae04), and its own change touches what judges this pull request: tests/ci/test_pr_title_check_omnimarket_node.py (check_test). The controller does not land a head whose checks were changed by the worker sent to make them pass, so omnibase_core#1930 is held with the hold:needs-review label and gets no further fix worker. A person reviews the change: when the check itself was wrong, its fix belongs in a separate pull request whose title says it fixes that check, and the worker's edit is reverted here; when the edit is right, remove the label and the controller lands the head on its next tick. |
Summary
if: always()lines and needs.occ-preflight conditions are removed. contract-validation.yml as changed by ci(OMN-20074): contract-validation validates with the in-tree ModelTicketContract, not onex_change_control #1945 merged cleanly with this removal.Why this is a draft
Kept on purpose
Changes
Tests and verification
All on lab host h201, at head 04272eb unless stated:
Lab: host h201, lane occ-ret-core1930-i5-5d21, head 04272eb; commands: uv run pytest on the four files above (115 passed, exit 0), uv run pytest tests/ci -k "omn20074 or omn_20074" (116 passed, exit 0), python -m omnimarket.nodes.node_dod_verify --ticket-id OMN-20074 --execution-audience hosted (verified 28/28, exit 0; merge-base control failed 3, exit 1), advisory_job_gate (0 findings, exit 0; positive control 3 findings, exit 1).