Replace Solhint with Forge lint

[0xJem]

Summary

• Replace Solhint package scripts with forge lint scripts and remove Solhint config/dependency.
• Update markdownlint-cli, keep markdown table-style compatibility explicit, and remove stale pnpm overrides from workspace policy.
• Keep direct dependency declarations honest by retaining ajv for emergency config schema validation and adding direct glob for the metrics script.
• Update local agent/docs references from Solhint or npx prettier to the repo-owned Forge lint and pnpm execution paths.

Validation

• pnpm install --no-frozen-lockfile
• pnpm install --frozen-lockfile
• pnpm audit --audit-level moderate
• pnpm run prettier:check
• pnpm run markdownlint:check
• node shell/validate-emergency-config.js
• forge lint
• forge build
• git diff --check

node shell/validate-emergency-config.js still reports the existing zero-address emergency multisig warnings for arbitrum and optimism, but exits successfully.

Summary by CodeRabbit

• Chores

  • Updated project linting to use the current Solidity lint toolchain and refreshed the related command scripts.
  • Removed an outdated Solidity lint configuration and adjusted workspace dependency overrides.
  • Bumped several development packages and updated formatting/linting settings.

• Documentation

  • Revised contributor guidance to reflect the new lint commands and formatting workflow.

[coderabbitai]

📝 Walkthrough

Walkthrough

The PR updates linting and formatting instructions to use forge lint, forge-lint, and pnpm exec prettier. It also adjusts workspace overrides, package scripts, dependency versions, and disables markdownlint rule MD060.

Changes

Lint toolchain refresh

Layer / File(s)	Summary
Scripts and override entries package.json, pnpm-workspace.yaml	package.json wires lint and lint:check through forge lint commands, updates devDependencies, and pnpm-workspace.yaml rewrites the overrides block.
Lint guidance AGENTS.md, .claude/skills/lint-fix/SKILL.md	AGENTS.md and the lint-fix skill replace solhint commands with forge-lint commands across the lint workflow guidance.
Formatting doc and markdown rule .claude/commands/update-emergency-config.md, .markdownlint.json	The emergency-config instructions use pnpm exec prettier, and .markdownlint.json disables MD060.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• OlympusDAO/olympus-v3#198: Touches the same emergency-config documentation and its JSON formatting step.
• OlympusDAO/olympus-v3#197: Updates the lint-fix skill and lint command guidance that this PR also switches from solhint to forge-lint.
• OlympusDAO/olympus-v3#280: Updates a related linting flow to use Foundry lint tooling in repo automation.

Suggested reviewers

• zeroxnoodle

Poem

A bunny hopped through scripts at dawn,
and solhint’s old trail was gently gone.
With forge and prettier, crisp and new,
markdown rests where lint winds blew.
Hoppy toolchains, thump-thump, shine on! 🐇

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the main change: migrating linting from Solhint to Forge lint.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch dependency-lint-tooling

---

_{Comment @coderabbitai help to get the list of available commands.}

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	ajv@​8.20.0
	glob@​13.0.6
	markdownlint-cli@​0.49.0

View full report

[0xJem]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[0xJem]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[0xJem]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@AGENTS.md`:
- Line 31: The AGENTS.md lint guidance is too tool-specific and should be
rewritten to describe the workflow by capability rather than naming a package
manager or specific commands. Update the linting bullet in the AGENTS guidance
to refer generically to formatting, Solidity linting, and Markdown linting, and
keep the rest of the contributor instructions aligned with the same
tool-agnostic style.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 3196851e-5fa6-4cb9-bde8-3abddf266163

📥 Commits

Reviewing files that changed from the base of the PR and between 78e531b and 1a03b27.

⛔ Files ignored due to path filters (1)

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (7)

• .claude/commands/update-emergency-config.md
• .claude/skills/lint-fix/SKILL.md
• .markdownlint.json
• .solhint.json
• AGENTS.md
• package.json
• pnpm-workspace.yaml

💤 Files with no reviewable changes (1)

• .solhint.json