Skip to content

Add forge lint inline annotations - #280

Merged
0xJem merged 2 commits into
developfrom
ci/forge-lint-inline-action
May 5, 2026
Merged

0xJem merged 2 commits into
developfrom
ci/forge-lint-inline-action

Conversation

@0xJem

@0xJem 0xJem commented May 5, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Add 0xJem/forge-lint-inline-action to the lint CI workflow.
  • Pin the action to the commit behind v0.1.0 while documenting the release version in the workflow.
  • Reuse the existing Foundry install from bootstrap and fail only on Forge lint errors.

Validation

  • pnpm exec prettier --check .github/workflows/lint.yml
  • git diff --check -- .github/workflows/lint.yml

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow to enforce stricter permissions and added enhanced linting verification to maintain code quality standards.

@coderabbitai

coderabbitai Bot commented May 5, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cf9ee022-72d0-4c39-acfe-4e3033dd1fc5

📥 Commits

Reviewing files that changed from the base of the PR and between a385067 and a61879d.

📒 Files selected for processing (1)
  • .github/workflows/lint.yml

📝 Walkthrough

Walkthrough

The CI lint workflow is updated to enforce job-level permission scoping (contents: read) and adds a new forge-lint inline annotation step that runs before the existing pnpm lint check.

Changes

CI Workflow Configuration

Layer / File(s) Summary
Job Permissions
.github/workflows/lint.yml
Adds explicit permissions block restricting job to contents: read access.
Forge Lint Step
.github/workflows/lint.yml
Introduces 0xJem/forge-lint-inline-action step with install-foundry: false and fail-level: error before the existing pnpm lint check.

Possibly Related PRs

  • OlympusDAO/olympus-v3#273: Both PRs adjust Foundry-related CI configuration; this PR adds forge-lint with disabled Foundry installation while the related PR pins Foundry in bootstrap.

Suggested Reviewers

  • pbendus
  • zeroxnoodle

Poem

🐰 A lint step arrives, clean and neat,
With permissions set just right,
Forge annotations, oh so sweet,
Catching issues before they fight!


🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Add forge lint inline annotations' clearly and specifically summarizes the main change: adding a forge lint inline action to the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch ci/forge-lint-inline-action

Comment @coderabbitai help to get the list of available commands and usage tips.

@0xJem 0xJem self-assigned this May 5, 2026
@0xJem

0xJem commented May 5, 2026

Copy link
Copy Markdown
Member Author

There won't be a linter warning that shows up here (as the files haven't been changed), but there's an example here: https://github.com/0xJem/forge-lint-inline-smoke/pull/2/changes#diff-b6586feef6fa6c91578ddcdea86de0e77403f8309d4e576b0f9f56bc518f793b

@0xJem
0xJem marked this pull request as ready for review May 5, 2026 13:24
@0xJem
0xJem requested a review from zeroxnoodle May 5, 2026 13:25
@0xJem
0xJem merged commit e2ab2e6 into develop May 5, 2026
13 of 15 checks passed
@0xJem
0xJem deleted the ci/forge-lint-inline-action branch May 5, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants