5.x Adds Shimmer component to #5886
Merged
dzearing merged 10 commits intomicrosoft:5.0from Aug 10, 2018
Merged
Conversation
Vitalius1
requested review from
JasonGore,
ThomasMichon,
atneik and
natalieethell
dzearing
approved these changes
Aug 9, 2018
atneik
approved these changes
Aug 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
Needed for a smoother transition from Shimmer in experiments package to Shimmer in OUFR for our internal consumers who use a combination of 5.0 and 6.0.
This is a cherry pick of current Shimmer into 5.0 branch. Changed back all prettier formatting changes and brought back the getStyles prop to be inline with 5.0 API.
This code is basically the existing one on master so hoping for a quick merge so I can proceed with another cherry-pick for ShimmeredDetailsList.
Microsoft Reviewers: Open in CodeFlow